From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82C00A04E7; Tue, 3 Nov 2020 22:37:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58A8634EE; Tue, 3 Nov 2020 22:37:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id AF05D1DBD for ; Tue, 3 Nov 2020 22:37:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604439435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R9gO6OOZ6EzWUZ4mpUjQYLaqZ7lu1Rm8xjTllJzD1Rk=; b=Ww1gik4LlVOp436bJJapjULqyi5wtcxixGaPqiK2F+KtniInE5DCmzvvKy5aWy+ZJdxC1I yMBmN9LV7pvdUjTCPNQgI4IwdHXA/ozf+KiTb1VOORLq8xee6gWSuMx04u72IN8zDd5td7 eKa+nRMVfl/ioXs8npu79BLmHseuYUs= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-TJ2QOW0AP7aQ1DvSJGlplg-1; Tue, 03 Nov 2020 16:37:10 -0500 X-MC-Unique: TJ2QOW0AP7aQ1DvSJGlplg-1 Received: by mail-ua1-f71.google.com with SMTP id u22so1559319uae.1 for ; Tue, 03 Nov 2020 13:37:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R9gO6OOZ6EzWUZ4mpUjQYLaqZ7lu1Rm8xjTllJzD1Rk=; b=jQdxq1oQgxd0sGe9pkmiyickEaoDw24F+860RrqdrKkHF3hEu8JotIgJuFTt01P7k9 gu9E6oj9wSAzBbzkisA2sPKYFW1sZ+//upSqMqv+Lvkf6eWfKnergqAt25e9Y8X7biOE 7wSXpAoIQlMXb2qSOILMroVp221eTIpnbpQ57hoaKvpad8MhcdJ4T1M9mXs3yXIf9Zji jvZUoEKUxntF2UmQwBB+LqH0ok+U2Hnr9hhUGPN9yRA2AIFLbhGxzOQYWiAZkOa2aAXL F1xOokJqN4xdYpo20xwxecXhKD7VNln6ab4lh02LxtVggSzZ1NVzBcDh09reiGoN4cm0 6bmA== X-Gm-Message-State: AOAM5339o+wzqJcCzK92dEP9oI/htoDM0kAbTJEE8xQcfQwbVQlg0Vpj 8AZqANkzDv3k7YID0AAOOmGyDl1QOVVidc/Cd0cEmnNbA9DUVnaqa+zrADGi/0hCkWPM8Rdgg6V BJnEd+hgj6thEaObW7hg= X-Received: by 2002:a67:f54b:: with SMTP id z11mr9958554vsn.17.1604439429805; Tue, 03 Nov 2020 13:37:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHO7tllhgpI/7fiiVC2vPSy8zlBRY8yQyToSN3/4T+qAPzAbz37BPlN28UghoET2aaET/jXqGb1OjrsdQ5TAs= X-Received: by 2002:a67:f54b:: with SMTP id z11mr9958546vsn.17.1604439429665; Tue, 03 Nov 2020 13:37:09 -0800 (PST) MIME-Version: 1.0 References: <20200731034520.30791-1-gaurav1086@gmail.com> <20200808163906.8021-1-gaurav1086@gmail.com> In-Reply-To: From: David Marchand Date: Tue, 3 Nov 2020 22:36:58 +0100 Message-ID: To: Gaurav Singh , "Power, Ciara" Cc: Honnappa Nagarahalli , "dev@dpdk.org" , nd Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] lib/metrics: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 30, 2020 at 3:59 PM David Marchand wrote: > > This does fix the resource leak, but I do think it can be done in a > > simpler way, as shown in the patch I sent to fix the logged coverity issue > > for this: https://patchwork.dpdk.org/patch/78052/ > > I will remove my patch seeing as this patch is fixing the same thing. > > I agree with Ciara. > Could you respin? I went with Ciara patch as it is minimal and ready to be merged. Thanks. -- David Marchand