From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D97E43208; Thu, 26 Oct 2023 15:48:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4574F40DDC; Thu, 26 Oct 2023 15:48:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4C9FD402EE for ; Thu, 26 Oct 2023 15:48:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698328092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I9cajLuvErXTg6A6uGTlhSPiLeXe+y+KPt2CJrIPk3U=; b=LucGxdgROSjgcMU/BsavP+OCTmfgYl102Apq3HsWfOgXgSNHxPBLlxILnbMI4NKT8d2QkA E/qObIeOulvVKwR6/NIEgjdIiLrSGPSK0fB6VG7blCECR6KRpMo6Px7l8wdGjgyI0mF0cG U/zDue9o5XYxxDWlf+jX1pGM/zcilpQ= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-qeImKYc-ObmFdMXst12k_A-1; Thu, 26 Oct 2023 09:48:11 -0400 X-MC-Unique: qeImKYc-ObmFdMXst12k_A-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c503b47880so5601031fa.0 for ; Thu, 26 Oct 2023 06:48:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698328090; x=1698932890; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I9cajLuvErXTg6A6uGTlhSPiLeXe+y+KPt2CJrIPk3U=; b=OC8dVkJylitZFjTX4qL75v4W3Y1bsHdJxyKaVFNR96Wh0LFoSibC6FRfmUvXHLO8NW hmJQPX37pC2snQdXN/uKWbrsYCc88zaQRMrnTMSMbPTS197kTEbPIqARV3z+csBftNCb vxOR/NzTX2/zWPk8Yu3sh2bV4KbXVKp/Z97Bzw+vHeK0TVRevANxonm8iZ4ATBplBWU/ 7DGHnK3/grhF5nnNb83UGMx3yDaqgHIXavsPzSFxuG0P7QgxoD/tkgSRXiXSpDo+yFTZ ThcTBbZ4x64tviBCZ024uYZVvjB0MCHFy2WS798JdFDoiAMHxuIwFvT/d4XPiYfrcSZX I/Pw== X-Gm-Message-State: AOJu0Yz1wyjCA4JiMvNIHKVQbk4JRl3c6MfXsMyUl/tzsloAkzSySJEA JSUx3QRyVmgIPEzTxDnOiTcpOnIoXGpCpocW+fJEdl9FuxAkVKylHfWbG0Z4B+ZUfl+m5wBm+Rl +PraAwa2dXjD5kSnEq3M= X-Received: by 2002:a2e:a7d4:0:b0:2c5:70b:2c21 with SMTP id x20-20020a2ea7d4000000b002c5070b2c21mr868054ljp.22.1698328089922; Thu, 26 Oct 2023 06:48:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvKJzZM4sIYTeYofJaVkqWNV9LLR5FK0ruDxP3ALkPbVg6L02eVtHeTK7Qok8mPSED4LK+6D3X7p2hbvYXcTI= X-Received: by 2002:a2e:a7d4:0:b0:2c5:70b:2c21 with SMTP id x20-20020a2ea7d4000000b002c5070b2c21mr868034ljp.22.1698328089578; Thu, 26 Oct 2023 06:48:09 -0700 (PDT) MIME-Version: 1.0 References: <1697497745-20664-1-git-send-email-roretzla@linux.microsoft.com> <1698280314-25861-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1698280314-25861-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Thu, 26 Oct 2023 15:47:58 +0200 Message-ID: Subject: Re: [PATCH v3 00/19] use rte optional stdatomic API To: Tyler Retzlaff Cc: dev@dpdk.org, Akhil Goyal , Anatoly Burakov , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Ciara Power , David Christensen , David Hunt , Dmitry Kozlyuk , Dmitry Malloy , Elena Agostini , Erik Gabriel Carrillo , Fan Zhang , Ferruh Yigit , Harman Kalra , Harry van Haaren , Honnappa Nagarahalli , Jerin Jacob , Konstantin Ananyev , Matan Azrad , Maxime Coquelin , Narcisa Ana Maria Vasile , Nicolas Chautru , Olivier Matz , Ori Kam , Pallavi Kadam , Pavan Nikhilesh , Reshma Pattan , Sameh Gobriel , Shijith Thotton , Sivaprasad Tummala , Stephen Hemminger , Suanming Mou , Sunil Kumar Kori , Thomas Monjalon , Viacheslav Ovsiienko , Vladimir Medvedkin , Yipeng Wang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 26, 2023 at 2:32=E2=80=AFAM Tyler Retzlaff wrote: > > Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API. > > v3: > * add missing atomic specification on head variable > in struct rte_ring_headtail > * adapt to use rte_atomic_xxx stdatomic API in rte_ring_c11_pvt.h > * split comma operator statement into 2 statements > > v2: > * add #include to rte_mbuf_core.h > * remove first two patches which were fixes that have > been merged in another series > > Tyler Retzlaff (19): > power: use rte optional stdatomic API > bbdev: use rte optional stdatomic API > eal: use rte optional stdatomic API > eventdev: use rte optional stdatomic API > gpudev: use rte optional stdatomic API > ipsec: use rte optional stdatomic API > mbuf: use rte optional stdatomic API > mempool: use rte optional stdatomic API > rcu: use rte optional stdatomic API > pdump: use rte optional stdatomic API > stack: use rte optional stdatomic API > telemetry: use rte optional stdatomic API > vhost: use rte optional stdatomic API > cryptodev: use rte optional stdatomic API > distributor: use rte optional stdatomic API > ethdev: use rte optional stdatomic API > hash: use rte optional stdatomic API > timer: use rte optional stdatomic API > ring: use rte optional stdatomic API > > drivers/event/cnxk/cnxk_tim_worker.h | 4 +- > drivers/net/mlx5/mlx5_hws_cnt.h | 4 +- > lib/bbdev/rte_bbdev.c | 6 +- > lib/bbdev/rte_bbdev.h | 2 +- > lib/cryptodev/rte_cryptodev.c | 22 +++--- > lib/cryptodev/rte_cryptodev.h | 16 ++--- > lib/distributor/distributor_private.h | 4 +- > lib/distributor/rte_distributor.c | 54 +++++++-------- > lib/eal/common/eal_common_launch.c | 10 +-- > lib/eal/common/eal_common_mcfg.c | 2 +- > lib/eal/common/eal_common_proc.c | 14 ++-- > lib/eal/common/eal_common_thread.c | 26 +++---- > lib/eal/common/eal_common_trace.c | 8 +-- > lib/eal/common/eal_common_trace_ctf.c | 4 +- > lib/eal/common/eal_memcfg.h | 2 +- > lib/eal/common/eal_private.h | 4 +- > lib/eal/common/eal_trace.h | 4 +- > lib/eal/common/rte_service.c | 122 ++++++++++++++++-----------= ------ > lib/eal/freebsd/eal.c | 20 +++--- > lib/eal/include/rte_epoll.h | 3 +- > lib/eal/linux/eal.c | 26 +++---- > lib/eal/linux/eal_interrupts.c | 42 ++++++------ > lib/eal/ppc/include/rte_atomic.h | 6 +- > lib/eal/windows/rte_thread.c | 8 ++- > lib/ethdev/ethdev_driver.h | 16 ++--- > lib/ethdev/ethdev_private.c | 6 +- > lib/ethdev/rte_ethdev.c | 24 +++---- > lib/ethdev/rte_ethdev.h | 16 ++--- > lib/ethdev/rte_ethdev_core.h | 2 +- > lib/eventdev/rte_event_timer_adapter.c | 66 +++++++++--------- > lib/eventdev/rte_event_timer_adapter.h | 2 +- > lib/gpudev/gpudev.c | 6 +- > lib/gpudev/gpudev_driver.h | 2 +- > lib/hash/rte_cuckoo_hash.c | 116 +++++++++++++++------------= ---- > lib/hash/rte_cuckoo_hash.h | 6 +- > lib/ipsec/ipsec_sqn.h | 2 +- > lib/ipsec/sa.h | 2 +- > lib/mbuf/rte_mbuf.h | 20 +++--- > lib/mbuf/rte_mbuf_core.h | 5 +- > lib/mempool/rte_mempool.h | 4 +- > lib/pdump/rte_pdump.c | 14 ++-- > lib/pdump/rte_pdump.h | 8 +-- > lib/power/power_acpi_cpufreq.c | 33 ++++----- > lib/power/power_cppc_cpufreq.c | 25 +++---- > lib/power/power_pstate_cpufreq.c | 31 +++++---- > lib/rcu/rte_rcu_qsbr.c | 48 ++++++------- > lib/rcu/rte_rcu_qsbr.h | 68 +++++++++--------- > lib/ring/rte_ring_c11_pvt.h | 47 +++++++------ > lib/ring/rte_ring_core.h | 12 ++-- > lib/ring/rte_ring_generic_pvt.h | 16 +++-- > lib/ring/rte_ring_hts_elem_pvt.h | 22 +++--- > lib/ring/rte_ring_peek_elem_pvt.h | 6 +- > lib/ring/rte_ring_rts_elem_pvt.h | 27 ++++---- > lib/stack/rte_stack.h | 2 +- > lib/stack/rte_stack_lf_c11.h | 24 +++---- > lib/stack/rte_stack_lf_generic.h | 18 ++--- > lib/telemetry/telemetry.c | 18 ++--- > lib/timer/rte_timer.c | 50 +++++++------- > lib/timer/rte_timer.h | 6 +- > lib/vhost/vdpa.c | 3 +- > lib/vhost/vhost.c | 42 ++++++------ > lib/vhost/vhost.h | 39 ++++++----- > lib/vhost/vhost_user.c | 6 +- > lib/vhost/virtio_net.c | 58 +++++++++------- > lib/vhost/virtio_net_ctrl.c | 6 +- > 65 files changed, 684 insertions(+), 653 deletions(-) The conversion looks correct to me and the CI looks happy. There are a few acks (from Konstantin) that are missing in the v3 (but I can fix this myself, no need for a new revision just for this). For the series, Acked-by: David Marchand --=20 David Marchand