From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6DC7A00C2; Fri, 24 Apr 2020 14:43:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 294D41C1E7; Fri, 24 Apr 2020 14:43:44 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 379AA1BF75 for ; Fri, 24 Apr 2020 14:43:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587732222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x4OnvC75HHq6Ty7gbYl7n2dT9IVQZncYNe4tEIEvHbI=; b=SNNPQkyt64fIM5N8+X0SRNFgDefGUyX5g4/Eu3ujHwQhPTV+tRHyK1yQuL6nRtZFPsAq8m uXnYmJv7FZOS7Dk6LOsXZcxrmAHQoQxap0PuPYNOPAlYvV80gfHSJpbA2UkgCZSKycR+PB l8qvXhGKDLvw6BZToterjeDA7NaVQ/g= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-GsnBmnODMWGpjAx_pYHjog-1; Fri, 24 Apr 2020 08:43:40 -0400 X-MC-Unique: GsnBmnODMWGpjAx_pYHjog-1 Received: by mail-vk1-f197.google.com with SMTP id l188so4479094vke.23 for ; Fri, 24 Apr 2020 05:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2rNWuYzE4F7SgiBPigBmOjFrsS8WJN9OjztpgzGGY28=; b=tRp6i/t8POAmGOCMuY3vmP44Bz9fCSACGhBkkayV3xcqRahvjVHNez+GfyYvIdEjrG DXEyE96BW6YMSYDI1yROV9/pPYlsAmu5b0Yg+TpRJPFoFaMhtnX77GhOMEHoz32FIQt1 8Rqwd4h5+N8QIr3G0zx85a34KMdg5UMN4Z6QgeGoi9nmWMY3hxZHwwF74RftGW6NCO0o ZY2UF6cYFx5LyuOqGOL+dMBmQ4D2jmmL/CBa6g554y2jol9G75jmU9mC6Y+jDoJdAL2G E5kGgCyg2KrhJpJHai/cVzeRbn98rz+iEjepKF+bI4wW5G8ln9VnEK7ZKXESjUuFHf57 7GZg== X-Gm-Message-State: AGi0PuYUbIJm52UTTgXD755DUiPfmSjFG/RJMrakzZBrWiyhheqj486x /NFLT6A+kdeTX1tGy8tmE5nO1hqUVaf7jT+nfX8k2fBINdGzcn4OtiV5RzMQ8RfBj+iHLm2FiWZ ASx0/6B7o7zlwk0S0Afo= X-Received: by 2002:a05:6102:382:: with SMTP id m2mr7433669vsq.141.1587732219879; Fri, 24 Apr 2020 05:43:39 -0700 (PDT) X-Google-Smtp-Source: APiQypKvfaoLc3/lEAV0TzV5AL8SFnkzTYHX5mx0xPjz7sXWQvPtYQlmR6sKRIeWk7JQecHztaRh1ymXlnfrCiiFUrI= X-Received: by 2002:a05:6102:382:: with SMTP id m2mr7433653vsq.141.1587732219601; Fri, 24 Apr 2020 05:43:39 -0700 (PDT) MIME-Version: 1.0 References: <20200424105331.3643868-1-thomas@monjalon.net> In-Reply-To: <20200424105331.3643868-1-thomas@monjalon.net> From: David Marchand Date: Fri, 24 Apr 2020 14:43:28 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Jerin Jacob Kollanukkaran , Sunil Kumar Kori X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] devtools: fix tracepoint symbols check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 24, 2020 at 12:53 PM Thomas Monjalon wrot= e: > > The tracepoint symbols __rte_*_trace_* are defined via a macro, > adding prefix "__", so they cannot be found by map checker. > Those symbols defined by RTE_TRACE_POINT and RTE_TRACE_POINT_FP > are checked without the generated prefix. > > The same logic is applied to per-lcore variables, previously skipped. per core or per_lcore_ > > Fixes: 6c232fc44c74 ("trace: add generic tracepoints") > Fixes: 4931010619fe ("trace: add alarm tracepoints") > Fixes: 52f409d614a0 ("trace: add memory tracepoints") > Fixes: 402321cfca9b ("trace: add memzone tracepoints") > Fixes: 0baa1e01c339 ("trace: add thread tracepoints") > Fixes: 05c4105738d8 ("trace: add interrupt tracepoints") > Fixes: 78d44153de8f ("ethdev: add tracepoints") > Fixes: 32e326869ed6 ("eventdev: add tracepoints") > Fixes: 4cf30e3f3c35 ("cryptodev: add tracepoints") > Fixes: 40b75c73d1c6 ("mempool: add tracepoints") > > Signed-off-by: Thomas Monjalon > --- > devtools/check-symbol-maps.sh | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.s= h > index e137d48a49..7fdfaa11c4 100755 > --- a/devtools/check-symbol-maps.sh > +++ b/devtools/check-symbol-maps.sh > @@ -12,10 +12,14 @@ find_orphan_symbols () > for map in $(find lib drivers -name '*.map') ; do > for sym in $(sed -rn 's,^([^}]*_.*);,\1,p' $map) ; do > if echo $sym | grep -q '^per_lcore_' ; then > - continue > + symsrc=3D${sym#per_lcore_} > + elif echo $sym | grep -q '^__rte_.*_trace_' ; then > + symsrc=3D${sym#__} > + else > + symsrc=3D$sym > fi > if ! grep -q -r --exclude=3D$(basename $map) \ > - -w $sym $(dirname $map) ; then > + -w $symsrc $(dirname $map) ; then > echo "$map: $sym" > fi > done > -- > 2.26.0 Sorry I missed this. But on the plus side, we now validate per_lcore_ variables too :-). Acked-by: David Marchand --=20 David Marchand