From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D933A0350; Thu, 25 Jun 2020 09:33:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF2335B3C; Thu, 25 Jun 2020 09:33:34 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 36CE64F9C for ; Thu, 25 Jun 2020 09:33:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593070412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+FNg+GsEZWxkWA7eDQAb4P15gpdN4PAYbrcrwIl0RKM=; b=Yn8Uv9a8DF/u2EpdA9P2uo+yZWn6FUBG9SWYc/7oWiyM5WF/Lx8YH5YxB88Aatz0dcUwsQ y2hd485GroQEz/C2eb3iK+TkbpF2mkyNeZAAdJS0hMpEOn6LsSrvlOJzQkvr06zj9OLqbQ lNg9WF00ursYnkRuB4PQ2BJF7AS3tqU= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-DqoA-xQdOxGUctOT8Tj7JQ-1; Thu, 25 Jun 2020 03:33:27 -0400 X-MC-Unique: DqoA-xQdOxGUctOT8Tj7JQ-1 Received: by mail-ua1-f70.google.com with SMTP id a2so541572uaf.2 for ; Thu, 25 Jun 2020 00:33:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+FNg+GsEZWxkWA7eDQAb4P15gpdN4PAYbrcrwIl0RKM=; b=Ygdb4i9Imncp1kDtgvnQkVkuCRO7BKHCTzhmKpEitUs/HMa7TfXrsZ7Gpi1h6vNIzF cnXwHJkC+/jlHLV0I2jcRqGJN1QeNE1yXHmWZprpd/SyYP0nEELm5JWicjFcmesISOAe W6AFQ9CYC2L1xCsKUJ7tdIoJrcQHjMspkSjl5bVTMuPMMzL+/fit3mhycYlb4g8pNCs0 0TQpJWo98QXW7fht55lf2Uakkk3SSi0ctIJVflBkI9tPntOjmvy2ODcNkqn2q8xyiZKJ 07nBA1LwwfSfl/w4cE4cTNTJIcttMsV7oB7ogFT+QMW0TQ+seP7/X6Ew7orYb6HmuspJ Fvcg== X-Gm-Message-State: AOAM531gyOvr9gCiCycfVBvhGrvb6+KTaoDoSkaknONsJoKKwJ07OTFn Z2Vt1uxsFR8yGXxXjWcN1wRxNcmFq6G4y7g4topvuMdgNNwWhIRFPA50gWDqwV4jSYsiy02y51A +7aDGUlJsLL/WvlIul9w= X-Received: by 2002:ab0:2c3:: with SMTP id 61mr10061314uah.87.1593070406528; Thu, 25 Jun 2020 00:33:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnS2D/uOIeNISArZde50jP5LLWl9FFWR/+SXwwgtcK/QCmZjE7eVVjjKRrsrJmT8oAXlPLzLTCdNZ46xnjsOw= X-Received: by 2002:ab0:2c3:: with SMTP id 61mr10061304uah.87.1593070406316; Thu, 25 Jun 2020 00:33:26 -0700 (PDT) MIME-Version: 1.0 References: <20200305043311.17065-1-vattunuru@marvell.com> <20200617063321.52709-1-haiyue.wang@intel.com> <20200617063321.52709-3-haiyue.wang@intel.com> <20200622203914.GA60728@outlook.office365.com> In-Reply-To: <20200622203914.GA60728@outlook.office365.com> From: David Marchand Date: Thu, 25 Jun 2020 09:33:14 +0200 Message-ID: To: Harman Kalra , Jerin Jacob Kollanukkaran Cc: Haiyue Wang , dev , "Burakov, Anatoly" , Thomas Monjalon , Andrew Rybchenko , Maxime Coquelin X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v16 2/2] eal: support for VFIO-PCI VF token X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 22, 2020 at 10:40 PM Harman Kalra wrote: > > On Wed, Jun 17, 2020 at 02:33:21PM +0800, Haiyue Wang wrote: > > The kernel module vfio-pci introduces the VF token to enable SR-IOV > > support since 5.7. > > > > The VF token can be set by a vfio-pci based PF driver and must be known > > by the vfio-pci based VF driver in order to gain access to the device. > > > > Signed-off-by: Haiyue Wang > > Acked-by: Anatoly Burakov > > Acked-by: Andrew Rybchenko > > --- > > Tested-by: Harman Kalra Thanks for the test Harman. I can see no complaint on using a single token for all devices, which is the only concern I would have with the last revision. If everyone is ok with this choice, I will take this for -rc1. -- David Marchand