From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC18FA04C4; Thu, 14 Nov 2019 14:14:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 75E292BAF; Thu, 14 Nov 2019 14:14:51 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 6738F237 for ; Thu, 14 Nov 2019 14:14:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573737289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oxgbVpHFwkOJ9Rnd+wnkHj7WutnmdGznurHHwfZGx2w=; b=dUBhO5g4PV8zUJsaybq6yxV2bnSDzLHxavXRgvqlU+7WGe3eNYHZZXbyG7AEtAVLG7dI1v 0/klKEBbkoLRpq1sMhFyUH1wUoRIL/h4WTZMzvh4eqKAv3wiCN35UFBbj3jflvl5vTFWXJ +ohmNR3FtZNQ+1rMwQeZJ8QYPA9D6jw= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-Tr3JlVh5N5qD0A_mr1RjOg-1; Thu, 14 Nov 2019 08:14:46 -0500 Received: by mail-vk1-f198.google.com with SMTP id a17so2606733vko.8 for ; Thu, 14 Nov 2019 05:14:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bv4afRr8jV7RjA49i7febbVYO83fDwWrsCAYtLSpPQc=; b=f6QcFOFRBrMYOOWQvl+5TIospo7Lk2AqX4woK5PdGQIFeO3Eh3WMavI6DbIZynkG/Y jRhgbDcxK7HdjadvYs2QKqIbsv7YZlj0cNRhpDl9xgYhnbxS8j6aa7B7AkHn4UbtdDQn HGt2oobOVgHIvbj5SkSGKQk/Ons6YrzWWM+QuZrhbn6feSXDAkoTnLpuJO/d0AmTFPLb djVXzDuRpm7mwckKtBTkuq4LtTa7K2wipHK7YfZoKY2oAWelwomtpu3GDEl26yfVnK6T lNlD876HyeHnxF8cA2ZoImj10d/RT23trhBN1Dwgq4nkUSb2BdBslc7KAiRmFU95jqtR 9YPw== X-Gm-Message-State: APjAAAVSy8KWvCiWml5dZNM2sS3iR/4MmspthfBCdObz23SGqbmGpWZN 7SOymroy20jbdbqAut0XxvS7WJ9nZYhhbOjb5qQr9do5wDoTiwvlzAXQjPLIjzNryWqj1wRiCXM DoN/BL10EFiE4wiHViZE= X-Received: by 2002:a9f:3772:: with SMTP id a47mr5594635uae.53.1573737286223; Thu, 14 Nov 2019 05:14:46 -0800 (PST) X-Google-Smtp-Source: APXvYqy1QR+CIcZS6N1/cDu1Qj6Fr2FEJ4Xtcivj4jBHvLntxtDTYjMVZz8kqvtvKk/JWbM1yAz627Llv6Vyis0RKP4= X-Received: by 2002:a9f:3772:: with SMTP id a47mr5594612uae.53.1573737285779; Thu, 14 Nov 2019 05:14:45 -0800 (PST) MIME-Version: 1.0 References: <1573628749-5572-1-git-send-email-dengxiaofeng@huawei.com> <78A93308629D474AA53B84C5879E84D24B10A29B@DGGEMM533-MBX.china.huawei.com> In-Reply-To: <78A93308629D474AA53B84C5879E84D24B10A29B@DGGEMM533-MBX.china.huawei.com> From: David Marchand Date: Thu, 14 Nov 2019 14:14:34 +0100 Message-ID: To: "Wangyu (Eric)" Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" , Linuxarm , "humin (Q)" , "Liyuan (Larry)" , dengxiaofeng , dpdk stable X-MC-Unique: Tr3JlVh5N5qD0A_mr1RjOg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v4] bus/pci: align next mapping address on page boundary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 13, 2019 at 8:17 AM Wangyu (Eric) wro= te: > > Currently, the next address picked by PCI mapping infrastructure > may be page-unaligned due to BAR length being smaller than page size. > This leads to a situation where the requested map address is invalid, > resulting in mmap() call returning an arbitrary address, > which will later interfere with device BAR mapping in secondary processes= . > > Fix it by always aligning the next requested address on page boundary. > > Signed-off-by: Xiaofeng Deng > Signed-off-by: Wangyu (Eric) > Acked-by: Wei Hu > Acked-by: Min Hu > Acked-by: Anatoly Burakov > Acked-by: Gavin Hu (Arm Technology China) > > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: stable@dpdk.org Cc'd stable. Applied, thanks. -- David Marchand