From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86EC54341B; Fri, 1 Dec 2023 11:26:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 531C3402B9; Fri, 1 Dec 2023 11:26:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 575CC402B6 for ; Fri, 1 Dec 2023 11:26:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701426391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KOGjyl+paAl8W81l4DrlBOL0DQizatzB3tMUavOucPY=; b=ijby9M2nr683XDEEoyPiGH4cOzeh3cTQ0omEsk82sXnXudy3/iOD+4kAEBOMaQtJ6rTns5 MYp0qUQAijRSiotmMVIpH+LYzmyG63l83J6BV0Z5jon/wBa2dpv6NgGCcGh5NeElBFr2xw y4D3/hR5LbiTWE/9n2c0x+8U0ktLxos= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-wyed7NPrNKqzK5qkv4g_LA-1; Fri, 01 Dec 2023 05:26:27 -0500 X-MC-Unique: wyed7NPrNKqzK5qkv4g_LA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c892080ad3so20321901fa.0 for ; Fri, 01 Dec 2023 02:26:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701426386; x=1702031186; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KOGjyl+paAl8W81l4DrlBOL0DQizatzB3tMUavOucPY=; b=FWBkKC34jykv4V5uVxA8cy0mtMjTHCQdddX9JNHEaATY4F/Dq994dEDG/2GdgwyWjP XN3a1T7WRLlsl5+8RtSe8KGBV5j5U3nP2YUT62vMFornxRQezHsrPcQYMvXLvobuLJz5 cX/63ogrYaPMMWPGnk1y7EIlMRONa+q6Wr7TfGrrmwPxm5r1x2e/eVvV8tTNOn5crdRj hsJwldPG06RjXdS/5FIoa8Ot2A77TmPRcM7KUKAJbeUtgcpIUoyQd0vBxFJXLyFVMJLH jLfpoDJiPGf1tbNAyTOiDGtdsevQvsyxS7rB+i4FG2Z+2/Vjjmy60Q2uOkKCeQi5I7xu PdCA== X-Gm-Message-State: AOJu0YwqJv0Y9FRIPYpTDmssnkQ8gZenhS/bD7FeUhEd/px02vKidCPa q2KQkWT5DwQbkIK0bc0xlGBgfJ9aqHrse5/m1ZGTIurBAoHuZ5Gd+JZzku1/NvY5+66tMhdacy4 btAdi0Em9znxpykUipxo= X-Received: by 2002:a2e:6d12:0:b0:2c8:7f5a:bc7f with SMTP id i18-20020a2e6d12000000b002c87f5abc7fmr587549ljc.26.1701426386051; Fri, 01 Dec 2023 02:26:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkzsHxCiy7rQIH/F4SQefMn2CkDlH+7urMSEVIgkANs9998qbjZ9CdDCm1MI5tAzGEcCdD0uYFC6uifEDH+OY= X-Received: by 2002:a2e:6d12:0:b0:2c8:7f5a:bc7f with SMTP id i18-20020a2e6d12000000b002c87f5abc7fmr587541ljc.26.1701426385745; Fri, 01 Dec 2023 02:26:25 -0800 (PST) MIME-Version: 1.0 References: <20231130091332.2315572-1-mtahhan@redhat.com> In-Reply-To: <20231130091332.2315572-1-mtahhan@redhat.com> From: David Marchand Date: Fri, 1 Dec 2023 11:26:13 +0100 Message-ID: Subject: Re: [v1] net/af_xdp: enable a sock path alongside use_cni To: Maryam Tahhan Cc: ferruh.yigit@amd.com, stephen@networkplumber.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Thu, Nov 30, 2023 at 10:13=E2=80=AFAM Maryam Tahhan = wrote: [snip] > diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cn= i.rst > index a1a6d5b99c..a2d90c665d 100644 > --- a/doc/guides/howto/af_xdp_cni.rst > +++ b/doc/guides/howto/af_xdp_cni.rst > @@ -38,9 +38,10 @@ The XSKMAP is a BPF map of AF_XDP sockets (XSK). > The client can then proceed with creating an AF_XDP socket > and inserting that socket into the XSKMAP pointed to by the descriptor. > > -The EAL vdev argument ``use_cni`` is used to indicate that the user wish= es > +The EAL vdev arguments ``use_cni`` and ``sock`` are used to indicate tha= t the user wishes > to run the PMD in unprivileged mode and to receive the XSKMAP file descr= iptor > from the CNI. > + > When this flag is set, > the ``XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD`` libbpf flag > should be used when creating the socket > @@ -49,7 +50,7 @@ Instead the loading is handled by the CNI. > > .. note:: > > - The Unix Domain Socket file path appear in the end user is "/tmp/afxd= p.sock". > + The Unix Domain Socket file path appears to the end user at "/tmp/afx= dp_dp//afxdp.sock". > > > Prerequisites > @@ -224,7 +225,6 @@ Howto run dpdk-testpmd with CNI plugin: > capabilities: > add: > - CAP_NET_RAW > - - CAP_BPF > resources: > requests: > hugepages-2Mi: 2Gi > @@ -245,7 +245,17 @@ Howto run dpdk-testpmd with CNI plugin: > > kubectl exec -i --container -- \ > //dpdk-testpmd -l 0,1 --no-pci \ > - --vdev=3Dnet_af_xdp0,use_cni=3D1,iface=3D \ > + --vdev=3Dnet_af_xdp0,use_cni=3D1,iface=3D,soc= k=3D/tmp/afxdp_dp//afxdp.sock \ > + -- --no-mlockall --in-memory Quick look at the doc update. - is this hunk related to $subject? - --in-memory is not a testpmd level option, but an EAL one. --=20 David Marchand