From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E50643D05; Wed, 20 Mar 2024 17:01:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0760A42D27; Wed, 20 Mar 2024 17:01:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7BCCC40275 for ; Wed, 20 Mar 2024 17:01:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710950470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MnDuXIJdGHuG/s6SMumuYRT+DQsbl/DzvRaVVtkByyI=; b=jWO2dSGCpnFhMbxsigSB5Zw/c9vLuOA0teev9u/EmuIOYGqZJ4C6ckcvNUpsAoRI/YEmb7 u++bbyi6SNYxV4BlLWrdCyPloNozuMiug6i9SYnv2YMRcv1MW0SgoKyM+f/lkTcDjS3g3U vvg93cGBaOBQjLWu0gLETXijARgtrXY= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-ZvDR8Zc9PZCXiv73ABhZZQ-1; Wed, 20 Mar 2024 12:01:08 -0400 X-MC-Unique: ZvDR8Zc9PZCXiv73ABhZZQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-50e91f9d422so5955e87.2 for ; Wed, 20 Mar 2024 09:01:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710950467; x=1711555267; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MnDuXIJdGHuG/s6SMumuYRT+DQsbl/DzvRaVVtkByyI=; b=DGAQXUHPAmvhP3LQrc08Plo9rZdTuRqTQPcuZDKah552vncG64pRJfhgQesTHX4m0+ D7FuZfirfoMuIrnqtZ652164+J+N6uz574pvf5xfLnJ13TPNuoQcgfCEyqXynV8MCIog 4jXruNMyTkv+HMBKi/76xTzQPmvmkHdE9VPXLRIBtxy/udp6xkSP47hoVsHN0pmK2/Fh QadHKqQFzGqf1ELUK8sTuk1AsSGpIewLXdNQUfgEOGQ55g7Ynph2JW9a8GDjCs7RnQuL 2aGq5wTILNYlrZXOmsq7VAByDnkoz1x2AcNbREJcMRZuYKGnnPeiIZisf98IUWaoFN4H hb/A== X-Forwarded-Encrypted: i=1; AJvYcCW3NeDIBpNyAWajbu7QWqxSeSxHs5gEMG2YVmT+J9rcG1UE/d58BSwpucdUVA0hhtVetidToEwth6GrU5E= X-Gm-Message-State: AOJu0YwzNK8gPQTDHjJCMGkZSyKoedoR1UKyLp6z36/UG87p9jogCBJJ rAmf9URhoh/Pd+CqDJKt9L/ld2Vc7VovWQnca7TWZXOLfIGv98ZFK6wl/Ia8kY7RqmquVcComz1 K8oNDxNCzX/QyjXvYnLT7hwJiWIhZYrMuqVd9Q/YeImJTdi9PRma5QZTKno7ikViSPhRKRTwIRf G4vMYm7snKFHH5Jvc= X-Received: by 2002:ac2:5f9a:0:b0:513:5fb0:c5ad with SMTP id r26-20020ac25f9a000000b005135fb0c5admr12571482lfe.17.1710950467057; Wed, 20 Mar 2024 09:01:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAcfEdVW1BpzQsVNjn36RGSQ0K7Zy1RaYvNjBNuh4HmnhYdmIY1GO/8MyIoGKCyJObJyt5hahblRsCg+vaMxo= X-Received: by 2002:ac2:5f9a:0:b0:513:5fb0:c5ad with SMTP id r26-20020ac25f9a000000b005135fb0c5admr12571464lfe.17.1710950466718; Wed, 20 Mar 2024 09:01:06 -0700 (PDT) MIME-Version: 1.0 References: <1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: From: David Marchand Date: Wed, 20 Mar 2024 17:00:54 +0100 Message-ID: Subject: Re: [PATCH 00/83] move alignment attribute on types To: Bruce Richardson Cc: Tyler Retzlaff , dev@dpdk.org, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , "Min Hu (Connor)" , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Abdullah Sevincer , Ajit Khaparde , Akhil Goyal , Alok Prasad , Amit Bernstein , Anatoly Burakov , Andrew Boyer , Andrew Rybchenko , Ankur Dwivedi , Anoob Joseph , Ashish Gupta , Ashwin Sekhar T K , Byron Marohn , Chaoyong He , Chas Williams , Chenbo Xia , Chengwen Feng , Conor Walsh , Cristian Dumitrescu , Dariusz Sosnowski , David Hunt , Devendra Singh Rawat , Ed Czeck , Evgeny Schemeilin , Fan Zhang , Gagandeep Singh , Guoyang Zhou , Harman Kalra , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Hyong Youb Kim , Jakub Grajciar , Jerin Jacob , Jian Wang , Jiawen Wu , Jie Hai , Jingjing Wu , John Daley , John Miller , Joyce Kong , Junfeng Guo , Kai Ji , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Lee Daly , Liang Ma , Liron Himi , Long Li , Maciej Czekaj , Matan Azrad , Matt Peters , Maxime Coquelin , Michael Shamis , Nagadheeraj Rottela , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pablo de Lara , Pavan Nikhilesh , Peter Mccarthy , Radu Nicolau , Rahul Lakkireddy , Rakesh Kudurumalla , Raveendra Padasalagi , Reshma Pattan , Ron Beider , Ruifeng Wang , Sachin Saxena , Selwin Sebastian , Shai Brandes , Shepard Siegel , Shijith Thotton , Sivaprasad Tummala , Somnath Kotur , Srikanth Yalavarthi , Stephen Hemminger , Steven Webster , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Sunila Sahu , Tejasree Kondoj , Viacheslav Ovsiienko , Vikas Gupta , Volodymyr Fialko , Wajeeh Atrash , Wisam Jaddo , Xiaoyun Wang , Yipeng Wang , Yisen Zhuang , Yuying Zhang , Zhangfei Gao , Zhirun Yan , Ziyang Xuan X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 20, 2024 at 4:56=E2=80=AFPM Bruce Richardson wrote: > > On Wed, Mar 20, 2024 at 08:36:53AM -0700, Tyler Retzlaff wrote: > > The current location used for __rte_aligned(a) for alignment of types > > and variables is not compatible with MSVC. There is only a single > > location accepted by both toolchains. > > > > After having established this as the conventional standard for lib/* > > this series is intended to convert the remainder of the source tree to > > use the same location for __rte_aligned(a) and alignas(a) for > > consistency. > > > No objection to this change. Is there a checkpatch rule available to > enforce this going forward or how can we avoid future introduction of > macros in the wrong place? We added one in v24.03, it is not perfect, but it should help catch most. https://git.dpdk.org/dpdk/commit/devtools?id=3Dc6552d9a8deffa448de2d5e2e726= f50508c1efd2 --=20 David Marchand