From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E256FA3168 for ; Wed, 16 Oct 2019 17:10:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8888E1E96D; Wed, 16 Oct 2019 17:10:31 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 223001E969 for ; Wed, 16 Oct 2019 17:10:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571238629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5G5t0ctze+zoDU4dGKyy7ttsf/Iq+Qb7nj+GA+Zs30U=; b=FLIQINA0PFJ1viVwG50yR4UdPsoF/0D7Rqk18QlG8mhl/a7HrFcUwVrXSn1BIO46FSUEGP 1KoFslBhbanOukMRTkWAFi69Wht3/hewPm7MJqqBBcoFD3CTHAx91CCQAjR9qVTEO+t1oj Q3j4EVqmisdCe7YMUMBL9ij7gUJ1cbM= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-in6T_t03MTe87rbcPrBs_w-1; Wed, 16 Oct 2019 11:10:28 -0400 Received: by mail-ua1-f71.google.com with SMTP id k13so5402284uap.9 for ; Wed, 16 Oct 2019 08:10:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i1p+4pYKTuive4OrmJK17IVnHhsK625NmrI6g4DeUaE=; b=Zoq3TouklTK+iCuq95Hz7pl6s7qDP0prSqkmZa11ocqta3ZkdhNphCalgPMRxbGrJV d+Rrn7/4/PIdzOPnTWPdGFAR5kDQctc25ZTrnCYy6D/vk43nqAUtpPP9L6pfLGDE1IEv DgaMi1a6yIru0Ug5vnwwP3V7Kr+qCpEmU1/eo2TZTM80wfCP0Rdcms2AocmoD6spLyLa rgt6KiDft8m00DmPtC+jFefmQfEbgrqUtdBgXrU63MmPdUpB/BzRmci0/Jh0bVyOsCAQ k29xx39Wd/p0SZy4RGxF+KHIuks96bLeVvd9Hz31gYQCraCJc5TeHHqyE5aW1sTvYKI6 5Xfw== X-Gm-Message-State: APjAAAVIKaG500IUvwk4/7PJ1QChPUykHwsMEW/oZ/D/GVG8jt8clVOK hlOTG8X/7klp3yidSG6EwYnWL35TtdUyGaQ4CHUDNT/0bDaHRTdRAX6bptNb2PiBZiDgdWD6Uhn c6xF9XeW6IeBsUP6tAlc= X-Received: by 2002:ab0:7107:: with SMTP id x7mr18329259uan.87.1571238627645; Wed, 16 Oct 2019 08:10:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7Is/d2pU3FroxCmuuHkqT7bn/4J0X985FE0ugOK9ExmYIKlA6l59Ym+s6v4hpHWfgD/at53tR3BOCcHQZB44= X-Received: by 2002:ab0:7107:: with SMTP id x7mr18329234uan.87.1571238627152; Wed, 16 Oct 2019 08:10:27 -0700 (PDT) MIME-Version: 1.0 References: <20191014230745.70489-1-drc@linux.vnet.ibm.com> <20191015211614.123379-1-drc@linux.vnet.ibm.com> In-Reply-To: <20191015211614.123379-1-drc@linux.vnet.ibm.com> From: David Marchand Date: Wed, 16 Oct 2019 17:10:16 +0200 Message-ID: To: David Christensen Cc: dev , Stephen Hemminger , dpdk stable X-MC-Unique: in6T_t03MTe87rbcPrBs_w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal/ppc: fix 64 bit atomic exchange operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 15, 2019 at 11:16 PM David Christensen wrote: > > The rte_atomic64_exchange operation for ppc_64 incorrectly linked > back to a 32 bit generic operation (__atomic_exchange_4) rather than > the 64 bit generic operation (__atomic_exchange_8). As a result, > applications that used rte_eth_link_get_nowait() would only receive > the link speed, they would not receive the link state, link duplex, > or link autoneg properties. > > Fixes: ff2863570f ("eal: introduce atomic exchange operation") Fixes sha1 is usually on 12 digits (from the contributing guide). Will fix when applying. > Cc: stable@dpdk.org > > Signed-off-by: David Christensen Reviewed-by: David Marchand Thanks. --=20 David Marchand