From: David Marchand <david.marchand@redhat.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: Nipun Gupta <nipun.gupta@nxp.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] Dependency issue between event/dpaa and crypto/dpaa_sec
Date: Thu, 13 Feb 2020 13:16:12 +0100 [thread overview]
Message-ID: <CAJFAV8zgcZU3j+YufJ-tApY_PpVpD7CQ02RoMDKvu4nVtAmG_A@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0401MB254133D96E70E893316C8FDA891A0@VI1PR0401MB2541.eurprd04.prod.outlook.com>
On Thu, Feb 13, 2020 at 1:07 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> > I could not find a dependency in the makefiles for this.
> > But meson has this dependency.
> >
> > drivers/event/dpaa/meson.build
> > deps += ['pmd_dpaa', 'pmd_dpaa_sec']
> >
> >
> [Hemant] Makefile do have dependency set, but at a different place. I have done a small change. Please check if you can :
I must have missed it then.
Can you describe how this dependency is expressed in the makefiles?
>
> diff --git a/drivers/event/dpaa/Makefile b/drivers/event/dpaa/Makefile
> index 2f53efdf9e..093d3a38cf 100644
> --- a/drivers/event/dpaa/Makefile
> +++ b/drivers/event/dpaa/Makefile
> @@ -21,8 +21,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/bus/dpaa/include/
> CFLAGS += -I$(RTE_SDK)/drivers/mempool/dpaa
> CFLAGS += -I$(RTE_SDK)/drivers/common/dpaax
> CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
> -
> -LDLIBS += -lrte_pmd_dpaa_sec
> CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa_sec
>
> EXPORT_MAP := rte_pmd_dpaa_event_version.map
> @@ -34,6 +32,7 @@ LDLIBS += -lrte_bus_dpaa
> LDLIBS += -lrte_mempool_dpaa
> LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
> +LDLIBS += -lrte_pmd_dpaa_sec
> LDLIBS += -lrte_eventdev -lrte_pmd_dpaa -lrte_bus_vdev
> LDLIBS += -lrte_common_dpaax
I don't see how this would affect the building order between
drivers/event/dpaa and drivers/crypto/dpaa_sec.
--
David Marchand
next prev parent reply other threads:[~2020-02-13 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 8:31 David Marchand
2020-01-30 10:53 ` Hemant Agrawal
2020-01-30 11:01 ` David Marchand
2020-02-13 12:06 ` Hemant Agrawal
2020-02-13 12:16 ` David Marchand [this message]
2020-02-21 14:31 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zgcZU3j+YufJ-tApY_PpVpD7CQ02RoMDKvu4nVtAmG_A@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).