Re: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions

[David Marchand <david.marchand@redhat.com>]

On Thu, Oct 10, 2024 at 1:56 PM Mattias Rönnblom <hofors@lysator.liu.se> wrote:
> OK. Nothing obvious from what I can see in the code. Unrelated: why did
> you remove all empty lines in the "template" macros? Makes them much
> harder to read.

Those macros are hard to read.

There was an extra indent that resulted in splitting many lines.
So I started with removing this extra indent.

Then, the trailing tabs (with some pseudo randomly mixed in spaces)
were replaced with a single space before the \ for line continuation.
This enhances code review for update: with a single systematic space,
there is no need to consider if you must update all the context when
adding a line longer than what was already present.

In the end, I was left with cases like:
        <some code> \
 \
        <some code> \

And I preferred to remove this extra line as it did not enhance the
clarity of those macros.


-- 
David Marchand