From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4553A45B04; Thu, 10 Oct 2024 14:14:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09636402D8; Thu, 10 Oct 2024 14:14:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 49D5A4029C for ; Thu, 10 Oct 2024 14:14:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728562455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PYtuUVv4cWscfF1P3UzKRbareToLm1vm+T6LvxEO2Es=; b=I6bgA/jqB59k3KWTOHOOd8AEwEkm2Jc+YjEkdElK9KlI4YoXfFD5Hh9Zkj5RV43C2dNMIG 0WR3oYrs3/5ZquzrKmpQBTK0gdSgRiKp3jzsyhZxJPsdrj5P0HpMm4Phm5zlbVMhst5RxT pFXrGCXhbeXnDk3/GBGpFWZhcV4UZ24= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-ziquP_d_MCicitgOV8zLbw-1; Thu, 10 Oct 2024 08:14:14 -0400 X-MC-Unique: ziquP_d_MCicitgOV8zLbw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fad1771626so7316441fa.2 for ; Thu, 10 Oct 2024 05:14:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728562453; x=1729167253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PYtuUVv4cWscfF1P3UzKRbareToLm1vm+T6LvxEO2Es=; b=VY1ghS1qJOUzuUf0Wrs7zRo083rm14dMUqzK/5LPPypFc6ZxkBiZAd2M23+8MyPLEc BkCK5j+qff1vBja4Dg5Nx2DzO6duNfOYfci4H9EaEcnGmNc5tSZEa80w+s9BrirOXlQh G8skup33S0h2vr6OTKQeoeWlp08eh5sIiDDWtUc4hGFZZanvLWlbjFvBy4ExDZxLEBtN TJe8/P1zJBSZf5O29NiOBym/enB+nMbY+YF2HE6VIc/3UwcBVlaGRx5PJrohx0URVM/d 2T3yhOZfiyeipuoEVdAd5YBl91pbPvEoiP1FP8+8IQxWc5lIB3posUf42eSnBLFxpbm3 Fa0w== X-Forwarded-Encrypted: i=1; AJvYcCXetXxNtLGf0G9+quyMzMGgPo2h4kD5B95S4tzYyoCRakahzLbuivT+LnrVMR5NTzVkqa0=@dpdk.org X-Gm-Message-State: AOJu0YwZt4HbpNb9DGicWKLw2+wBD808qc6cK5fG9sFsEvCPtU6ByRqB Y2Gr4M++kU4QWuKsTtPGibwvzLF0q2D8r1fAQuqoOJYrXR9oBxCsY6PabOPAF9sjhdN59wg5fHI Vm5ec+m618lEUdPcva2ww/r/yx0y/wvAHshcsEcBRNdNnQEYve+ffGcgnMQvwxYeD7O7NBH8M6c M1lORayPa9bhWd1tg= X-Received: by 2002:a2e:a9a8:0:b0:2f7:53b8:ca57 with SMTP id 38308e7fff4ca-2fb1874c66cmr40535261fa.19.1728562453141; Thu, 10 Oct 2024 05:14:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdc/OGV0sbKF+QnaTz7DbXVYAqyEvGh1/gqQAm6+1O2jS8CKjwFGLxqQhBFtiPncE6CvfIWVdNgoqVRIgMU0k= X-Received: by 2002:a2e:a9a8:0:b0:2f7:53b8:ca57 with SMTP id 38308e7fff4ca-2fb1874c66cmr40535001fa.19.1728562452670; Thu, 10 Oct 2024 05:14:12 -0700 (PDT) MIME-Version: 1.0 References: <20240920062437.738706-2-mattias.ronnblom@ericsson.com> <20240920104754.739033-1-mattias.ronnblom@ericsson.com> <20240920104754.739033-7-mattias.ronnblom@ericsson.com> In-Reply-To: From: David Marchand Date: Thu, 10 Oct 2024 14:14:00 +0200 Message-ID: Subject: Re: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev@dpdk.org, Heng Wang , Stephen Hemminger , Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Jack Bond-Preston , Chengwen Feng , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 10, 2024 at 1:56=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > OK. Nothing obvious from what I can see in the code. Unrelated: why did > you remove all empty lines in the "template" macros? Makes them much > harder to read. Those macros are hard to read. There was an extra indent that resulted in splitting many lines. So I started with removing this extra indent. Then, the trailing tabs (with some pseudo randomly mixed in spaces) were replaced with a single space before the \ for line continuation. This enhances code review for update: with a single systematic space, there is no need to consider if you must update all the context when adding a line longer than what was already present. In the end, I was left with cases like: \ \ \ And I preferred to remove this extra line as it did not enhance the clarity of those macros. --=20 David Marchand