From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A14B0A00E6 for ; Thu, 8 Aug 2019 11:22:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A1895F11; Thu, 8 Aug 2019 11:22:56 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id E05414C9F for ; Thu, 8 Aug 2019 11:22:54 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id k9so62557549vso.5 for ; Thu, 08 Aug 2019 02:22:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cx343L8usM/2yNiNp/C/zjEPdsB+rACzQDj7oc53qj4=; b=iK7z4j1EfD+s1MH+fvbiIyOM+qriCZywmmHAsQ0Phsaft+m1vd1b3FFSDmaMPrFmBh ZiPUyKEIR3vGqS5LG4KGNYCgWbEGB+8M+4P9MdwzRxUftMBiRnBcmMI08G7X8yPlLzt/ XzbifcoNFeBvB5voPWpRAPLy4suux4GN9e0NgfD6haj6gwRjAN4QDWOajF3GN6zQXWGK MYNps0xcLRWNlCwyWWdMDU/+6qopLu/oC8Cf+oVoPUpGYkIf3NiH28WC4QjzRd2u4ZkC SKgig0agvGaeou45YyKhWdwjJG1J6iLvSHRIEv3IuK4IpnFmcYK7r/1QXzvZwfWMVT3C DoLg== X-Gm-Message-State: APjAAAWR/P+1gnnGKKNDIGHEh+lO/jbFb04n0+UtDoAZ4E0DSFOIgziT bHTKeOOX7xZ/pcHW2ACQIwM/idMHxwxSXBg1qC5zTw== X-Google-Smtp-Source: APXvYqzprPb+Xozi2Q8Nj7z/WKnMEO3XXxQ+5PxBPhgGc5SfLEh0Lnj/yHrdgqAn6WVW2FOy1GPpZQlhpcN925KY8ZY= X-Received: by 2002:a67:d81b:: with SMTP id e27mr9176387vsj.198.1565256174283; Thu, 08 Aug 2019 02:22:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Thu, 8 Aug 2019 11:22:42 +0200 Message-ID: To: Gagandeep Singh , Hemant Agrawal Cc: Thomas Monjalon , "dev@dpdk.org" , "Burakov, Anatoly" , Olivier Matz , Andrew Rybchenko , Nipun Gupta , "honnappa.nagarahalli@arm.com" , Steve Capper , "jerinj@marvell.com" , "bruce.richardson@intel.com" , "gavin.hu@arm.com" , "konstantin.ananyev@intel.com" , "drc@linux.vnet.ibm.com" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 8, 2019 at 11:00 AM Gagandeep Singh wrote: > > > >HI Thomas, > > > > > > DPDK currently is supporting maximum 3 hugepage, sizes whereas > > > > > > system can support more than this e.g. > > > > > > 64K, 2M, 32M and 1G. > > > > > > > > > > You can mention ARM platform here, and that this issue starts with > > > > > kernel 5.2 (and I would try to mention this in the title as well). > > > > > This is better than an annotation that will be lost. > > > > > > > > > > > > > > > > Having these four hugepage sizes available to use by DPDK, which is > > > > > > valid in case of '--in-memory' EAL option or using 4 separate mount > > > > > > points for each hugepage size; > > > > > > hugepage_info_init() API reports an error. > > > > > > > > > > Can you describe what is the impact from a user point of view rather > > > > > than mentioning this internal function? > > > > > > > > Yes please, we need to understand how much it is critical. > > > > Should we Cc stable@dpdk.org for backport? > > > > Should it be merged at the last minute in 19.08? > > > > > > VPP usages in-memory option. So, VPP on ARM with kernel 5.2 wont' work > > without this patch. > > > > Do you want to send a v2 with a better explanation? > > > > I would suggest to restrict the change to Arm only with an ifdef, > > in order to limit the risk for this release. > > We can think about a dynamic hugepage scan in the next release. > > > Ok, I will send a v2 with better explanation and will also add an if check to make this change for ARM specific only. I hope this explanation covers the question I had about when the change happened in the kernel :-). Thanks. -- David Marchand