From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B204DA0567; Fri, 13 Mar 2020 11:04:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CDF51C02C; Fri, 13 Mar 2020 11:04:24 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id DCD2C1C00E for ; Fri, 13 Mar 2020 11:04:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584093862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t+DYBzTSVCPeSjSLCYljNyU04GpDoRdDnFdYx3U+N6o=; b=B+jBj+b1MxeukpGudQu+8rKv2qmmYdzyrRxs/WUBTNTPQTMCoCexbQQnYYyimj9q0CXFf0 XcnZdJZQnVAAacv5QGO4GHHX3Ba4Mk8UoR3TPHARYNViyr4+Fsku0ffR6qGXFx1YoPk4sA 3/UjjYBuXb0XHyZ/MICdRy66p03JbQc= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-E8AZduz_M8aAeN7UHVwKpw-1; Fri, 13 Mar 2020 06:04:19 -0400 X-MC-Unique: E8AZduz_M8aAeN7UHVwKpw-1 Received: by mail-vk1-f198.google.com with SMTP id 193so1631352vkx.0 for ; Fri, 13 Mar 2020 03:04:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1HyJ8djhxCWV36W1ESTNiYga22ceC/CufuJD4KoJ0Mo=; b=DN0gaGSXdhBaAPKHxRFUUXrLkh2EXebV8rMZPXl89QMOdrhuAAepT6VqOjQWe2evR4 bkfWiqolG3jpBzCCc4WiX8UxrgxrgDZJzFis3K6Q1v3h7fWqmhveP8oAuZVV9A9f+6bB UVCk4U+B2XZiTWxAAY7zJP89aQkJYICm5mZWqs2Fgn1RDfAFKLB7qan4roSrbrZXixWB 4Qfq7+aq9fZcYGEvnh+xNxZ89ViohqIenWtENcWGmi4seuSHS+fKBkpdM5XOYaYSwGvd sxf9MaP9ZGCg2l0XmhJPYn/V2g7Df8OKlXHb+2uDoxJ7ijxsbC9AIbrbNsBUJZH+bjVC OLew== X-Gm-Message-State: ANhLgQ12mgXHGE4eUdTNtn7JJui+gjs5M7j+CVC2DQRCxqzVjYTEJCvA naZHsrOlUhAf3KNeHmaIh6dhFjLfsTYrXCMt420Ca28RwbIVA+La1DanU1QqefLkadWYJykS+iU 0swL/9j6cCYFi6tCJ3HE= X-Received: by 2002:a05:6102:30ba:: with SMTP id y26mr8453129vsd.198.1584093859318; Fri, 13 Mar 2020 03:04:19 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt9GnWiBns282BXQJN6JqDME8xqvqZOMu8Zg6L16Os1oo++ZZYLm9P9yhEs5goh3hAg0V+k3EEZoe+eUzCbr1Y= X-Received: by 2002:a05:6102:30ba:: with SMTP id y26mr8453120vsd.198.1584093858995; Fri, 13 Mar 2020 03:04:18 -0700 (PDT) MIME-Version: 1.0 References: <20200310133304.39951-1-harry.van.haaren@intel.com> <20200311143927.76021-1-harry.van.haaren@intel.com> In-Reply-To: <20200311143927.76021-1-harry.van.haaren@intel.com> From: David Marchand Date: Fri, 13 Mar 2020 11:04:08 +0100 Message-ID: To: Harry van Haaren Cc: dev , Aaron Conole , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren wrote: > > This commit releases all service cores from their role, > returning them to ROLE_RTE on rte_service_finalize(). > > This may fix an issue relating to the service cores causing s/may fix/fixes/ > a race-condition on eal_cleanup(), where the service core > could still be executing while the main thread has already > free-d the service memory, leading to a segfault. > > Fixes: 21698354c832 ("service: introduce service cores concept") Replaced with: Fixes: da23f0aa87d8 ("service: fix memory leak with new function") > Cc: stable@dpdk.org > > Reported-by: David Marchand > Reported-by: Aaron Conole > Signed-off-by: David Marchand > Signed-off-by: Harry van Haaren > Acked-by: Aaron Conole Applied, thanks. --=20 David Marchand