From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A26BA0093; Wed, 20 May 2020 17:16:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DEA841C23E; Wed, 20 May 2020 17:16:30 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 0929C5681 for ; Wed, 20 May 2020 17:16:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589987789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HLl+hgILg6KZ9+fdd2gJ9VOfpTsNDX5lTkmCqIsfTBM=; b=FZdg0SlHix+PULZGrZyLl0tFEyCzRV/5qXVkpXJe23ih3diiKD7+HIUNNe8o+p6ObLstsI LIJXYFTl93FqD6FLYUmaPwV0RsWCVcfSWpJIKhDHTXjkTp8RQja2Iz4eT5Rxrui5sQnn81 PaMRE/DqEr6JMCJLRboDfds0ZvXXVcY= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-lax0w5hmNj6xzcp4sATW5w-1; Wed, 20 May 2020 11:16:28 -0400 X-MC-Unique: lax0w5hmNj6xzcp4sATW5w-1 Received: by mail-vs1-f70.google.com with SMTP id b7so266838vsh.14 for ; Wed, 20 May 2020 08:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HLl+hgILg6KZ9+fdd2gJ9VOfpTsNDX5lTkmCqIsfTBM=; b=JS7oAzen5NLVbJV68BV86TnAKOeG6+Iwotj/yvSVySdpI3KCFar/bzvhqWw0x6KJ56 5+irun/nMa0zBavDtcsPJBkNaaIxIrFgLgXXjBgPHGJKvto2QaAgfW1sJFJR4vChjBrg 3l8IUnXPjTRHRst41XW18QRWcl901d1L/PuWPOHgJsjJGuenuMyeRy6tptHXNV8v5+CH TBpRHJP9D+ch0N3KVwJbRnD557zlwOLadPUJejan2nzkP2mFtCmqV3B+JCeblCQmU0O6 DYGt+KxIomDvJmbczlIPdulcHggrvohZ96My66DGZiL/GhXwNULT2g5vodHpyhhYSY00 l7Lw== X-Gm-Message-State: AOAM533MFwUSScGlbyqpMl5REO33iCkDqn0MG5lNEzz3jcAOIEXAbnP4 xzL5iJL/jEZaODFCCilrQ7+okTZtHvbtg8SzXSvMAP4WgFG/9smxAF5wiUl3ZRf/3/VWUZvHFzC o1fHHoe1RzKlMOG5tRC4= X-Received: by 2002:a67:7d81:: with SMTP id y123mr3798214vsc.105.1589987785720; Wed, 20 May 2020 08:16:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0ZxB++vCMX9cOjzYabSAv5O2zrcjL6PqRDVYtxOppmzZKuLt+W057JGa+j4kFKzNPSvW4ksSlJEdehSy0zC8= X-Received: by 2002:a67:7d81:: with SMTP id y123mr3798170vsc.105.1589987785407; Wed, 20 May 2020 08:16:25 -0700 (PDT) MIME-Version: 1.0 References: <20200520102222.2241689-1-ferruh.yigit@intel.com> In-Reply-To: <20200520102222.2241689-1-ferruh.yigit@intel.com> From: David Marchand Date: Wed, 20 May 2020 17:16:14 +0200 Message-ID: To: Ferruh Yigit Cc: Hemant Agrawal , Sachin Saxena , dev , Thomas Monjalon , Xueming Zhang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: drop inline from non-static functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 20, 2020 at 12:22 PM Ferruh Yigit wrote: > > There is no point in having non-static (and non-extern) inline > functions. > > Also this breaks the build for the ICC [1] because of the 'internal' > symbol check. > > When function is 'inline' ICC is ignoring 'section' attribute and not > putting function to 'internal' section which breaks 'check-symbols.sh' > script with below error. > > [1] > qbman_swp_dqrr_next is not flagged as internal > but is listed in version map > Please add __rte_internal to the definition of qbman_swp_dqrr_next > qbman_swp_enqueue_multiple is not flagged as internal > but is listed in version map > Please add __rte_internal to the definition of qbman_swp_enqueue_multiple > qbman_swp_enqueue_multiple_desc is not flagged as internal > but is listed in version map > Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_desc > qbman_swp_enqueue_multiple_fd is not flagged as internal > but is listed in version map > Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_fd > qbman_swp_pull is not flagged as internal > but is listed in version map > Please add __rte_internal to the definition of qbman_swp_pull > qbman_swp_release is not flagged as internal > but is listed in version map > Please add __rte_internal to the definition of qbman_swp_release > > Signed-off-by: Ferruh Yigit Acked-by: Hemant Agrawal Applied, thanks Ferruh. -- David Marchand