From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75C20A0588; Wed, 1 Apr 2020 17:42:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5AF51BEE0; Wed, 1 Apr 2020 17:42:39 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id A67731BEDF for ; Wed, 1 Apr 2020 17:42:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585755758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=crkCdn1qH6vnucfoE+/u+jdI/pirevqebxTC1rBWDmc=; b=WYAQYI8vvYcmqsfqW0PVt/zCr8UnZ3EZ/mdngHJqzERZOsJsGaYhEqJ9e5OElzrF1NdNVO HE+tNVa/VmvxhMixFEV9kROWeuCACsLvt94GcpmmU4BaCT3bkTIkcEFkSTNbY1m7t5hfAp u7IaySbCY7VT5ZAWxVinziKsIaqC8g0= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-c3RONrHTM8eyaZdtIZz0EA-1; Wed, 01 Apr 2020 11:42:33 -0400 X-MC-Unique: c3RONrHTM8eyaZdtIZz0EA-1 Received: by mail-vs1-f70.google.com with SMTP id m24so60137vsj.14 for ; Wed, 01 Apr 2020 08:42:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=maYj+b9dAuztZ2s1aDdymdj3QyHIgfdJOcoXsvPnvIU=; b=sF/Rlu/JMN2kCqB7BwYPmZRcO9z4wbPW6Qy8M8aphDE2cFLKgWAtkUoPMzRNzJg6yh vcXEPuCA6zugkX54RXshJ5C6jNuSLEsYNFUNG4o54GfAA9WNakYtNo0+mLNLIgnATVrp djO4MXK06cvrHAKV50hR630WUwEZ+z7RELQH8X7rVuRBz9aEj1JB0ROYv2ZB/DgmG7mj womkB4ktpw1wOaIvXDof+0VsLaL15JVgL0nol38KFYD72h93Rsn8YLckxwf7ZVsWUsi5 Tpl3XzlDcgWI9HPc9ZJm5MBAEsAxInFqAeVwgJOlJGBsPISOxPK/u9zHkWFc29INtEAO pVJA== X-Gm-Message-State: AGi0PubkIlWYTd/RAXtzXH/DOwjQexUrGSsJa4llJlhDsEjfOfSwE0aJ I7wmg276861UWr9qVfgRrBICmM7Ytr4gdfpQgqiE8gg9/n3wgNGW7TPqjAFY1ESOhLP4ZJHwrMT cgksz0xBI5BNFh+ADaZw= X-Received: by 2002:a05:6102:38e:: with SMTP id m14mr4869354vsq.141.1585755752875; Wed, 01 Apr 2020 08:42:32 -0700 (PDT) X-Google-Smtp-Source: APiQypJy0M1RQ8OWK7r33D6lSBZeytFdlZWlj0MiwYP1aCGeNtJVkKp1ggK0l6kGUNqSg3XQCGnbPpRovxj2XDZeQAU= X-Received: by 2002:a05:6102:38e:: with SMTP id m14mr4869333vsq.141.1585755752580; Wed, 01 Apr 2020 08:42:32 -0700 (PDT) MIME-Version: 1.0 References: <20200319171907.60891-1-ciara.power@intel.com> In-Reply-To: <20200319171907.60891-1-ciara.power@intel.com> From: David Marchand Date: Wed, 1 Apr 2020 17:42:21 +0200 Message-ID: To: Ciara Power , Kevin Laatz Cc: dev , "Pattan, Reshma" , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 00/12] update and simplify telemetry library. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Thu, Mar 19, 2020 at 6:35 PM Ciara Power wrote: > > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. > > This work is based on the previously sent RFC for a "process info" > library: https://patchwork.dpdk.org/project/dpdk/list/?series=3D7741 > However, rather than creating a new library, this patchset takes > that work and merges it into the existing telemetry library, as > mentioned above. > > The telemetry library as shipped in 19.11 is based upon the metrics > library and outputs all statistics based on that as a source. However, > this limits the telemetry output to only port-level statistics > information, rather than allowing it to be used as a general scheme for > telemetry information across all DPDK libraries. > > With this patchset applied, rather than the telemetry library being > responsible for pulling ethdev stats and pushing them into the metrics > library for retrieval later, each library e.g. ethdev, rawdev, and even > the metrics library itself (for backwards compatiblity) now handle their > own stats. Any library or app can register a callback function with > telemetry, which will be called if requested by the client connected via > the telemetry socket. The callback function in the library/app then > formats its stats, or other data, into a JSON string, and returns it to > telemetry to be sent to the client. > > To maintain backward compatibility, e.g. to allow the dpdk telemetry > collectd plugin to continue to work, some of the existing telemetry > code is kept, but is moved into the metrics library, and callbacks are > registered with telemetry for the legacy commands that were supported > previously. > > The new version of the library, apart from the legacy interface support > for backward compatibility, does not have an external dependency on the > Jansson library, allowing the library to be enabled by default. > > Note: In this version of the patchset, telemetry output is provided by > the ethdev, rawdev and eal libraries, but this may be expanded further > in later versions which are planned ahead of the merge deadline for > 20.05 This patchset does not apply on current master. Could you rebase it? CI reported a build failure for Windows, please have a look. Is there a reason to keep a separate telemetry library rather than integrate this framework into EAL? This series removes the only user of the experimental rte_option API, which can be removed afaiu. Thanks. --=20 David Marchand