From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDEE5A04DB; Fri, 16 Oct 2020 18:48:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB90EBAB8; Fri, 16 Oct 2020 18:46:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id B5CB0BAA4 for ; Fri, 16 Oct 2020 18:46:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602866786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xCn7wBNsSFRunlKpqL0RFbp+71VY1VTV0uzXBewB9pc=; b=M3R3fvXNPrXDxzd/wbuLTxyU7fOXzIUCZSR4oae9MHHD1ujmp9ODhK3DjnDRRLjn/Ok5++ uaoZSOpq+NawozWplqvMm7LiPS1vtemKGP9v+JLQK1M5xlyWPZ8Y2SB8mMLsXG0fr0EID7 H80o+SG7Kk9hQemIS9YkydLJekcSzIE= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-dcn1Ne5NPhemly19MUOtng-1; Fri, 16 Oct 2020 12:46:24 -0400 X-MC-Unique: dcn1Ne5NPhemly19MUOtng-1 Received: by mail-vs1-f72.google.com with SMTP id 7so493205vsu.23 for ; Fri, 16 Oct 2020 09:46:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xCn7wBNsSFRunlKpqL0RFbp+71VY1VTV0uzXBewB9pc=; b=ZC2ELSD9uZ6p8AzWa5ziYgyJKjlhU66RSF5PhrL4UhHAsQQ6RUJNhmncSkb4gnrcHB X4KFEZFhcNMWnMXPVs3LpfAfQ0bVkaWlgaecmBoLBdqZDRfj1Jgm5POwjjBtHU2lWQw5 OOPOWUcAxoFc1X7fynvVoMkFHRdZM3gagAMSqxnToq3vHl87vIj9IxYRy2ONJq8z8fiS B0Jd/40akqvj196r6y9rmRUanLuNYXf4sH4UNYnPwJAxhuXIkyEtovb2hiyIwrTEro0t Eyu3HRJwyfAAOEbSM0sHvmliaExSFrbsk+RupSg3Dn+2eC4gonhbw3QD1yu9KMCNk9pm ypUQ== X-Gm-Message-State: AOAM5327iLdTWy+u4YZPD+04OplTOonliPhuGVCH8CuOZ8YQkkJ7L3BR mBZoH1q0fpmMdTmcYB2RV3KUKQ1K6AF6KEeCOpUEmZmtWyr1g4zuo/TghdK69LS54nfFc+3r+4l ZICZtrAOqLmuEH95Z/pY= X-Received: by 2002:a67:68c9:: with SMTP id d192mr2863674vsc.5.1602866783847; Fri, 16 Oct 2020 09:46:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7XB7jedQ87dua/Hu5w88DXzFIykj8cl52npCc7U4EjoS+unevBbrjlnARn+hesV5ZxCMFe1E+LgsTtV6Vtvw= X-Received: by 2002:a67:68c9:: with SMTP id d192mr2863654vsc.5.1602866783551; Fri, 16 Oct 2020 09:46:23 -0700 (PDT) MIME-Version: 1.0 References: <20200825114447.135030-1-bruce.richardson@intel.com> <20200903144942.671870-1-bruce.richardson@intel.com> <20201016155558.GB1121@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201016155558.GB1121@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Fri, 16 Oct 2020 18:46:12 +0200 Message-ID: To: Bruce Richardson Cc: dev , Ma Lihong , Hemant Agrawal Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 16, 2020 at 5:56 PM Bruce Richardson wrote: > > librte_eal.so is indeed built with the 64 value: > > $ pahole -C rte_mem_config build/install/lib64/librte_eal.so |grep memsegs > > die__process_function: tag not supported (INVALID)! > > struct rte_memseg_list memsegs[64]; /* 136 8704 */ > > > > > > But no trace of the custom value for external applications: > > $ grep -r RTE_MAX_MEMSEG_LISTS build/install > > build/install/include/rte_config.h:#ifndef RTE_MAX_MEMSEG_LISTS > > build/install/include/rte_config.h:#define RTE_MAX_MEMSEG_LISTS 128 > > Binary file build/install/lib64/librte_eal.a matches > > Binary file build/install/lib64/librte_eal.so.21.0 matches > > > > I can see the same using the meson option -Dc_args. > > > > Good point, I had not thought of external apps using these values. > > They are mostly for internal use, so maybe its worthwhile looking to not > have them in a public header file. What do you think? Is it likely that > apps would be using some of these values, or needs to know the specifics? Some are publicly exposed, like RTE_MEMPOOL_CACHE_MAX_SIZE, RTE_PKTMBUF_HEADROOM, RTE_ETHDEV_RXTX_CALLBACKS, For those, either we propagate the overriden value to the installed rte_config.h or we refuse customisation. -- David Marchand