From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
David Hunt <david.hunt@intel.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
remy.horton@intel.com, dpdk stable <stable@dpdk.org>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
John McNamara <john.mcnamara@intel.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
Maryam Tahhan <maryam.tahhan@intel.com>,
John J Browne <john.j.browne@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: remove repeated repeated words
Date: Sat, 6 Nov 2021 10:01:51 +0100 [thread overview]
Message-ID: <CAJFAV8ziJTGo58Rs6SgLTwh0ime8Z=i==-i35qJ8UAS_p0MpbQ@mail.gmail.com> (raw)
In-Reply-To: <20211105211031.2604275-1-thomas@monjalon.net>
On Fri, Nov 5, 2021 at 10:11 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The script devtools/check-dup-words.sh can detect some words
> which are duplicated.
>
Err, that's one of our private checks.
Good to pass it every once in a while.
But checkpatch.pl itself is supposed to do a similar job for new changes.
> Fixes: fdec9301f52d ("doc: add flow classify guides")
> Cc: bernard.iremonger@intel.com
> Fixes: 4dc6d8e63c16 ("doc: add graph library guide")
> Cc: jerinj@marvell.com
> Fixes: 30d3aa861db5 ("doc: rework VM power manager user guide")
> Cc: david.hunt@intel.com
> Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
> Cc: roy.fan.zhang@intel.com
> Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application")
> Cc: remy.horton@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> doc/guides/prog_guide/flow_classify_lib.rst | 2 +-
> doc/guides/prog_guide/graph_lib.rst | 2 +-
> doc/guides/sample_app_ug/ipsec_secgw.rst | 2 +-
> doc/guides/sample_app_ug/keep_alive.rst | 2 +-
> doc/guides/sample_app_ug/vm_power_management.rst | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/prog_guide/flow_classify_lib.rst b/doc/guides/prog_guide/flow_classify_lib.rst
> index f0ed5a1a04..7dae0bc8c6 100644
> --- a/doc/guides/prog_guide/flow_classify_lib.rst
> +++ b/doc/guides/prog_guide/flow_classify_lib.rst
> @@ -366,7 +366,7 @@ Packet Matching
> ~~~~~~~~~~~~~~~
>
> The ``rte_flow_classifier_query`` API is used to find packets which match a
> -given flow Flow rule in the table.
> +given flow rule in the table.
I think the "Flow rule" form was intended.
> This API calls the flow_classify_run internal function which calls the
> ``table.ops.f_lookup`` API to see if any packets in a burst match any
> of the Flow rules in the table.
^^^^
See here.
Otherwise patch lgtm.
--
David Marchand
next prev parent reply other threads:[~2021-11-06 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 21:10 Thomas Monjalon
2021-11-05 21:18 ` Thomas Monjalon
2021-11-06 9:01 ` David Marchand [this message]
2021-11-06 9:53 ` Thomas Monjalon
2021-11-24 16:05 ` David Marchand
2021-11-24 16:21 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8ziJTGo58Rs6SgLTwh0ime8Z=i==-i35qJ8UAS_p0MpbQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bernard.iremonger@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=john.j.browne@intel.com \
--cc=john.mcnamara@intel.com \
--cc=kirankumark@marvell.com \
--cc=maryam.tahhan@intel.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=remy.horton@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).