From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com
 [209.85.217.43]) by dpdk.org (Postfix) with ESMTP id F11F611A4
 for <dev@dpdk.org>; Mon, 11 Mar 2019 17:04:03 +0100 (CET)
Received: by mail-vs1-f43.google.com with SMTP id y19so3040954vsc.4
 for <dev@dpdk.org>; Mon, 11 Mar 2019 09:04:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=by/gst0u2ZDAr6OXlWprKL4W2ac/YqtkQTPGqYmRegw=;
 b=uQJ7Uoxl8eD74jNbTV4MmOMAU0JgkQLRD/wthw55qz1BkBry00uqSOUZlMFfNjsNMF
 F7OZXqAccfRrU+zWjR0Qykdpnx6ZE7wpUoSJOacT6+Lj0WH8vwQtlJQ6BP7I98oYWelf
 kqseFVNt85zuSwsZvk3J2ANT3BfsRePGqjAtzWiWw1l9OoS/vpJ8kz/xQ23ePpOEoOpz
 hYvsXe1T1/7aVTlo/QyjjxxAqBdCFMNBpQ+YPKQ6mttk+FDw9R6eJrfbpBYsBLbdmSCL
 KJCp5hlrZPwtz2dMo/kaeH5F2E0BLM4DR15ugSgpFEZdKZ5FitJLRehV07vjTeHuZJm6
 lTZg==
X-Gm-Message-State: APjAAAXx1zJ51yPwDN6wtUQIbPIdpifLQ0uuPQfk2WqA3m8OxveBBjrJ
 jGaxOpKk5Bcmp0gytFReeuiT0YBRTJiND0AWHa2ebg==
X-Google-Smtp-Source: APXvYqy3Jrevnzl4Q17WfJfaGKeP59/LAHuZ9E0KBfKPkNiwaSM7Jo4lQKsuKwZ3C1FC3Tz2xDSgj/QOAMeiDC8pXeE=
X-Received: by 2002:a67:c986:: with SMTP id y6mr17224097vsk.198.1552320243160; 
 Mon, 11 Mar 2019 09:04:03 -0700 (PDT)
MIME-Version: 1.0
References: <1550158972-21895-1-git-send-email-david.marchand@redhat.com>
 <1552318522-18777-1-git-send-email-david.marchand@redhat.com>
 <1552318522-18777-4-git-send-email-david.marchand@redhat.com>
 <0c3ebd81-fcd6-173b-4cb1-e748829e30d2@solarflare.com>
In-Reply-To: <0c3ebd81-fcd6-173b-4cb1-e748829e30d2@solarflare.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 11 Mar 2019 17:03:52 +0100
Message-ID: <CAJFAV8zibR5zb2_hRoH4Y7Gx46=+pSA-usf7JwThEiCLN-gJng@mail.gmail.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev <dev@dpdk.org>, Wenzhuo Lu <wenzhuo.lu@intel.com>, 
 Jingjing Wu <jingjing.wu@intel.com>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>, Rami Rosen <ramirose@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: remove useless casts on
	statistics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Mar 2019 16:04:04 -0000

On Mon, Mar 11, 2019 at 4:57 PM Andrew Rybchenko <arybchenko@solarflare.com>
wrote:

> On 3/11/19 6:35 PM, David Marchand wrote:
>
> Caught by code review while investigating the stats display code.
> Switching all port and fwd engine statistics to uint64_t makes it
> possible to drop all casts.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com> <david.marchand@redhat.com>
>
>
> Patch summary is misleading here. The main change here is changing
> of counters bitwidth. 32-bit counters overflow pretty fast on 100G, so
> it is a good idea to fix it.
>
>
Oops, I was so focused on the casts and had in mind "unsigned int" was 64
bits wide...
Will reword and this will deserve a Fixes: tag.

Thanks for catching.

-- 
David Marchand