From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CA8BA04F0; Mon, 16 Dec 2019 18:22:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD4FA288C; Mon, 16 Dec 2019 18:22:20 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id EA5C01F5 for ; Mon, 16 Dec 2019 18:22:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576516938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DK9xBQcyK7pOWbKTzF8cOS/7JC9ohMUpvX89FgORZ8M=; b=E956952IdinSWns/KafEHrVkN+h3d97gvG6EgqwAObb2DA2Rj9k2HWBzLZQzVDA+ExBU1o qikFUepZQ7LkmxnrCGGxSNInplVn3MSnEzMVvSLeXEmgWMJQFYh/M1/YP1V417NSwAt4kM i0hm6C3enH+dCQHC9ERJ3iH3mZSHobE= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-s6vls-MtMu2ZcYP4rC0JYQ-1; Mon, 16 Dec 2019 12:22:16 -0500 Received: by mail-ua1-f71.google.com with SMTP id m15so1808269uaq.1 for ; Mon, 16 Dec 2019 09:22:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DK9xBQcyK7pOWbKTzF8cOS/7JC9ohMUpvX89FgORZ8M=; b=psBbvg0MtIh9gJxx5j+vvGw50LiorxE/bTj4yDiWOAV7swz6+ig09jBOxlLWwfEmab VOVHpvt0h9qdbIMLSJDhiHQuU/lCEwg/ALWmEV8pUoB8rRriwqguVTO+aF/+zqg4NcZ3 DhzDpJNKxJMMt/BjhS+JSqXEApBsX+k5tYtnX9ZS4Qs/aogAriMewsmtZsD76VMxBhnx 2z958ivHEHa3Kf7zjoHLdLCZ4gF85V1YpQYQdLNjyMpO1KZcakGHhWU3aepb3IrbWlZX bFDq9WKZTn/Xjmt5Cnkcwcwr14oSh1xF+Mnq62q4AjpTcoJawmF0TWK3ToWY3Q2yFFxS /PMQ== X-Gm-Message-State: APjAAAW4Ga94/owD1LCMutfVQ+1UQuyBdlejxRcZEWFpcGmCthW7pgEM u27VgcYU6xkF9Jed2Y83dCBxPi3jfaVRKvh5L8rhPgwaSf9v79xRRZP60Djazho6Ml+luY5YLNE wkNAquBD6Ewe0b9Tm8Lo= X-Received: by 2002:a1f:fe4e:: with SMTP id l75mr7631vki.18.1576516936371; Mon, 16 Dec 2019 09:22:16 -0800 (PST) X-Google-Smtp-Source: APXvYqyRQMOpEfj8tilOOFfdVEjrYGfSubcUqrAR9MJku3Wz3+Znv/+TaaplRbx8mXYrTs1OrhGkOoKk91vYzaWcqM4= X-Received: by 2002:a1f:fe4e:: with SMTP id l75mr7595vki.18.1576516935969; Mon, 16 Dec 2019 09:22:15 -0800 (PST) MIME-Version: 1.0 References: <20191211182522.8163-1-alialnu@mellanox.com> In-Reply-To: <20191211182522.8163-1-alialnu@mellanox.com> From: David Marchand Date: Mon, 16 Dec 2019 18:22:05 +0100 Message-ID: To: Ali Alnubani Cc: "dev@dpdk.org" , "vattunuru@marvell.com" , "stable@dpdk.org" X-MC-Unique: s6vls-MtMu2ZcYP4rC0JYQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 11, 2019 at 7:26 PM Ali Alnubani wrote: > The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO > is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are > therefore undefined, causing the build failure: > > lib/librte_eal/linux/eal/eal.c: In function =E2=80=98rte_eal_init=E2=80= =99: > lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is > not defined, evaluates to 0 [-Werror=3Dundef] The patch itself is ok. But, out of curiosity, why would you disable vfio support? --=20 David Marchand