From: David Marchand <david.marchand@redhat.com>
To: Sean Morrissey <sean.morrissey@intel.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>, dev <dev@dpdk.org>
Subject: Re: [PATCH v3] examples/l3fwd: merge l3fwd-acl into l3fwd
Date: Wed, 6 Apr 2022 13:47:06 +0200 [thread overview]
Message-ID: <CAJFAV8zjpSrtH3tW-7=xgMfLw6oUDCb48meiWCxG9J+9edqQzw@mail.gmail.com> (raw)
In-Reply-To: <20220406102907.2853883-1-sean.morrissey@intel.com>
On Wed, Apr 6, 2022 at 12:29 PM Sean Morrissey <sean.morrissey@intel.com> wrote:
>
> l3fwd-acl contains duplicate functions to l3fwd.
> For this reason we merge l3fwd-acl code into l3fwd
> with '--lookup acl' cmdline option to run ACL.
>
> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> ---
> V3:
> * remove unnecessary declarations
> * move functions to correct files
> V2:
> * add doc changes
> * minor code cleanup
> ---
> doc/guides/rel_notes/release_22_07.rst | 4 +
> doc/guides/sample_app_ug/index.rst | 1 -
> doc/guides/sample_app_ug/l3_forward.rst | 63 +-
> .../sample_app_ug/l3_forward_access_ctrl.rst | 340 ---
> examples/l3fwd-acl/Makefile | 51 -
> examples/l3fwd-acl/main.c | 2272 -----------------
> examples/l3fwd-acl/meson.build | 13 -
> examples/l3fwd/Makefile | 2 +-
> examples/l3fwd/l3fwd.h | 39 +-
> examples/l3fwd/l3fwd_acl.c | 1098 ++++++++
> examples/l3fwd/l3fwd_acl.h | 51 +
> examples/l3fwd/l3fwd_acl_scalar.h | 112 +
> examples/l3fwd/l3fwd_route.h | 16 +
> examples/l3fwd/main.c | 65 +-
> examples/l3fwd/meson.build | 3 +-
> examples/meson.build | 1 -
> 16 files changed, 1433 insertions(+), 2698 deletions(-)
> delete mode 100644 doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
> delete mode 100644 examples/l3fwd-acl/Makefile
> delete mode 100644 examples/l3fwd-acl/main.c
> delete mode 100644 examples/l3fwd-acl/meson.build
> create mode 100644 examples/l3fwd/l3fwd_acl.c
> create mode 100644 examples/l3fwd/l3fwd_acl.h
> create mode 100644 examples/l3fwd/l3fwd_acl_scalar.h
Two small comments.
MAINTAINERS must be updated.
It contains:
F: examples/l3fwd-acl/
F: doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
>
> diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst
> index 42a5f2d990..351619f1ca 100644
> --- a/doc/guides/rel_notes/release_22_07.rst
> +++ b/doc/guides/rel_notes/release_22_07.rst
> @@ -55,6 +55,10 @@ New Features
> Also, make sure to start the actual text at the margin.
> =======================================================
>
> +* **Merged l3fwd-acl into l3fwd.**
> +
> + Merged l3fwd-acl code into l3fwd as l3fwd-acl contains duplicate and
> + common functions to l3fwd.
Double empty line here.
>
> Removed Items
> -------------
--
David Marchand
next prev parent reply other threads:[~2022-04-06 11:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 15:14 [PATCH v1] " Sean Morrissey
2022-03-29 10:28 ` Bruce Richardson
2022-03-29 10:33 ` Ananyev, Konstantin
2022-03-30 14:04 ` [PATCH v2] " Sean Morrissey
2022-04-02 13:53 ` Ananyev, Konstantin
2022-04-06 10:29 ` [PATCH v3] " Sean Morrissey
2022-04-06 11:47 ` David Marchand [this message]
2022-04-06 12:06 ` [PATCH v4] " Sean Morrissey
2022-04-08 17:26 ` Ananyev, Konstantin
2022-04-08 19:01 ` Morrissey, Sean
2022-04-09 11:58 ` Ananyev, Konstantin
2022-04-11 8:41 ` [PATCH v5] " Sean Morrissey
2022-04-11 11:38 ` Ananyev, Konstantin
2022-04-22 9:57 ` [PATCH v6] " Sean Morrissey
2022-06-08 9:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zjpSrtH3tW-7=xgMfLw6oUDCb48meiWCxG9J+9edqQzw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=sean.morrissey@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).