From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BD6BA0508; Wed, 6 Apr 2022 13:47:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40E4D40689; Wed, 6 Apr 2022 13:47:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AEA8C4014F for ; Wed, 6 Apr 2022 13:47:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649245641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7P353EaLg3yCr8IQ4Rv0vusqwsWPfiGRbn0l7qb4cbw=; b=KTcc0zAi4dBfdnvk/u7KtMTlyYZYeTAoGkyeKqP4BOpRstBn+LZ/bgO/IUp/+AkLAz8grq 8pxx1N8+XGNCNsDUoVrfWZLnWTHE6Vx8oRwTzZ6MllR8VQ5rE6R2whAGFQrOBBxn8tGQlq M1iBXv0MXw5VLyxGTXibLYusLYL8t9s= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-372-sEGuZ4vFPHeBSKGAR5UNng-1; Wed, 06 Apr 2022 07:47:19 -0400 X-MC-Unique: sEGuZ4vFPHeBSKGAR5UNng-1 Received: by mail-lf1-f71.google.com with SMTP id d41-20020a0565123d2900b0044a10c21f39so766388lfv.22 for ; Wed, 06 Apr 2022 04:47:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7P353EaLg3yCr8IQ4Rv0vusqwsWPfiGRbn0l7qb4cbw=; b=Wk7kbE/HzRfXj1L1/6rWWnztWFVW3SO8GO8vqy4L5A7BFbU+7LVrjsLorVunwVlXqN o0D3Yz5lYjl99d4ZMyHdOzoySX7/N7wlsPv94zO94RcK/2Iy1HirrHiXTPAVC8QLCria q9fibCF9GnLrFyThCo4LK1ynzruaR1RigOnLIGBtP9jOaKRs3etJ1745Yehz23F3rZya 0OlAJ+1QGCIgXdLML1Xq1mrxSNV1S6ypFnhhM+ZOupXtknJE2qO8Alq7bXPIFL5lB2S/ diMAzTRvKZIUCySXbytnxIn0qA6Z3lU+y97FejR64/OAM1CoNCkiU0ARiBhXnvrNI4Tj UbyQ== X-Gm-Message-State: AOAM530jVIyBeco357vjCXg40FmIeb+qBDhFE8Q8k1lS4Tuj2Yuir653 k2KmP0JbOAZ7AmBUxWIJx9VRG54RqTOzUPI4fVzwQQJH3A60A7o1tpoMAxN2oYSSu4VE34Dxjpx OGxZ71LqdupUtpvAXBrE= X-Received: by 2002:a05:6512:1326:b0:45a:3a4:f25a with SMTP id x38-20020a056512132600b0045a03a4f25amr5577780lfu.575.1649245638117; Wed, 06 Apr 2022 04:47:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfqoNDDrwoXsy69hbk+5qIY+uk6q8lPqMb2CfSCR94aRqz80AX+HDJf0FVT3dubWobEKyxALv3EnKjIzx//LE= X-Received: by 2002:a05:6512:1326:b0:45a:3a4:f25a with SMTP id x38-20020a056512132600b0045a03a4f25amr5577759lfu.575.1649245637814; Wed, 06 Apr 2022 04:47:17 -0700 (PDT) MIME-Version: 1.0 References: <20220330140407.1616634-1-sean.morrissey@intel.com> <20220406102907.2853883-1-sean.morrissey@intel.com> In-Reply-To: <20220406102907.2853883-1-sean.morrissey@intel.com> From: David Marchand Date: Wed, 6 Apr 2022 13:47:06 +0200 Message-ID: Subject: Re: [PATCH v3] examples/l3fwd: merge l3fwd-acl into l3fwd To: Sean Morrissey Cc: Konstantin Ananyev , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 6, 2022 at 12:29 PM Sean Morrissey wrote: > > l3fwd-acl contains duplicate functions to l3fwd. > For this reason we merge l3fwd-acl code into l3fwd > with '--lookup acl' cmdline option to run ACL. > > Signed-off-by: Sean Morrissey > --- > V3: > * remove unnecessary declarations > * move functions to correct files > V2: > * add doc changes > * minor code cleanup > --- > doc/guides/rel_notes/release_22_07.rst | 4 + > doc/guides/sample_app_ug/index.rst | 1 - > doc/guides/sample_app_ug/l3_forward.rst | 63 +- > .../sample_app_ug/l3_forward_access_ctrl.rst | 340 --- > examples/l3fwd-acl/Makefile | 51 - > examples/l3fwd-acl/main.c | 2272 ----------------- > examples/l3fwd-acl/meson.build | 13 - > examples/l3fwd/Makefile | 2 +- > examples/l3fwd/l3fwd.h | 39 +- > examples/l3fwd/l3fwd_acl.c | 1098 ++++++++ > examples/l3fwd/l3fwd_acl.h | 51 + > examples/l3fwd/l3fwd_acl_scalar.h | 112 + > examples/l3fwd/l3fwd_route.h | 16 + > examples/l3fwd/main.c | 65 +- > examples/l3fwd/meson.build | 3 +- > examples/meson.build | 1 - > 16 files changed, 1433 insertions(+), 2698 deletions(-) > delete mode 100644 doc/guides/sample_app_ug/l3_forward_access_ctrl.rst > delete mode 100644 examples/l3fwd-acl/Makefile > delete mode 100644 examples/l3fwd-acl/main.c > delete mode 100644 examples/l3fwd-acl/meson.build > create mode 100644 examples/l3fwd/l3fwd_acl.c > create mode 100644 examples/l3fwd/l3fwd_acl.h > create mode 100644 examples/l3fwd/l3fwd_acl_scalar.h Two small comments. MAINTAINERS must be updated. It contains: F: examples/l3fwd-acl/ F: doc/guides/sample_app_ug/l3_forward_access_ctrl.rst > > diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst > index 42a5f2d990..351619f1ca 100644 > --- a/doc/guides/rel_notes/release_22_07.rst > +++ b/doc/guides/rel_notes/release_22_07.rst > @@ -55,6 +55,10 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > +* **Merged l3fwd-acl into l3fwd.** > + > + Merged l3fwd-acl code into l3fwd as l3fwd-acl contains duplicate and > + common functions to l3fwd. Double empty line here. > > Removed Items > ------------- -- David Marchand