Re: [PATCH v3 1/3] drivers: replace printf with log macros

[David Marchand <david.marchand@redhat.com>]

On Wed, Jul 3, 2024 at 2:03 PM Hemant Agrawal
<hemant.agrawal@oss.nxp.com> wrote:
> >> diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
> >> index 935a4f2ada..bcd19f31fb 100644
> >> --- a/drivers/net/dpaa/dpaa_ethdev.c
> >> +++ b/drivers/net/dpaa/dpaa_ethdev.c
> >> @@ -282,9 +282,9 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)
> >>                                          dpaa_interrupt_handler,
> >>                                          (void *)dev);
> >>                                  if (ret == EINVAL)
> >> -                                       printf("Failed to enable interrupt: Not Supported\n");
> >> +                                       DPAA_PMD_ERR("Failed to enable interrupt: Not Supported\n");
> >>                                  else
> >> -                                       printf("Failed to enable interrupt\n");
> >> +                                       DPAA_PMD_ERR("Failed to enable interrupt\n");
> > DPAA_PMD_ERR appends a \n, so \n should be removed here.
> >
> > There are double \n in this driver prior to this patch, can you fix them too?
> > It is probably worth checking other NXP drivers on this topic.
> will fix this in v4 and for the time being I am fixing it for dpaa set
> of drivers in 2nd patch of this series. Rest will follow as a separate
> patch.

Ok, thanks.


-- 
David Marchand