From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35215A052F; Wed, 29 Jan 2020 21:03:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB1A51C065; Wed, 29 Jan 2020 21:03:19 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 72FA51C065 for ; Wed, 29 Jan 2020 21:03:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580328197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+IFMYMF51TcTqr/HjQbzXA2qSuJZzZyzBBzqIuZjWek=; b=eWpV/um4PfTDjolgoYa9bU3Bdbi3g3QAQ8K2WieQ+16KM8r4MpjimlMmBXDNk30hTL+ORq BkftvS6oxSNbRFzArFhRWhW2o9rkFCK45+tvc6S8j+MkBAw/EfVYH0bYfI8yjwAqiOK9G6 xnNiNotgkbUZKMftccJItMyzVHAPY3c= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-puQOOtKGMK28FieR3GPf2w-1; Wed, 29 Jan 2020 15:03:13 -0500 Received: by mail-vk1-f200.google.com with SMTP id i123so321754vkg.8 for ; Wed, 29 Jan 2020 12:03:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yuZdNBiUw/waAp6F3SQ5Kj6ZjN+heq+5fSePHIMm3Tw=; b=WzyGaRiG8nyyaQnGnVZzUeRfQv/6G7Zexf5MhFoWOWQ6dEk0Z7f/BzJ3NK0ZkJRABI 2vEPEJr7rivHyhxBAGH+vBFa5a8oE6Vq8LXxYQ6YUIfXTETj4IDtu0rQ4pn6kcMxNPTS 1Nsle7zmiPBadmWTtEcRwGzl73tcAFa1TdwyZd3WCTHl//oCIg+BrpE0ZPVKDTcd+lIH ESKkxea1W1RmVzPnJnnygFYTJx4/Sqeb1JkrRrBiDxouMt83a6oWEaiQRXnWl19cWdSG GeECt6WWv06vGAk5m9AeG+0hnc0+g6t+1yzs3fsUQddH6zSrGeJP/1juW+KSl1BYZWnx 7iYQ== X-Gm-Message-State: APjAAAXBV3yD+eoswC6+gFSMFlgxbc2xSnSOcfEuq3Ajbana+2LOJNC8 xmQsWQrj9iYifFyGJ2jwMl+aKBFZwQRZFLJHIRciWwCFqPQoIyQHv4KIBDx/qSl1bnQLyG3P1Mf 2JFIizUgQ0Thtiw1htA4= X-Received: by 2002:a67:f315:: with SMTP id p21mr911939vsf.39.1580328193174; Wed, 29 Jan 2020 12:03:13 -0800 (PST) X-Google-Smtp-Source: APXvYqw7FMURe6xEBcNsdxQKZ9Jtm5qzT/ClSd1gTH+Sqn5NM0N+IZhNux8McLNLxTD7rNimbIs/rlGwHYXeYaZAjXI= X-Received: by 2002:a67:f315:: with SMTP id p21mr911916vsf.39.1580328192752; Wed, 29 Jan 2020 12:03:12 -0800 (PST) MIME-Version: 1.0 References: <20191220152058.10739-1-david.marchand@redhat.com> <20200129172621.28565-1-david.marchand@redhat.com> <20200129172621.28565-5-david.marchand@redhat.com> <1827847.CQOukoFCf9@xps> In-Reply-To: From: David Marchand Date: Wed, 29 Jan 2020 21:03:00 +0100 Message-ID: To: Anoob Joseph Cc: Thomas Monjalon , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "bruce.richardson@intel.com" , "nhorman@tuxdriver.com" , John McNamara , dodji@seketeli.net X-MC-Unique: puQOOtKGMK28FieR3GPf2w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote: > The asymmetric crypto library is experimental. Changes to experimental co= de paths is allowed, right? The asymmetric crypto enum is referenced by a function part of the stable A= BI. It is possible to waive this enum, if we are sure no use out of the experimental asym crypto APIs is possible. The rest of the changes touch stable symbols. Adding the abidiff report: [C]'function void rte_cryptodev_info_get(uint8_t, rte_cryptodev_info*)' at rte_cryptodev.c:1115:1 has some indirect sub-type changes: parameter 2 of type 'rte_cryptodev_info*' has sub-type changes: in pointed to type 'struct rte_cryptodev_info' at rte_cryptodev.h:468= :1: type size hasn't changed 1 data member change: type of 'const rte_cryptodev_capabilities* rte_cryptodev_info::capabilities' changed: in pointed to type 'const rte_cryptodev_capabilities': in unqualified underlying type 'struct rte_cryptodev_capabilities' at rte_cryptodev.h:176:1: type size hasn't changed 1 data member change: type of '__anonymous_union__ ' changed: type size hasn't changed 1 data member change: type of 'rte_cryptodev_asymmetric_capability __anonymous_union__::asym' changed: type size hasn't changed 1 data member change: type of 'rte_cryptodev_asymmetric_xform_capability rte_cryptodev_asymmetric_capability::xform_capa' changed: type size hasn't changed 1 data member change: type of 'rte_crypto_asym_xform_type rte_cryptodev_asymmetric_xform_capability::xform_type' changed: type size hasn't changed 2 enumerator insertions: 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_ECDSA' value '7' 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_ECPM' value '8' 1 enumerator change: 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END' from value '7' to '9' at rte_crypto_asym.h:60:1 [C]'function int rte_cryptodev_get_aead_algo_enum(rte_crypto_aead_algorithm*, const char*)' at rte_cryptodev.c:239:1 has some indirect sub-type changes: parameter 1 of type 'rte_crypto_aead_algorithm*' has sub-type changes: in pointed to type 'enum rte_crypto_aead_algorithm' at rte_crypto_sym.h:346:1: type size hasn't changed 1 enumerator insertion: 'rte_crypto_aead_algorithm::RTE_CRYPTO_AEAD_CHACHA20_POLY1305' value '3' 1 enumerator change: 'rte_crypto_aead_algorithm::RTE_CRYPTO_AEAD_LIST_END' from value '3' to '4' at rte_crypto_sym.h:346:1 [C]'const char* rte_crypto_aead_algorithm_strings[1]' was changed at rte_crypto_sym.h:358:1: size of symbol (in bytes) changed from 24 to 32 --=20 David Marchand