From: David Marchand <david.marchand@redhat.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage
Date: Wed, 3 Mar 2021 09:17:52 +0100 [thread overview]
Message-ID: <CAJFAV8zkzLuTYdpWsiMFLBXMg-nwPpqX6Dj-SmJE-Y4uUBH_jQ@mail.gmail.com> (raw)
In-Reply-To: <cf6bb1eb3f5e4740b462998df559ce3b2247a3bb.1613757281.git.anatoly.burakov@intel.com>
On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> When file truncation fails, the log message attempts to print a path of
> file we failed to truncate, but this path was never set to anything and,
> what's worse, was uninitialized. Fix it by passing path from the caller.
>
> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
> Cc: stable@dpdk.org
> Coverity ID: 366122
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Andrew had reported it too, and proposed something close:
http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer@pensando.io/
I prefer Anatoly's version.
If no one objects, I'll proceed with this one.
--
David Marchand
next prev parent reply other threads:[~2021-03-03 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 17:54 Anatoly Burakov
2021-03-03 8:17 ` David Marchand [this message]
2021-03-03 8:30 ` Andrew Rybchenko
2021-03-03 8:35 ` David Marchand
2021-03-03 14:43 ` Andrew Boyer
2021-03-04 10:39 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zkzLuTYdpWsiMFLBXMg-nwPpqX6Dj-SmJE-Y4uUBH_jQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).