From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Jim Harris <james.r.harris@intel.com>, dev <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()
Date: Fri, 18 Oct 2019 06:10:56 +0200 [thread overview]
Message-ID: <CAJFAV8zm-rzJk1G7hsBEcBM751GnNB1HT3MuCr3R9ajnRBjBfw@mail.gmail.com> (raw)
In-Reply-To: <20191008081547.2b002519@hermes.lan>
On Tue, Oct 8, 2019 at 5:16 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 8 Oct 2019 09:36:49 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote:
> > > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris <james.r.harris@intel.com>
> > > wrote:
> > >
> > > > This code was added 7+ years ago:
> > > >
> > > > commit fb022b85bae4 ("timer: check TSC reliability")
> > > >
> > > > presumably when variant TSCs were still somewhat common? But this code
> > > > doesn't do anything except print a warning, and the warning doesn't
> > > > give any kind of advice to the user, so let's just remove it.
> > > >
> > > > While the warning has no functional meaning, the /proc/cpuinfo parsing
> > > > consumes a non-trivial amount of time which is especially noticeable in
> > > > secondary processes. On my test system, it consumes 21ms out of the
> > > > 66ms total execution time for rte_eal_init() in a secondary process.
> > > >
> > > > Signed-off-by: Jim Harris <james.r.harris@intel.com>
> > > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2019-10-18 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 10:18 [dpdk-dev] [PATCH v2] " Jim Harris
2019-10-07 15:40 ` [dpdk-dev] [PATCH v2 RESEND] " Jim Harris
2019-10-07 23:18 ` Stephen Hemminger
2019-10-08 8:36 ` Bruce Richardson
2019-10-08 15:15 ` Stephen Hemminger
2019-10-18 4:10 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zm-rzJk1G7hsBEcBM751GnNB1HT3MuCr3R9ajnRBjBfw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).