DPDK patches and discussions
 help / color / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Conor Walsh <conor.walsh@intel.com>
Cc: dev <dev@dpdk.org>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	 Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v2] lib/ipsec: remove experimental tag
Date: Mon, 14 Sep 2020 15:25:50 +0200
Message-ID: <CAJFAV8zn2BOE_RECDd9B_WT9NTv=B82-BAmvzpUxJt5-Z=mbQA@mail.gmail.com> (raw)
In-Reply-To: <20200914125335.272243-1-conor.walsh@intel.com>

Hello Conor,

On Mon, Sep 14, 2020 at 2:54 PM Conor Walsh <conor.walsh@intel.com> wrote:
>
> Since librte_ipsec was first introduced in 19.02 and there were no changes
> in it's public API since 19.11, it should be considered mature enough to
> remove the 'experimental' tag from it.
> The RTE_SATP_LOG2_NUM enum is also being dropped from rte_ipsec_sa.h to
> avoid possible ABI problems in the future.
>
> ---
> v2: RTE_SATP_LOG2_NUM dropped from enum

Small comments that I guess could be fixed while applying.

Commit title prefixes don't start with lib/.


>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
> ---
>  MAINTAINERS                            | 2 +-
>  doc/guides/rel_notes/release_20_11.rst | 1 +
>  lib/librte_ipsec/rte_ipsec.h           | 8 --------
>  lib/librte_ipsec/rte_ipsec_group.h     | 3 ---
>  lib/librte_ipsec/rte_ipsec_sa.h        | 8 +-------
>  lib/librte_ipsec/rte_ipsec_sad.h       | 7 -------
>  lib/librte_ipsec/rte_ipsec_version.map | 2 +-
>  7 files changed, 4 insertions(+), 27 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ed163f5d5..f66772908 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1286,7 +1286,7 @@ M: Jiayu Hu <jiayu.hu@intel.com>
>  F: lib/librte_gso/
>  F: doc/guides/prog_guide/generic_segmentation_offload_lib.rst
>
> -IPsec - EXPERIMENTAL
> +IPsec
>  M: Konstantin Ananyev <konstantin.ananyev@intel.com>
>  T: git://dpdk.org/next/dpdk-next-crypto
>  F: lib/librte_ipsec/
> diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst
> index df227a177..b750fcf65 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -100,6 +100,7 @@ ABI Changes
>     Also, make sure to start the actual text at the margin.
>     =======================================================
>
> +* ipsec: ``RTE_SATP_LOG2_NUM`` has been dropped from ``enum``

There is no ABI compat in this release, and this is an API change.

Documentation blocks are separated with double empty lines (like it
was before your patch).


>
>  Known Issues
>  ------------


-- 
David Marchand


  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 14:48 [dpdk-dev] [PATCH] " Conor Walsh
2020-09-08 11:36 ` Ananyev, Konstantin
2020-09-14 12:53 ` [dpdk-dev] [PATCH v2] " Conor Walsh
2020-09-14 13:25   ` David Marchand [this message]
2020-09-14 13:51     ` Walsh, Conor
2020-09-14 14:10   ` [dpdk-dev] [PATCH v3] ipsec: " Conor Walsh
2020-09-16 11:22     ` Ananyev, Konstantin
2020-10-05  8:59       ` Kinsella, Ray
2020-10-06 20:11         ` Akhil Goyal
2020-10-06 20:29           ` Akhil Goyal

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zn2BOE_RECDd9B_WT9NTv=B82-BAmvzpUxJt5-Z=mbQA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=akhil.goyal@nxp.com \
    --cc=conor.walsh@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox