From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22720A04F8; Fri, 20 Dec 2019 14:19:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 186C5F90; Fri, 20 Dec 2019 14:19:30 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 5B7421F5 for ; Fri, 20 Dec 2019 14:19:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576847967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=30MrjoLMK6xzoSO+aHb42AaGQXrK5rpWVH77OlOjzJw=; b=A+HAd4sy190mVbkisK/bYH/sW+BbqxxsBHGYVRX50w1dMEnvBAUndf1KN/cZdkSL3CoAfg ik3OGW8ytWr85BOdJpr8s6V+RlDQtxhG5hnQt7xl79ExibPDXHagmrcoFcA89eX4OoA+HY gnWmqIIdPvfQ82/3zVGC8NlHuHIZW0U= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-305-GS7SKsmWMTeqrBZmO2cckg-1; Fri, 20 Dec 2019 08:19:25 -0500 Received: by mail-ua1-f71.google.com with SMTP id a20so351178uaq.16 for ; Fri, 20 Dec 2019 05:19:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jhDjHDLJihkbZ7/VweJ5bNZlmqDUnZ8hB5hIUvTEgZo=; b=K51Xb9mmqMGB3Rqrgrued0DIsszgq9qyIs4pvr/gmnfcxy92GUqrZx1gy+S8rrEcOt 9B6vi5+VA6OszijX1oXmmTA6zGgaCzrhouLOzhQXiNza8AV0K7vfKjeNrNjjZmKxVMKq d4lykGz6yWJLlquVd19GqUApI4uw1TftA2NY4xRJB27LBpXEjR98PrY1Aj7ym9QUwtpT 15fVfm4tkxzI5CnNLQyryoZkP2adJjnf/vbppvAjlam9J9FDdnNatSU4tBpJlu8tfBeu q2Jb1yzzR5X/iRKhOAT/0oM0CpD9TmdEJeFnfDF3ICFYfbVyglYdfWlYaNsDyrP11xr3 XoHg== X-Gm-Message-State: APjAAAUR3ENcL6PuZRtsHbI/zzACur5dFwgDxc+Xw+ogaJsdM+3FDZlT zMaUZz5SbyBSx1vc/MfGsJEg1E9PnjnX5ID7+3woFr5yiETTCxIRpDQnq83bCbmbk470ccJzga/ 0wsH7nSAgrPiyM4w3u+s= X-Received: by 2002:a1f:72c3:: with SMTP id n186mr9477866vkc.12.1576847964956; Fri, 20 Dec 2019 05:19:24 -0800 (PST) X-Google-Smtp-Source: APXvYqxhK2pedACP9HSqtGRduxvOFrocAwZWLYLCN6dqboAUWkNvGHquIuh7KFTMTm/+/Ryoz+vN4JlnubYlzbNtMbg= X-Received: by 2002:a1f:72c3:: with SMTP id n186mr9477844vkc.12.1576847964536; Fri, 20 Dec 2019 05:19:24 -0800 (PST) MIME-Version: 1.0 References: <20191213140302.4252-1-kevin.laatz@intel.com> <20191213164110.9744-1-kevin.laatz@intel.com> <20191220110414.GA514@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191220110414.GA514@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Fri, 20 Dec 2019 14:19:13 +0100 Message-ID: To: Bruce Richardson Cc: Kevin Laatz , dev , Thomas Monjalon , "Kinsella, Ray" , Tomasz Duszynski , Zyta Szpak , Rastislav Cernay , Aaron Conole X-MC-Unique: GS7SKsmWMTeqrBZmO2cckg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 00/11] Add ABI compatibility checks to the meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Dec 20, 2019 at 12:04 PM Bruce Richardson wrote: > > For maintainers that integrate patches or developers that get a CI > > failure and want to fix it, we would need to help them to: > > * generate dumps on a reference version, so I would tend to write some > > documentation since playing with the current sources would be too > > dangerous from my pov, > > This should be a one-off reference dump archived somewhere. Each maintain= er > should not have his own copy, I think. This is not a one-off thing. We maintain ABI for some time (1/2 year(s)), and we expect to bump ABI. When doing this, in size, the diff will be at least the same than what we have here. If you disable libraries, features etc... you get a new ABI. What would be the reference*s* then? Builds with default options from meson for each architecture? > > * run the checks, like adding the check in the > > devtools/test-*-build.sh scripts that already exist, with a new > > configuration item to point at the dumps per target, > > > > Where do we store the dumps then? Do they get stored in a separate git > repo? Creating a separate git repo is just adding more pain to submitters (/maintainers): they would have to submit (/apply) patches against two trees. -- David Marchand