From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74330A04DD; Wed, 27 Nov 2019 22:39:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C23CE1BE95; Wed, 27 Nov 2019 22:39:14 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 360BA4C9D for ; Wed, 27 Nov 2019 22:39:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574890752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zfAc+CxjcRJUN6tyvb8KW7hHNuAKPcg1lG6ssChpg7w=; b=blLPp9mJxJZxNewpu2uQu4CNySAaVnniZrQLomawcWVsrmkuGTiQYRxnBAGfuJeeEs2JcA cywqy/7jSJZSZYgKpaABoA0xQ6vpGk7zCA9aBVWkuEeb54lSjMYE/se/kAAtCFI4gkRufU T1PQdUFOYIt1PvlIpeHlVOTD8QBvptk= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-0WvPbT87MWea_7Uw43YYBA-1; Wed, 27 Nov 2019 16:39:09 -0500 Received: by mail-vs1-f70.google.com with SMTP id b3so3304304vsl.12 for ; Wed, 27 Nov 2019 13:39:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9pL8NTrYHsg8FGPHHBcYWDWdNdxiAb2pwFGTxJmOYB8=; b=cYXcqVBglU+W1uIvllm1N9acYa0uspfNX+8nz5iMNYAChAa3cBKYY6uiD5b1SuFYnX v0R8QRM5BUi3pBs8iqVtjhfKJ5UUkGk4Dl1JNyC5TENR/IljrK2PAl0DDv/A9RZjOTlE nQvOhCyg+uW2KbJju0qMhGe+EVjmFGeORAw9+XpDuwHddu/FVT/vNzCGMYNDyhgpSckG QSvemSTzih0idyWfWdmlUauGZDrOW6jIdd4Wqoh3EaQQczNUHcLpfLeIkgKzCfTkjGz2 w/lIP47rO9mb7F17ODchaxIieevknW1A9JPsOqgOmCZS+qgMgp9pA77YEasZ3wittx8Z vtYw== X-Gm-Message-State: APjAAAUOXzsDUjpHd39uZ/39XSAWIw6zGohZyx8w3XqCd/VXxZHcHN9a Yv4Vf6HSf2OJlVmLULQ38Z04UaKVDzHtm4r33wT0DIHgtYNOXJefVciMc8EDqY9XO6xylcygY// wfmsHWCmB3sTY1qgjImU= X-Received: by 2002:a67:ee49:: with SMTP id g9mr27810865vsp.105.1574890748902; Wed, 27 Nov 2019 13:39:08 -0800 (PST) X-Google-Smtp-Source: APXvYqwwY3uemt+e7WbvxNEPhPn/xwsKMSSdArLDYJlsLmHzqXYQmqN+jzbmdpYtGWQ/rH2xB8Leurk4UakTSYbb/rc= X-Received: by 2002:a67:ee49:: with SMTP id g9mr27810844vsp.105.1574890748607; Wed, 27 Nov 2019 13:39:08 -0800 (PST) MIME-Version: 1.0 References: <20191127132027.80239-1-harry.van.haaren@intel.com> In-Reply-To: <20191127132027.80239-1-harry.van.haaren@intel.com> From: David Marchand Date: Wed, 27 Nov 2019 22:38:57 +0100 Message-ID: To: Harry van Haaren Cc: dev , Aaron Conole , dpdk stable X-MC-Unique: 0WvPbT87MWea_7Uw43YYBA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] test/service: fix wait for service core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 27, 2019 at 2:20 PM Harry van Haaren wrote: > > This commit fixes a sporadic failure of the service_autotest > unit test, as seen in the DPDK CI. The failure occurs as the main test > thread did not wait on the service-thread to return, and allowing it > to read a flag before the service was able to write to it. > > The fix changes the wait API call to specific the service-core ID, > and this waits for cores with both ROLE_RTE and ROLE_SERVICE. > > The rte_eal_mp_wait_lcore() call does not (and should not) wait > for service cores, so must not be used to wait on service-cores. > > Fixes: f038a81e1c56 ("service: add unit tests") Cc: stable@dpdk.org > > Reported-by: Aaron Conole > Signed-off-by: Harry van Haaren Acked-by: David Marchand Before this patch, reproduced the pb in less than 2 minutes with: # time (log=3D/tmp/$$.log; while true; do echo service_autotest |taskset -c 0-1 build-gcc-static/app/test/dpdk-test --log-level *:8 -l 0-1 >$log 2>&1; grep -q 'Test OK' $log || break; done; cat $log; rm -f $log) With the patch, this loop has been running for 40 minutes. Applied, thanks. -- David Marchand