From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1081143C92; Tue, 12 Mar 2024 15:12:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EF2B402E0; Tue, 12 Mar 2024 15:12:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AB323402D8 for ; Tue, 12 Mar 2024 15:12:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710252755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gtPC3fShHEcbfx1GNeXl65bnYYjt6hYkk+zqWlicLyA=; b=c79umpX8M8YNUOVakcYxNH8EvU5II+wKXYpIWfA+8KDS6RQSGFWUK/i95dl95VgF4ugUUl rgkyKt50IjqerpvZ29Xxw4d/6QNCzBOkbXK+UsWAxiiEg2oQTHyFJusv/OuOSwX9o7e33D jR8QUzA9NmPy7bcxJNxi7u54LnUU9fg= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-JoYyjs2aOuy8Wbawu2Wv9w-1; Tue, 12 Mar 2024 10:12:33 -0400 X-MC-Unique: JoYyjs2aOuy8Wbawu2Wv9w-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d459c42e03so6364871fa.2 for ; Tue, 12 Mar 2024 07:12:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710252752; x=1710857552; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gtPC3fShHEcbfx1GNeXl65bnYYjt6hYkk+zqWlicLyA=; b=rHqbNGFLnYrs/WSguy2U2AqONkqUyGgdtgHzD2IgYQGpRsZBa2BuFLzfzwyC16mBCH JPlnQfJGZmrKQJeVW5QLTUG/g7HVwG944sAVfn0W2+vXQ1/wejRK/TNHil+JdnR6QfDe I26druooptCD+47smXlLvX0l9GcRfBWgTTScZUzhumz6tlW64MdH0hgQUWLLwu20dtkW cnBPGbsCEIzin5A7cTVwmm/7bU7KBhP+ghz2khf2hPyPFeInvFyE9T449Z/+PgUXFzbL T69mo/apRl6oa30f6PB1xnJLLj/9FGudCk/7wcwzBSy+mZ6Dg97Wxgt+RKh9vhXwuzfI Hvnw== X-Gm-Message-State: AOJu0Yy0dyRfB6q/b/NbcUOvZajcFN/5XIt7gxPX0QOyYF+GDikhj5VI rQ8z4AY5nD/FfUN5IfjL4O7Txqk6hNy/n/JdqElfY9yZ/hWipFs/mvxvs2ucJr3aJqFkFWEVnCr d8VFa9l/obafc9SA84bT97SVQVpMLRdqPatIksFPTh3tdVNG6hcKpZ0YDHnWP5ftdeRqAEoGtzC UYncPhB8FxiYxabUw= X-Received: by 2002:a2e:740a:0:b0:2d4:5f4f:8ff0 with SMTP id p10-20020a2e740a000000b002d45f4f8ff0mr832984ljc.1.1710252752406; Tue, 12 Mar 2024 07:12:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFk4dmO8AwryrJUvopLK+LShToQLqVnG1cY8km74tpAuIKmKP4u4RVcarOoSWfH6MtdwawckEEzkpv4tDInBVE= X-Received: by 2002:a2e:740a:0:b0:2d4:5f4f:8ff0 with SMTP id p10-20020a2e740a000000b002d45f4f8ff0mr832967ljc.1.1710252752128; Tue, 12 Mar 2024 07:12:32 -0700 (PDT) MIME-Version: 1.0 References: <20240312104849.667036-1-maxime.coquelin@redhat.com> <20240312104849.667036-3-maxime.coquelin@redhat.com> In-Reply-To: <20240312104849.667036-3-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 12 Mar 2024 15:12:20 +0100 Message-ID: Subject: Re: [PATCH 2/2] net/virtio: fix notification area initialization To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com, schalla@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 12, 2024 at 11:48=E2=80=AFAM Maxime Coquelin wrote: > > Notification area is a Virtio feature that require to be requires* > negotiated because not all devices support it. Currently, > it is tried to be initialized as soon as the backend > implements the callback, so it assumes all Vhost-vDPA > devices support it. > > This patch skips calling the notification area map callback > if the device does not advertise its support. > > Fixes: 0fd2782660c8 ("net/virtio-user: support notification area mapping"= ) > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --=20 David Marchand