From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id BFF6F4C8D for ; Thu, 9 May 2019 09:06:07 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id d4so407264uaj.7 for ; Thu, 09 May 2019 00:06:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZZ9m/3TfxVpiT6pREbfyzOLnT2D5XSZihyjWgV9AGRU=; b=fd8ssKe3ZwBxOP8YubWuDArgNKqg8ju6d9NsmAbtSUAwZGcpJ/OCoxu3uC3XvyaUM3 P5vsSpP9ubTqprX5FJreSZ+sJs3aCQrRQhu4m5OZRWyvzvqPZZPGno7C0Oj0yUJOfrq2 wokHAfDI+mhR7HIZ0CLYA9hDkQ4gdJMXTk+0JoIA1wcgkeJsyW8rnZk4+gfN4kh8bSYM hqkA5ROnvKpdRWb6u/mgRXRPgIATaJtOxOqQe4SumohKIVJKeCwFx0iOW3ONVr24Uki0 D5DW0/4iydwQd9wy+HjMacSMVpLZgDVDCC0yZV2/Cx0Iz8cLZ5hcRdD+4DeCclzZ4Kov UXEQ== X-Gm-Message-State: APjAAAWu7skd04s74sqww0Z5i97KHkmR3Szw7mndNmOZo3NFQ9qmzKst 7DB5VtQgZH1z/sEBt9aKBl8ZASbA1jVtWh54IQYpmw== X-Google-Smtp-Source: APXvYqx7NiN8v32+sVNELGbRhsHU3gK3ibY0imE2axg6Z80VSbjJ/e0ZU9TVRqUPsQ0RsE13bITJzNuhRfGfBY23w+U= X-Received: by 2002:ab0:7087:: with SMTP id m7mr1000737ual.87.1557385567044; Thu, 09 May 2019 00:06:07 -0700 (PDT) MIME-Version: 1.0 References: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com> <20190508181137.04112fd4@xps13> In-Reply-To: <20190508181137.04112fd4@xps13> From: David Marchand Date: Thu, 9 May 2019 09:05:56 +0200 Message-ID: To: Stephen Hemminger Cc: Erik Gabriel Carrillo , Thomas Monjalon , "Burakov, Anatoly" , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 07:06:08 -0000 On Thu, May 9, 2019 at 3:11 AM Stephen Hemminger wrote: > On Wed, 8 May 2019 17:48:06 -0500 > Erik Gabriel Carrillo wrote: > > > Due to an upcoming fix to allow the timer library to safely free its > > allocations during the finalize() call[1], an ABI change will be > > required. A new lock will be added to the rte_mem_config structure, > > which will be used by the timer library to synchronize init/finalize > > calls among multiple processes. > > > > [1] http://patches.dpdk.org/patch/53334/ > > > > Signed-off-by: Erik Gabriel Carrillo > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > > index b47c8c2..7551383 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -31,6 +31,10 @@ Deprecation Notices > > > > + ``rte_eal_devargs_type_count`` > > > > +* eal: the ``rte_mem_config`` struct will change to include a new lock > that > > + will allow the timer subsystem to safely release its allocations at > cleanup > > + time. This will result in an ABI break. > > + > > * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs > which > > have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap`` > > functions. The due date for the removal targets DPDK 20.02. > > NAK > > Please go to the effort of making rte_mem_config not part of the visible > ABI. > Then change it. > +1. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4684CA0096 for ; Thu, 9 May 2019 09:06:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C72E4C90; Thu, 9 May 2019 09:06:09 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id BFF6F4C8D for ; Thu, 9 May 2019 09:06:07 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id d4so407264uaj.7 for ; Thu, 09 May 2019 00:06:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZZ9m/3TfxVpiT6pREbfyzOLnT2D5XSZihyjWgV9AGRU=; b=fd8ssKe3ZwBxOP8YubWuDArgNKqg8ju6d9NsmAbtSUAwZGcpJ/OCoxu3uC3XvyaUM3 P5vsSpP9ubTqprX5FJreSZ+sJs3aCQrRQhu4m5OZRWyvzvqPZZPGno7C0Oj0yUJOfrq2 wokHAfDI+mhR7HIZ0CLYA9hDkQ4gdJMXTk+0JoIA1wcgkeJsyW8rnZk4+gfN4kh8bSYM hqkA5ROnvKpdRWb6u/mgRXRPgIATaJtOxOqQe4SumohKIVJKeCwFx0iOW3ONVr24Uki0 D5DW0/4iydwQd9wy+HjMacSMVpLZgDVDCC0yZV2/Cx0Iz8cLZ5hcRdD+4DeCclzZ4Kov UXEQ== X-Gm-Message-State: APjAAAWu7skd04s74sqww0Z5i97KHkmR3Szw7mndNmOZo3NFQ9qmzKst 7DB5VtQgZH1z/sEBt9aKBl8ZASbA1jVtWh54IQYpmw== X-Google-Smtp-Source: APXvYqx7NiN8v32+sVNELGbRhsHU3gK3ibY0imE2axg6Z80VSbjJ/e0ZU9TVRqUPsQ0RsE13bITJzNuhRfGfBY23w+U= X-Received: by 2002:ab0:7087:: with SMTP id m7mr1000737ual.87.1557385567044; Thu, 09 May 2019 00:06:07 -0700 (PDT) MIME-Version: 1.0 References: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com> <20190508181137.04112fd4@xps13> In-Reply-To: <20190508181137.04112fd4@xps13> From: David Marchand Date: Thu, 9 May 2019 09:05:56 +0200 Message-ID: To: Stephen Hemminger Cc: Erik Gabriel Carrillo , Thomas Monjalon , "Burakov, Anatoly" , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509070556.-1s3_17k1wVWF7yedg4xK_cZiHp6ud54Dcv8Iznpiuw@z> On Thu, May 9, 2019 at 3:11 AM Stephen Hemminger wrote: > On Wed, 8 May 2019 17:48:06 -0500 > Erik Gabriel Carrillo wrote: > > > Due to an upcoming fix to allow the timer library to safely free its > > allocations during the finalize() call[1], an ABI change will be > > required. A new lock will be added to the rte_mem_config structure, > > which will be used by the timer library to synchronize init/finalize > > calls among multiple processes. > > > > [1] http://patches.dpdk.org/patch/53334/ > > > > Signed-off-by: Erik Gabriel Carrillo > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > > index b47c8c2..7551383 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -31,6 +31,10 @@ Deprecation Notices > > > > + ``rte_eal_devargs_type_count`` > > > > +* eal: the ``rte_mem_config`` struct will change to include a new lock > that > > + will allow the timer subsystem to safely release its allocations at > cleanup > > + time. This will result in an ABI break. > > + > > * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs > which > > have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap`` > > functions. The due date for the removal targets DPDK 20.02. > > NAK > > Please go to the effort of making rte_mem_config not part of the visible > ABI. > Then change it. > +1. -- David Marchand