From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2233BA0032; Sat, 2 Oct 2021 10:46:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A37EE40042; Sat, 2 Oct 2021 10:46:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 0D14E40040 for ; Sat, 2 Oct 2021 10:46:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633164410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y6QI2ZMNwQrT7cZocVaQIuPfFV1ujUOXoBxZfU7IlY4=; b=ITjHPOrC7Kbr/oUX1wHb5Y54rmZ4RwLOPtRBBCv7n9zeJcc99MvPA5aorNik8kCdGfA3PJ a9YFJNcH+pRbgyhcenAO3qe7DgbsqSfvpXSfzsp13njhnnqOGZsQ2EvxFh8dMIPm7HJAGz LySA+34ObNB+nasEVT5bEduch+tuuYs= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-373--6YgZOsXOBCEvr-6wnPB5A-1; Sat, 02 Oct 2021 04:46:49 -0400 X-MC-Unique: -6YgZOsXOBCEvr-6wnPB5A-1 Received: by mail-lf1-f70.google.com with SMTP id x33-20020a0565123fa100b003fcfd99073dso10688966lfa.6 for ; Sat, 02 Oct 2021 01:46:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y6QI2ZMNwQrT7cZocVaQIuPfFV1ujUOXoBxZfU7IlY4=; b=SU6KEZxfKfesOywohPNuBcZfssoL0bg43hUVCV4z7xK9dlxlAczS+1+MFQVCRrXSPs quasxSFnacirGRK3rkybfX94PQMq73tnUmZdHhmBiyo0nOEk0DOcgV1uS+4bDFdl2LRa kAlJvBHke+PMNP5iXo/4Psc+wqWF6Opugim3qQIWkOAsh1xsNyJOs+/gd1MyyenHsW72 DcMNsVjbYR2nzY4ufcG68shLxNJ5/PAIpY3S6FQJK6+slp3rJo/leLlxxxZWvgqhOshq IFXETC0sCwXSDUbQuPEK2XDprF76kOaeLu1RMyPy93lLsKMa6gIIxrv5t+Uu4YGjhfCM qhdA== X-Gm-Message-State: AOAM530ik1Af9P1j4hmvYgfrNs4Az4JJkrZjC2Krk3UfcT6edEXZpRMi JK+UJ14xr3vDsm/w2vVutoVhue6qOi40Ph3sbAdK89NdkpE43JVVjli3JBcxLV++TkGrziThfbt ZeCIFrPfl9o98RA7H8/U= X-Received: by 2002:a2e:8584:: with SMTP id b4mr2789436lji.477.1633164407718; Sat, 02 Oct 2021 01:46:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw93Mkt9PkQO6Mj13EXaYJIDYFKg1GJuZwIkRFqUQOvZFiqj6YfQqay43oN/5c6G6QL2cxn//h4sPygUDVpNpA= X-Received: by 2002:a2e:8584:: with SMTP id b4mr2789424lji.477.1633164407540; Sat, 02 Oct 2021 01:46:47 -0700 (PDT) MIME-Version: 1.0 References: <20210930160551.2286705-1-sean.morrissey@intel.com> In-Reply-To: <20210930160551.2286705-1-sean.morrissey@intel.com> From: David Marchand Date: Sat, 2 Oct 2021 10:46:36 +0200 Message-ID: To: Sean Morrissey Cc: dev , Honnappa Nagarahalli , "Ananyev, Konstantin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Thu, Sep 30, 2021 at 7:42 PM Sean Morrissey wrote: > > These methods were introduced in 20.05. > There has been no changes in their public API since then. > They seem mature enough to remove the experimental tag. I am a bit skeptical at the patch. Can you double check? /** prod/cons sync types */ enum rte_ring_sync_type { RTE_RING_SYNC_MT, /**< multi-thread safe (default mode) */ RTE_RING_SYNC_ST, /**< single thread only */ #ifdef ALLOW_EXPERIMENTAL_API RTE_RING_SYNC_MT_RTS, /**< multi-thread relaxed tail sync */ RTE_RING_SYNC_MT_HTS, /**< multi-thread head/tail sync */ #endif }; There is also in rte_ring_elem.h: #ifdef ALLOW_EXPERIMENTAL_API #include #include #endif And later static __rte_always_inline unsigned int rte_ring_enqueue_bulk_elem(struct rte_ring *r, const void *obj_table, unsigned int esize, unsigned int n, unsigned int *free_space) { ... #ifdef ALLOW_EXPERIMENTAL_API case RTE_RING_SYNC_MT_RTS: return rte_ring_mp_rts_enqueue_bulk_elem(r, obj_table, esize, n, free_space); I don't think those HTS and RTS modes work if the code is compiled without the experimental flag. -- David Marchand