Re: [PATCH v3 1/9] drivers/raw: introduce cnxk rvu lf device driver

[David Marchand <david.marchand@redhat.com>]

On Tue, Oct 8, 2024 at 8:49 PM Akhil Goyal <gakhil@marvell.com> wrote:
>
> CNXK product families can have a use case to allow PF and VF
> applications to communicate using mailboxes and also get notified
> of any interrupt that may occur on the device.
> Hence, a new raw device driver is added for such RVU LF devices.
> These devices can map to a PF or a VF which can send mailboxes to
> each other.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>

Some small comments below.


> diff --git a/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c b/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c
> new file mode 100644
> index 0000000000..36067909be
> --- /dev/null
> +++ b/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c
> @@ -0,0 +1,123 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2024 Marvell.
> + */
> +
> +#include <bus_pci_driver.h>
> +#include <rte_common.h>
> +#include <dev_driver.h>
> +#include <rte_eal.h>
> +#include <rte_lcore.h>
> +#include <rte_pci.h>
> +#include <rte_rawdev.h>
> +#include <rte_rawdev_pmd.h>
> +
> +#include <roc_api.h>
> +
> +#include "cnxk_rvu_lf.h"
> +
> +static const struct rte_rawdev_ops rvu_lf_rawdev_ops = {
> +       .dev_selftest = NULL,
> +};
> +
> +static void
> +rvu_lf_rawdev_get_name(char *name, struct rte_pci_device *pci_dev)
> +{
> +       snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "RVU LF:%02x:%02x.%x",
> +                pci_dev->addr.bus, pci_dev->addr.devid,
> +                pci_dev->addr.function);
> +}
> +
> +static int
> +rvu_lf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
> +{
> +       char name[RTE_RAWDEV_NAME_MAX_LEN];
> +       struct rte_rawdev *rvu_lf_rawdev;
> +       struct roc_rvu_lf *roc_rvu_lf;
> +       int ret;
> +
> +       RTE_SET_USED(pci_drv);
> +
> +       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> +               return 0;
> +
> +       if (!pci_dev->mem_resource[2].addr) {
> +               CNXK_RVU_LF_LOG(ERR, "BARs have invalid values: BAR0 %p\n BAR2 %p",

No \n in the middle of a log please.


> +                             pci_dev->mem_resource[2].addr, pci_dev->mem_resource[4].addr);
> +               return -ENODEV;
> +       }
> +
> +       ret = roc_plt_init();
> +       if (ret)
> +               return ret;
> +
> +       rvu_lf_rawdev_get_name(name, pci_dev);
> +       rvu_lf_rawdev = rte_rawdev_pmd_allocate(name, sizeof(*roc_rvu_lf),
> +                                             rte_socket_id());
> +       if (rvu_lf_rawdev == NULL) {
> +               CNXK_RVU_LF_LOG(ERR, "Failed to allocate rawdev");
> +               return -ENOMEM;
> +       }
> +
> +       rvu_lf_rawdev->dev_ops = &rvu_lf_rawdev_ops;
> +       rvu_lf_rawdev->device = &pci_dev->device;
> +       rvu_lf_rawdev->driver_name = pci_dev->driver->driver.name;
> +
> +       roc_rvu_lf = (struct roc_rvu_lf *)rvu_lf_rawdev->dev_private;
> +       roc_rvu_lf->pci_dev = pci_dev;
> +
> +       ret = roc_rvu_lf_dev_init(roc_rvu_lf);
> +       if (ret) {
> +               rte_rawdev_pmd_release(rvu_lf_rawdev);
> +               return ret;
> +       }
> +
> +       return 0;
> +}
> +
> +static int
> +rvu_lf_remove(struct rte_pci_device *pci_dev)
> +{
> +       char name[RTE_RAWDEV_NAME_MAX_LEN];
> +       struct roc_rvu_lf *roc_rvu_lf;
> +       struct rte_rawdev *rawdev;
> +
> +       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> +               return 0;
> +
> +       if (pci_dev == NULL) {
> +               CNXK_RVU_LF_LOG(ERR, "invalid pci_dev");
> +               return -EINVAL;
> +       }
> +
> +       rvu_lf_rawdev_get_name(name, pci_dev);
> +       rawdev = rte_rawdev_pmd_get_named_dev(name);
> +       if (rawdev == NULL) {
> +               CNXK_RVU_LF_LOG(ERR, "invalid device name (%s)", name);
> +               return -EINVAL;
> +       }
> +
> +       roc_rvu_lf = (struct roc_rvu_lf *)rawdev->dev_private;
> +       roc_rvu_lf_dev_fini(roc_rvu_lf);
> +
> +       return rte_rawdev_pmd_release(rawdev);
> +}
> +
> +static const struct rte_pci_id pci_rvu_lf_map[] = {
> +       CNXK_PCI_ID(PCI_SUBSYSTEM_DEVID_CNF20KA, PCI_DEVID_CNXK_RVU_BPHY_PF),
> +       CNXK_PCI_ID(PCI_SUBSYSTEM_DEVID_CNF20KA, PCI_DEVID_CNXK_RVU_BPHY_VF),
> +       {
> +               .vendor_id = 0,
> +       },
> +};
> +
> +static struct rte_pci_driver cnxk_rvu_lf_rawdev_pmd = {
> +       .id_table = pci_rvu_lf_map,
> +       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_NEED_IOVA_AS_VA,
> +       .probe = rvu_lf_probe,
> +       .remove = rvu_lf_remove,
> +};
> +
> +RTE_PMD_REGISTER_PCI(rvu_lf_rawdev_pci_driver, cnxk_rvu_lf_rawdev_pmd);
> +RTE_PMD_REGISTER_PCI_TABLE(rvu_lf_rawdev_pci_driver, pci_rvu_lf_map);
> +RTE_PMD_REGISTER_KMOD_DEP(rvu_lf_rawdev_pci_driver, "vfio-pci");
> +RTE_LOG_REGISTER_SUFFIX(cnxk_logtype_rvu_lf, rvu_lf, INFO);
> diff --git a/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.h b/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.h
> new file mode 100644
> index 0000000000..a23a629500
> --- /dev/null
> +++ b/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.h
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2024 Marvell.
> + */
> +
> +#ifndef _CNXK_RVU_LF_H_
> +#define _CNXK_RVU_LF_H_
> +
> +#include <stdint.h>
> +
> +#include <rte_common.h>
> +
> +/**
> + * @file cnxk_rvu_lf.h
> + *
> + * Marvell RVU LF raw PMD specific internal structures
> + *
> + * This API allows applications to manage RVU LF device in user space along with
> + * installing interrupt handlers for low latency signal processing.
> + */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif

You don't need this for non exported/internal headers.


> +
> +extern int cnxk_logtype_rvu_lf;
> +
> +#define CNXK_RVU_LF_LOG(level, fmt, args...)   \
> +       rte_log(RTE_LOG_ ## level, cnxk_logtype_rvu_lf, \
> +               "%s(): " fmt "\n", __func__, ## args)

Please convert to RTE_LOG_LINE_PREFIX.


> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _CNXK_RVU_LF_H_ */


-- 
David Marchand