From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3166FA0C4C; Tue, 16 Nov 2021 21:39:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D65AE4114A; Tue, 16 Nov 2021 21:39:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E1DCA410FD for ; Tue, 16 Nov 2021 21:39:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637095197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=idgF2zpoiJbWxSSjtPc6rkBQZ1nw6Sh7LhKLhKgQg1E=; b=J3O0B4ySJ4CxKpiMXIByRNa63xWbpJs0cS0B+moc9SaYaGihcjwn7z6+823pw8rcmRHixw R+iHPA16MNU5s5n8Yst6+woXFzwdNfFrKEUzAEgkj+hm2YDF3SHaD1DBfmUiToYVOngjlu ULdyjUerulCKSGN9UbINO1n/sHYGtCY= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-WQycOikCPn-TkwZ8pyKt3g-1; Tue, 16 Nov 2021 15:39:54 -0500 X-MC-Unique: WQycOikCPn-TkwZ8pyKt3g-1 Received: by mail-lj1-f197.google.com with SMTP id i14-20020a2e864e000000b00218a2c57df8so153372ljj.20 for ; Tue, 16 Nov 2021 12:39:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=idgF2zpoiJbWxSSjtPc6rkBQZ1nw6Sh7LhKLhKgQg1E=; b=uT7tE9KjcHkP3zC9govxaXOKEVBRh7JUJZ0IK5++TXPqg8Gzg0FHmLWDm9dlx1tZLK PAfr+efIX7fRUULpNJzaVjfOG5A4Q/iwhPTDDjm8NwnRDUd/aAJC7N9wMGiRVuDFXSc3 zBoDk9oMSLVAOWShqv5qsbMmR7E+LxtCbaxbYupwuEfDewueD2uvjxYejhSy1g7BFyrH QL422cr1rARxvnZ1ZRsJGI6OYrR+AEaadIUS90dM/K5IN3JxQ6pKOa0gBdBN91voidMB IR6QGx5QBm+r+QGWI6tKWtvaj5ZAuIo+Jr+hJyojQn0c/vj4qE9+gIaBVAWxk7l8GRq4 jaSg== X-Gm-Message-State: AOAM5327jQoV4wBvBT9wI4FaCbJrnMDtW5Afhgys2FARPwjyaDfKYxRg BjumQL4BnDTJ+wDWiwZKICD2VK96RGUUReX5ouDAk92LdRRX7pUrt5e/jns4OohVnVPwKZqcqIy vy7x8L6zbADDVEip64ag= X-Received: by 2002:a2e:96c2:: with SMTP id d2mr2199566ljj.46.1637095193005; Tue, 16 Nov 2021 12:39:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwh2Pn4GGgPHDeibO3Ius4YdoQs4tShivmFIHSeQwhSheVLt6SkqFY66OGm0UGuIhJitx5ycMlOfBWrSYvXyc8= X-Received: by 2002:a2e:96c2:: with SMTP id d2mr2199547ljj.46.1637095192811; Tue, 16 Nov 2021 12:39:52 -0800 (PST) MIME-Version: 1.0 References: <20211110164814.5231-1-david.marchand@redhat.com> <20211110164814.5231-2-david.marchand@redhat.com> <41978474.LeJqzCrlB4@thomas> In-Reply-To: <41978474.LeJqzCrlB4@thomas> From: David Marchand Date: Tue, 16 Nov 2021 21:39:41 +0100 Message-ID: Subject: Re: [PATCH 1/5] ci: test build with minimum configuration To: Thomas Monjalon Cc: dev , Bruce Richardson , Luca Boccassi , Timothy Redaelli , Ilya Maximets , Jim Harris , mohammed@hawari.fr, Aaron Conole , Michael Santana Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 6:06 PM Thomas Monjalon wrote: > > 10/11/2021 17:48, David Marchand: > > Disabling optional libraries was not tested. > > Add a new target in test-meson-builds.sh and GHA. > > > > The Bluefield target is removed from test-meson-builds.sh to save space > > and compilation time in exchange of the new target. > > OK to remove build-arm64-bluefield. > We should also remove build-arm64-host-clang which has no benefit. To be fair, I originally had no such change and added this following an offline discussion you and I had :-). But this is going farther than what this patch is about: testing disabling components through existing options. > And instead of adding a new target, can we reuse an existing one, > like build-clang-static or build-arm64-dpaa? Reusing means we lose some coverage of the existing target. I prefer adding a dedicated target. So I think I'll go back to my original idea and drop the bluefield change. To make this new target less space/cpu consuming (which impacts us, maintainers, when merging patches), I can make it a really minimalistic configuration: I would disable all drivers (but the net/null one used in test-null.sh). I don't mind looking into other target usefulness in test-meson-builds.sh, but as a followup series. -- David Marchand