From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A346842CA2; Mon, 19 Jun 2023 09:53:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80D75410D7; Mon, 19 Jun 2023 09:53:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 33828410D3 for ; Mon, 19 Jun 2023 09:53:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687161233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NvjGZG6lSPn8Loph9BQ/Muu//529pFIj9Br9FQbc03s=; b=Uybjbcin9FA/ZfEdKO5aoVhzz1Q6evPa0s4x9F+QfK1iNTm+8eCm5axnjaxzQQCbj+Ts4h xErr9B8RaDt/5oE1plgPBTTRGlAe/b8cdhUnqi42bpxcpPPQ75YTFCG7sVuSXQCJIaEyE4 /LTxWyXoIG5qsMA8v2jJ7/UiBjE8Tf4= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-zRKbe-iNOhO7J2A7eyuICw-1; Mon, 19 Jun 2023 03:53:52 -0400 X-MC-Unique: zRKbe-iNOhO7J2A7eyuICw-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-25ea3a6d7d4so1237410a91.0 for ; Mon, 19 Jun 2023 00:53:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687161231; x=1689753231; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NvjGZG6lSPn8Loph9BQ/Muu//529pFIj9Br9FQbc03s=; b=O25/z2uKizh6KXrRjyZbZf4fvb2K6cWhYjqxIxr12kayMHYAd1D0wnUcB6kpO+FzyR r2rJY963+GvtNKu/SurtcfFkHkDzi6IbkZlaJJ6PY9vrqGA7PNGNDSgX7Yr2WmOEDxjL VDpz2gyl5CJ4ukdCMCuZlG678CdruBynibfq8/Hn1jfGZYsrHbFn+jiTX9lIWhvXVOnr hYHii/cK2Bw5HzkoKcYe1By8xyjJ6ORZJH/r8dtX4KNkW2mI6fdp/9yFyyqCwjPFAeHs e5Q7Ni0G6v0sOdnV1Uc6yfAe4aQbDeYvqJOiKV+wBfabRYdIiO4PYSUwyg9Zc4cJo/4e zPwA== X-Gm-Message-State: AC+VfDxuC5Z4pfP3td9hmbpQ9s7QzgP6FXyoLwysF9S2WrK7a/LXfm0s wI7Lc87juB7waoLhm/VjOMUWBYIbeMe2PicXGLoDqCmMsGaD7xX8hiEIMnA46FAohQxXGAnCPSO qOWcpBO5PM8/eHW0uM/c= X-Received: by 2002:a17:90a:ba8a:b0:25e:f6c0:4961 with SMTP id t10-20020a17090aba8a00b0025ef6c04961mr1122925pjr.43.1687161231376; Mon, 19 Jun 2023 00:53:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5YAROVD7yT58NlT+60qX/UlAdt2tcIWZcv4LYxrui54QUjny0J6uOFR3Q74CXaHlys5dwFez67oRN51eErTB8= X-Received: by 2002:a17:90a:ba8a:b0:25e:f6c0:4961 with SMTP id t10-20020a17090aba8a00b0025ef6c04961mr1122917pjr.43.1687161231096; Mon, 19 Jun 2023 00:53:51 -0700 (PDT) MIME-Version: 1.0 References: <1686857402-29916-1-git-send-email-roretzla@linux.microsoft.com> <1686857402-29916-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1686857402-29916-2-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Mon, 19 Jun 2023 09:53:39 +0200 Message-ID: Subject: Re: [PATCH] net/ixgbe: fix inverted test and set conditional To: Tyler Retzlaff Cc: dev@dpdk.org, Qiming Yang , Wenjun Wu , mb@smartsharesystems.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 15, 2023 at 9:30=E2=80=AFPM Tyler Retzlaff wrote: > > Correct a mistake when converting ixgbe to use __atomic_test_and_set > instead of rte_atomic32_test_and_set. The return value from > __atomic_test_and_set is inverted relative to rte_atomic32_test_and_set. > > Fixes: e90baf6b82f6 ("net/ixgbe: replace legacy atomics with GCC builtin = atomics") > > Signed-off-by: Tyler Retzlaff Reviewed-by: David Marchand Thanks for the fix Tyler. --=20 David Marchand