From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5E28A09D3; Thu, 12 Nov 2020 14:49:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A69656A3; Thu, 12 Nov 2020 14:49:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id B10B34CA6 for ; Thu, 12 Nov 2020 14:49:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605188946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JqHNN/y8I6gBPd5bfzIs2GwN69XQ7TWK9Wrtq//87/o=; b=Uq9iYGyXCUoJ8vyrybMPOXPgCrlydyqceXmXxzc42AuvuEFiC1FJzgwaFZW7qKv1Z+guo0 vqGIrGIYzYJua5u2kiCTolvTdH71XlFQXZ+eg3zE/+cUjgxcZuHVSopcIZHcpel3Zk3t58 fO7prSACxjuf/0+SaHipS//9vSw9i2A= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-RA0KPO6oOayMdr-fEKYAVg-1; Thu, 12 Nov 2020 08:49:04 -0500 X-MC-Unique: RA0KPO6oOayMdr-fEKYAVg-1 Received: by mail-vk1-f198.google.com with SMTP id v3so1534495vkn.19 for ; Thu, 12 Nov 2020 05:49:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JqHNN/y8I6gBPd5bfzIs2GwN69XQ7TWK9Wrtq//87/o=; b=WOR39aGTUBt6W5mQUf92GoTvsRa2TtpMVHHSm1L61vlhedv8zihE9O2YimAMtXmbNG b/CTFqiW9+cFIfVt7GQBOUpG6ObJa3BfvkJcKlVMBwc5MOgmmm2FtYBw4bENeE6Qfz6d SsIk0BCshezSTt4XPxnbItmw3xNRzHHFaDRDIsTi7JJsmVLwcfCk68menvCKItpEET4o yDQHtoQaPvoIdezNDsEQ/c/J0AcIZwBPrmgXG039vrRvg2LENE8NrUX5XVbiY2aa4pjC jd50AUCQZmqjRl0QBBfOWpaxArCxu0LGpaXmRVOIJP3QxSgGcQndvS1h9W0G8MzPKgBm ZOOw== X-Gm-Message-State: AOAM531mhaLhailrZizl0G2Xj6SnYPSfDYH7udteP5s2NZkKUA5r+3Fv omR/RAW+uD/mfZ2B6d6vA6UFxDCSTajm0baa19SOUE6Y5m5+u8t7IR2NEgKw8wnPwOLwtnaVv8T MWBIHypo3Rz1jIdEs/aI= X-Received: by 2002:a1f:23d6:: with SMTP id j205mr16063764vkj.20.1605188944105; Thu, 12 Nov 2020 05:49:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzVRtRSuCHDLrc2Ny2APEAI2f8lBZjz1y2NOVLOJNc8WjAXbbzZe6XYRtcE3DPM9uX2G5KmRWftI6bOrx+xGkw= X-Received: by 2002:a1f:23d6:: with SMTP id j205mr16063754vkj.20.1605188943921; Thu, 12 Nov 2020 05:49:03 -0800 (PST) MIME-Version: 1.0 References: <20201110170809.1309043-1-bruce.richardson@intel.com> <20201112094142.1781861-1-bruce.richardson@intel.com> <20201112113827.GG1309@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201112113827.GG1309@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 12 Nov 2020 14:48:52 +0100 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 12, 2020 at 12:38 PM Bruce Richardson wrote: > > My only comment is about vm_power_manager which won't build without > > the internal librte_power header. > > It builds fine with meson, because I guess meson pulls this library > > directory into the include flags of the example, but it won't build > > outside. > > > > We can skip it in devtools/test-meson-builds.sh but, on the other > > hand, I would exclude it from installing until it is fixed (in a > > future release). > > > Yes, good point. > Rather than adding special logic for it, I think we just add it in the > initialization of the exclusion array in patch 4, i.e. > > -dpdk_examples_exclude = []$ > +dpdk_examples_exclude = ['vm_power_manager'] > > Can this be done on apply, or do you want a v5 for it? CI is happy with v4. I tested this additional change, lgtm too. I would add something in the commitlog to give some context: """ vm_power_manager relies on an internal header and can't build outside the dpdk tree. Hence, it is still built with meson but it is excluded from install examples until it has been fixed. """ WDYT? -- David Marchand