From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 107A5A0547; Sat, 30 Oct 2021 22:41:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B28340DDD; Sat, 30 Oct 2021 22:41:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8FB4F40DDB for ; Sat, 30 Oct 2021 22:41:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635626498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wn41DnuAIhAZAp3SCalroTBNTCfYOijYoPU7CtWf8o0=; b=IQtv+7VI/aAyROXjUgHHB2p1qof/HlspeFdJgGxGHyI+HCfGo2YMV7bh7sD+9tyO6m9hmS JxSPtNGgFKY+1hEipqfiyn8LoO22Aqb1UKrBJkDghQd/S3leOMBM9B5lhZw3Ur/L/0LOv5 GTrdpKGelD20+AX/AvDqMTvDNKjbV5s= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-186-wyAjpWpiPQq8k3pVdO723g-1; Sat, 30 Oct 2021 16:41:34 -0400 X-MC-Unique: wyAjpWpiPQq8k3pVdO723g-1 Received: by mail-lj1-f200.google.com with SMTP id r13-20020a2e970d000000b00211a01c5f3fso4283393lji.7 for ; Sat, 30 Oct 2021 13:41:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wn41DnuAIhAZAp3SCalroTBNTCfYOijYoPU7CtWf8o0=; b=Tzjb004wkgLNzC0qTjSqI9UKr5a2Z0FfInp15Wj2UM584Jmrs79TraJjH8OV6Q3n/V uqahNQ40w2qlZdYMPhggtOVKQ1nmkkKV1oU3e/qNcTB8RQgmCwN/Evi5vAzyxMr4BN+j NgI402pOrHo0snLmN+FpMNwnHNkEbR+3HaoRORrspoTDfcjYJl4z/RJNd2tfXlBNTQBF 6MiqE+E/dgma69tdNs0zUVPU9fuuZsuJOAK+b1sjv0umUVSl4UwXm9hi/H0TV3uM4LGw ihDXu+77teC84ax9tmuSE5kQXmpDO4PmCvPR2VNC6qbGm2+AUssAivg94Pw03FChloeH BuJw== X-Gm-Message-State: AOAM533SuiRXNCwnSSFCZBMWeF9ZA2myJCYOT29A+9OopYUFa6lGu3sZ ksu92swbcLPoNIsd6AqCIWKqlVyY9alVAfD08US2KVIyjMuNy3blH32dm9+c6Q1/xet4rd/XeQC YpmgIMyQlu6lMff8tDI8= X-Received: by 2002:a2e:901:: with SMTP id 1mr20328546ljj.333.1635626492946; Sat, 30 Oct 2021 13:41:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQbXCeZ1nKXhazVApSQ0PTFeMWmY0KGHGg/TFTv84mroHPmxlQTA6vBqonf+g47kDOcz9kJzZof3TVDrXkklk= X-Received: by 2002:a2e:901:: with SMTP id 1mr20328526ljj.333.1635626492713; Sat, 30 Oct 2021 13:41:32 -0700 (PDT) MIME-Version: 1.0 References: <20210909142428.750634-1-radu.nicolau@intel.com> <20211028160500.2775783-1-radu.nicolau@intel.com> <20211028160500.2775783-5-radu.nicolau@intel.com> In-Reply-To: <20211028160500.2775783-5-radu.nicolau@intel.com> From: David Marchand Date: Sat, 30 Oct 2021 22:41:21 +0200 Message-ID: To: Radu Nicolau , "Yigit, Ferruh" Cc: Jingjing Wu , Beilei Xing , Ray Kinsella , dev , Declan Doherty , abhijit.sinha@intel.com, Qi Zhang , Bruce Richardson , "Ananyev, Konstantin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v13 4/7] net/iavf: add iAVF IPsec inline crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 28, 2021 at 6:21 PM Radu Nicolau wrote: > +static const struct rte_cryptodev_symmetric_capability * > +get_capability(struct iavf_security_ctx *iavf_sctx, > + uint32_t algo, uint32_t type) > +{ > + const struct rte_cryptodev_capabilities *capability; > + int i = 0; > + > + capability = &iavf_sctx->crypto_capabilities[i]; > + > + while (capability->op != RTE_CRYPTO_OP_TYPE_UNDEFINED) { > + if (capability->op == RTE_CRYPTO_OP_TYPE_SYMMETRIC && > + capability->sym.xform_type == type && > + capability->sym.cipher.algo == algo) > + return &capability->sym; > + /** try next capability */ > + capability = &iavf_crypto_capabilities[i++]; > + } > + > + return NULL; > +} As of cc13af13c8e6 ("net/ngbe: support Tx done cleanup"), next-net build is still KO for Windows: http://mails.dpdk.org/archives/test-report/2021-October/236938.html FAILED: drivers/libtmp_rte_net_iavf.a.p/net_iavf_iavf_ipsec_crypto.c.obj "clang" "-Idrivers\libtmp_rte_net_iavf.a.p" "-Idrivers" "-I..\drivers" "-Idrivers\net\iavf" "-I..\drivers\net\iavf" "-Idrivers\common\iavf" "-I..\drivers\common\iavf" "-Ilib\ethdev" "-I..\lib\ethdev" "-I." "-I.." "-Iconfig" "-I..\config" "-Ilib\eal\include" "-I..\lib\eal\include" "-Ilib\eal\windows\include" "-I..\lib\eal\windows\include" "-Ilib\eal\x86\include" "-I..\lib\eal\x86\include" "-Ilib\eal\common" "-I..\lib\eal\common" "-Ilib\eal" "-I..\lib\eal" "-Ilib\kvargs" "-I..\lib\kvargs" "-Ilib\net" "-I..\lib\net" "-Ilib\mbuf" "-I..\lib\mbuf" "-Ilib\mempool" "-I..\lib\mempool" "-Ilib\ring" "-I..\lib\ring" "-Ilib\metrics" "-I..\lib\metrics" "-Ilib\telemetry" "-I..\lib\telemetry" "-Ilib\meter" "-I..\lib\meter" "-Idrivers\bus\pci" "-I..\drivers\bus\pci" "-I..\drivers\bus\pci\windows" "-Ilib\pci" "-I..\lib\pci" "-Idrivers\bus\vdev" "-I..\drivers\bus\vdev" "-Ilib\security" "-I..\lib\security" "-Ilib\cryptodev" "-I..\lib\cryptodev" "-Ilib\rcu" "-I..\lib\rcu" "-Xclang" "-fcolor-diagnostics" "-pipe" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-Werror" "-O3" "-include" "rte_config.h" "-Wextra" "-Wcast-qual" "-Wdeprecated" "-Wformat" "-Wformat-nonliteral" "-Wformat-security" "-Wmissing-declarations" "-Wmissing-prototypes" "-Wnested-externs" "-Wold-style-definition" "-Wpointer-arith" "-Wsign-compare" "-Wstrict-prototypes" "-Wundef" "-Wwrite-strings" "-Wno-address-of-packed-member" "-Wno-missing-field-initializers" "-D_GNU_SOURCE" "-D_WIN32_WINNT=0x0A00" "-D_CRT_SECURE_NO_WARNINGS" "-march=native" "-DALLOW_EXPERIMENTAL_API" "-DALLOW_INTERNAL_API" "-Wno-strict-aliasing" "-DCC_AVX2_SUPPORT" "-DCC_AVX512_SUPPORT" "-DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.iavf" -MD -MQ drivers/libtmp_rte_net_iavf.a.p/net_iavf_iavf_ipsec_crypto.c.obj -MF "drivers\libtmp_rte_net_iavf.a.p\net_iavf_iavf_ipsec_crypto.c.obj.d" -o drivers/libtmp_rte_net_iavf.a.p/net_iavf_iavf_ipsec_crypto.c.obj "-c" ../drivers/net/iavf/iavf_ipsec_crypto.c ../drivers/net/iavf/iavf_ipsec_crypto.c:111:31: error: comparison of integers of different signs: 'const enum rte_crypto_sym_xform_type' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] capability->sym.xform_type == type && ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~ ../drivers/net/iavf/iavf_ipsec_crypto.c:112:32: error: comparison of integers of different signs: 'const enum rte_crypto_cipher_algorithm' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] capability->sym.cipher.algo == algo) ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~ 2 errors generated. -- David Marchand