From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66FCD41C4B; Thu, 9 Feb 2023 09:45:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5412F40DF8; Thu, 9 Feb 2023 09:45:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 924624067B for ; Thu, 9 Feb 2023 09:45:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675932305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4HZGGV0ysi3frKWzXEjNHMSZ90MMOXv7ZkGRZQLDd/g=; b=DfKfMLpnq3bFlRU6TKuq94L9XcytNlJsQeQh7cj4Fe8U139VyYbLaVebtbujlrJWBsxRJu 8moTxuLhjRssrtO2DYit2v4CMmFCnZg0SFjvIDhrJ06dKYu39CrLKu5d6tiyTmWBiUI86B a1xCojF0J59oFi1VwkGHe8NaX2rhN0k= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-554-f74x8YLCPA2-NR1lxO58sA-1; Thu, 09 Feb 2023 03:45:03 -0500 X-MC-Unique: f74x8YLCPA2-NR1lxO58sA-1 Received: by mail-pj1-f69.google.com with SMTP id e11-20020a17090a77cb00b0022925dd66d3so2644972pjs.4 for ; Thu, 09 Feb 2023 00:45:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4HZGGV0ysi3frKWzXEjNHMSZ90MMOXv7ZkGRZQLDd/g=; b=DfSrk7bHahX1PghxnlyUBtPbhUfHNHl0eZOuWOvdPFo02FNcJdgfY4IzO6R6vQHY2f 9zuEjblI6Gd/3SjhmgcijpmKudTu0Tv2WhUQNSvmjXWoAylVdIFRQArCp4jUZh+o56SX 4qam5rmITwrrsHl7zBnkR0uwtIl75p4Wtaw+2JvdhBBPFhMoEfjGleb5kU98Q9833/oI c2mxBndRXr/PZVykNVvbMJwjwCih4wNUEdzS/nHD84EXjdJ3xIZroGEyti6cfk68OM8J HMjmIsxJMOA4ZL6Gm4WWgkrBgQyTayPhXBjqUEzKeGbcatsFzc1mX35Fs5wt5/Kmn3c9 QEwA== X-Gm-Message-State: AO0yUKWnZfhoyS9ExqldtIPgDTWv472bRkKgxfNy7qJgMUjb9tfWqVCk VV6NMnI+ucn2s+BSFzAw6NPcuCxbexAhp5dGED0ObiZgGMXG9H8Pg+JBewfNAvfe5F2eTbBGD3Q DGT2YIHJuRiEWXiRfuYk= X-Received: by 2002:a62:1dcc:0:b0:593:f5e4:8d93 with SMTP id d195-20020a621dcc000000b00593f5e48d93mr2589562pfd.4.1675932302690; Thu, 09 Feb 2023 00:45:02 -0800 (PST) X-Google-Smtp-Source: AK7set9+yYxoPfJU5MOmSuloDjJ2Xp12jjW0FtyWPU/QkNPTb89uZbpgAEpjoXamrIk3BLBP4PwuXK6yfkUrR1m3kBQ= X-Received: by 2002:a62:1dcc:0:b0:593:f5e4:8d93 with SMTP id d195-20020a621dcc000000b00593f5e48d93mr2589557pfd.4.1675932302368; Thu, 09 Feb 2023 00:45:02 -0800 (PST) MIME-Version: 1.0 References: <20221123102612.1688865-1-rjarry@redhat.com> <20230208084507.1328625-1-rjarry@redhat.com> In-Reply-To: <20230208084507.1328625-1-rjarry@redhat.com> From: David Marchand Date: Thu, 9 Feb 2023 09:44:50 +0100 Message-ID: Subject: Re: [RESEND PATCH v9 0/5] lcore telemetry improvements To: Robin Jarry Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Robin, On Wed, Feb 8, 2023 at 9:45 AM Robin Jarry wrote: > > This is a follow up on previous work by Kevin Laatz: > > http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* > > This series is aimed at allowing DPDK applications to expose their CPU > usage stats in the DPDK telemetry under /eal/lcore/info. This is a much > more basic and naive approach which leaves the cpu cycles accounting > completely up to the application. > > For reference, I have implemented a draft patch in OvS to use > rte_lcore_register_usage_cb() and report the already available busy > cycles information. > > https://github.com/rjarry/ovs/commit/643e672fe388e348ea7ccbbda6f5a87a066fd919 > > v9: > > - Fixed changelog & version.map order. > - Updated with 64-bit integer telemetry functions. > - Refined docstrings (added notice about resetting the callback). > - Fixed accounting of total cycles in testpmd. > > v8: > > - Made /eal/lcore/info lcore_id argument parsing more robust. > > Robin Jarry (5): > eal: add lcore info in telemetry > eal: report applications lcore usage > app/testpmd: add dump command for lcores > app/testpmd: report lcore usage > eal: add lcore usage telemetry endpoint > > app/test-pmd/cmdline.c | 3 + > app/test-pmd/noisy_vnf.c | 8 +- > app/test-pmd/testpmd.c | 42 +++- > app/test-pmd/testpmd.h | 25 ++- > doc/guides/rel_notes/release_23_03.rst | 8 + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 + > lib/eal/common/eal_common_lcore.c | 219 ++++++++++++++++++-- > lib/eal/include/rte_lcore.h | 48 +++++ > lib/eal/version.map | 1 + > 9 files changed, 329 insertions(+), 32 deletions(-) Thanks for this work. The EAL parts look ready to me, but I still have some concerns on the implementation in testpmd (see comments on patch 4). -- David Marchand