From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CFB5A04B5; Thu, 29 Oct 2020 17:09:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F041ECAA9; Thu, 29 Oct 2020 17:09:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id D45A8C9C2 for ; Thu, 29 Oct 2020 17:09:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603987786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mMJP56/uizXzSYsg98spfC7cZWTqeu/RIXJulp4EZso=; b=RytWr1c4J3wrnUadHpQr/FKiDb6FrKemHD7U2yedLlkBpPPLhLp1abi1IDtRLtOSe/mOLo qCfEjtqo4k0wWE46mnAD9q6lciW6l65TLbRyoJ390ygouRBQihRySxxSd3F/pDgzkcxyoz uPnNhG6Q2rXVvXeThD9f1n9g/3lGolQ= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-v-zFtRKfPRGAVcgwSLs69g-1; Thu, 29 Oct 2020 12:09:37 -0400 X-MC-Unique: v-zFtRKfPRGAVcgwSLs69g-1 Received: by mail-io1-f71.google.com with SMTP id q126so2256365iof.3 for ; Thu, 29 Oct 2020 09:09:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mMJP56/uizXzSYsg98spfC7cZWTqeu/RIXJulp4EZso=; b=gd3epFJfH2R2JsffdEQYgNzrDQcit93JORFKfTT7WrO0TEat4JsNuvnTVtqq8NTLxL 7jO2fwEqgxljktd8Sm7ZUnhI+YRZM9udtBeR9xeB8wQnix8uzQfKEvpQimnCKWyW6bQq /y6U2WRyDe7YY4SlH6EUyvsEqvBp8NHSUwc/xoQqXbv7M+b8Ht6Rq29I7ZagrxRlsHMp NDiOsLvuJ8BfEyViRrFgTLFDzzjF+WANSW6fosmFaw1iTcL3dXZqRlah7phav26lb1Za RqWqf+68CKOvYla1ErKMlkCxiM4tyAOmlHUWjE8c5ucX6dwKZ7TR+heYeM3IoH3EiHqK 0Gew== X-Gm-Message-State: AOAM530VfI6xzBFd1hOS34+S3KgpCI9M1MOm2wQw1XAs9zp8NtYxGruy NV2hIpClwyFkKmncwPhrJoY0Voaf792Jd/TWZFjsU4jQUCzYEsrk1yAEDWLqWTCXANcO1HuHw7g j2L+CxIwZFcciSoDXJVQ= X-Received: by 2002:a05:6638:97:: with SMTP id v23mr4340243jao.7.1603987776683; Thu, 29 Oct 2020 09:09:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJBH4R7jU4ZRR3W/nfPzxHlv4kTIfYiKl/pc7Jw7tbg8v0I0iy3zU3OWDhA1nWAD55TOff3xsw8pPhaIm+8X4= X-Received: by 2002:a05:6638:97:: with SMTP id v23mr4340232jao.7.1603987776475; Thu, 29 Oct 2020 09:09:36 -0700 (PDT) MIME-Version: 1.0 References: <1600511670-27576-1-git-send-email-wangyunjian@huawei.com> <1602751350-2808-1-git-send-email-wangyunjian@huawei.com> <20201028211845.GB137989@outlook.office365.com> In-Reply-To: <20201028211845.GB137989@outlook.office365.com> From: David Marchand Date: Thu, 29 Oct 2020 17:09:24 +0100 Message-ID: To: wangyunjian Cc: Harman Kalra , dev , "Yigit, Ferruh" , Jerin Jacob Kollanukkaran , "Lilijun (Jerry)" , xudingke , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH v2] eal: fix dereference after null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 10:19 PM Harman Kalra wrote: > On Thu, Oct 15, 2020 at 04:42:30PM +0800, wangyunjian wrote: > > This patch fixes (dereference after null check) coverity issue. > > For this reason, we should add null check at the beginning of the > > function and return error directly if the 'intr_handle' is null. > > > > Coverity issue: 357695, 357751 > > Fixes: 05c4105738d8 ("trace: add interrupt tracepoints") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yunjian Wang > Reviewed-by: Harman Kalra Applied, thanks. -- David Marchand