From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D871A0093; Mon, 7 Mar 2022 14:14:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D81DB40688; Mon, 7 Mar 2022 14:14:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 169424014E for ; Mon, 7 Mar 2022 14:14:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646658878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q88O8wH/aLoJHcWZ5m83E/Nx7qjZYIPerWoDWGruIk0=; b=BdSjrq9EyFt64s1Vrn/DULoyG+ZkxtWStAV7n5exBl4LJyU/JGtYxxfvVIR2HukTv+tIZn Jovk/3EGftsXn8QH17S0uFKU8+1xMyUZXsWIl5q436zVNAfMETBpxMgnXrWHQ1K8YJlYRP cB1B7y0+v1sT1YmsO2n1ZtaE6KLdmBo= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-55-0NJ344jGN1yG0xHQqkzsiA-1; Mon, 07 Mar 2022 08:14:36 -0500 X-MC-Unique: 0NJ344jGN1yG0xHQqkzsiA-1 Received: by mail-lj1-f199.google.com with SMTP id g8-20020a2e9e48000000b00247bc56d2a0so5675762ljk.15 for ; Mon, 07 Mar 2022 05:14:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q88O8wH/aLoJHcWZ5m83E/Nx7qjZYIPerWoDWGruIk0=; b=NOY+FDDc9uTluElqEGGl+Tjzo4mW+ZG0nZ4EKojJt68hHI4TyI0duKnxRWSTQClMGV jJf5pz+ZaUx4ZedfMCmvOlJwHhy+kQp+0vsIbXCMmD6lvUbfYA4AF68MIaRmrxXpFqmq 0db3bEoD0rXaBburxHfh2SbH3VzomZyWwHZkoYB0QfTgub5Xhw4+sTbc58u50wbwJI2C /6qw4NGXAReIRled2RyWfbwox0ZA4lznETqwIAUvnyFWpHhIzvIFFneZmNd+FjJ+Pf2C XLGgLz/frXeS/nPXnsou/TSO9XjrERQvPDRfgR4ZvLUK0zvP8nZqtEZ24KQtrw9plUT1 C1Aw== X-Gm-Message-State: AOAM531L0uX9hfpCHTiaEBWQEMyWO8fCRu/0qdCkpjSvW1KP8UrhSUQh ns0CFZeZ3awiX8d/Y+ITt1yJN6u608ee9DB58Pz94STBjpY8Xk2wTzX0h81wasNpsO2piSMuvsu 0pou2isuJXZtXYZt27O0= X-Received: by 2002:a05:651c:20e:b0:247:e2f1:5d7e with SMTP id y14-20020a05651c020e00b00247e2f15d7emr4149924ljn.159.1646658874982; Mon, 07 Mar 2022 05:14:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQVpkiCNsV3ypxqFHmDL5sIfRJg4rO3rGDLZV+ijbsUllF1fdbAg1ufhVnCPpz6TOprHH2CjUjMdN2/yLamGc= X-Received: by 2002:a05:651c:20e:b0:247:e2f1:5d7e with SMTP id y14-20020a05651c020e00b00247e2f15d7emr4149909ljn.159.1646658874717; Mon, 07 Mar 2022 05:14:34 -0800 (PST) MIME-Version: 1.0 References: <20220306092023.2461466-1-thomas@monjalon.net> In-Reply-To: <20220306092023.2461466-1-thomas@monjalon.net> From: David Marchand Date: Mon, 7 Mar 2022 14:14:22 +0100 Message-ID: Subject: Re: [PATCH 0/2] add missing local symbols catch-all To: Thomas Monjalon Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Mar 6, 2022 at 10:20 AM Thomas Monjalon wrote: > > The libraries (and driver) regexdev, gpudev and auxiliary bus > were missing "local:*" in their version.map linker script > which catch all non-listed functions to be hidden in shared libraries. > > Thomas Monjalon (2): > regexdev: fix section attribute of symbols > build: hide local symbols in shared libraries > > devtools/libabigail.abignore | 12 ++++++++++++ > drivers/bus/auxiliary/version.map | 2 ++ > lib/gpudev/version.map | 2 ++ > lib/regexdev/rte_regexdev.h | 4 ++++ > lib/regexdev/rte_regexdev_driver.h | 3 +++ > lib/regexdev/version.map | 11 +++++++++++ > 6 files changed, 34 insertions(+) The series lgtm. What do you think of adding a check like: diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index 5bd290ac97..4b7e340833 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -53,4 +53,18 @@ if [ -n "$duplicate_symbols" ] ; then ret=1 fi +check_local_guard () +{ + for map in $@ ; do + grep -L local: $map || true + done +} + +local_missing_map=$(check_local_guard $@) +if [ -n "$local_missing_map" ] ; then + echo "Following maps are missing a local: guard:" + echo "$local_missing_map" + ret=1 +fi + exit $ret $ ./devtools/check-symbol-maps.sh Following maps are missing a local: guard: lib/regexdev/version.map lib/gpudev/version.map drivers/bus/auxiliary/version.map -- David Marchand