From: David Marchand <david.marchand@redhat.com>
To: Aaron Conole <aconole@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Dodji Seketeli <dodji@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6
Date: Tue, 18 Feb 2020 12:18:36 +0100 [thread overview]
Message-ID: <CAJFAV8zu2Vwicrp0CG34ZAxgv9s=u_80-wp7AGyEYrthPWamyQ@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8xNg=La+90vH=Ry1u0KDWcbKSyTNaN6e896=GLwxRnrkQ@mail.gmail.com>
On Tue, Feb 18, 2020 at 10:40 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Mon, Feb 17, 2020 at 7:48 PM Aaron Conole <aconole@redhat.com> wrote:
> >
> > David Marchand <david.marchand@redhat.com> writes:
> >
> > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI
> > > breakage [1].
> > > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened
> > > in launchpad [3].
> > >
> > > But for now, build and use the last version 1.6 so that the ABI checks
> > > can be kept.
> > >
> > > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242
> > > 2: https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commitdiff;h=215b7eb4fe8b986fe1cc87d9d8e7412998038392
> > > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> >
> > Does it make sense to base libabigail required ontop of extra packages?
> > Otherwise some libraries won't get built / checked, no?
>
> The only change I see is the pcap driver being enabled.
> On the principle, I agree that trying to build all possible
> libraries/drivers is better when checking the ABI.
> So I'll keep extra_packages yes.
>
> I am currently testing that touching extra_packages (well, testing
> Thomas patches) results in Travis treating the job as a new one (i.e.
> with no cache).
Travis bases each job cache on the job description:
https://docs.travis-ci.com/user/caching/
I tested Thomas change on extra_packages content, and the job used the
old cache.
My idea was to try to put *extra_packages in an env variable, but it
does not work (my yaml-fu is lacking).
If there is no easy way, I will invalidate the cache manually.
--
David Marchand
next prev parent reply other threads:[~2020-02-18 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 13:59 David Marchand
2020-02-17 15:15 ` Thomas Monjalon
2020-02-17 18:47 ` Aaron Conole
2020-02-18 9:40 ` David Marchand
2020-02-18 11:18 ` David Marchand [this message]
2020-02-18 14:55 ` Aaron Conole
2020-02-18 15:07 ` David Marchand
2020-02-18 14:29 ` [dpdk-dev] [PATCH v2] " David Marchand
2020-02-18 15:46 ` Thomas Monjalon
2020-02-18 16:38 ` David Marchand
2020-02-19 8:13 ` Dodji Seketeli
2020-02-18 20:13 ` [dpdk-dev] [PATCH v3] " David Marchand
2020-02-18 20:31 ` Aaron Conole
2020-02-18 20:59 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zu2Vwicrp0CG34ZAxgv9s=u_80-wp7AGyEYrthPWamyQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).