From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D2C3A054F; Tue, 18 Feb 2020 12:18:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7A7A1D66C; Tue, 18 Feb 2020 12:18:56 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 8CF871D66A for ; Tue, 18 Feb 2020 12:18:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582024734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+rLEy5lwS2WM2eMaYEOQPi0RRwEsQXi5+gFpn6Sr+U=; b=YJLQr4CbM5jmzhdZAoTZX6kDB9CUixCvZiJ3SLH1z7cUfg1t+Scr4vreD2p6baMWpF4z4M aNZmsu1FiOfhrzXA2E/lN5UxTFWYdecFB9TOwb0ZkjMXPlQj/296rFAnPsC1zXEuAH0by3 hlHGicDpPgTBdVNoFNwj60/+XzbHRlo= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-JLil9QRcPV2zivwPAp6q1g-1; Tue, 18 Feb 2020 06:18:48 -0500 Received: by mail-ua1-f71.google.com with SMTP id g14so3883803uap.0 for ; Tue, 18 Feb 2020 03:18:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9RZlbAOoCqBWydgUovCvNYKv32Z/hQtl1OG0ZZ23hVI=; b=rwrqTRWG2UuiTAzSFTMdYMWMxConvMceJUPVTEpjFhVNdUyevr4WD9CBggvrsJycp4 luCpjft9HaDWcuSVU+Ia4OXVEh/WD6zyAz9i2DmWf7FL0EGKQGszPSScRRxTGOXhaGxd fZvZSZJ2cwtrnIXjXcd7lPfiwYLo7hIFKy38DGEaaY52gNoiVZqcOEqTLXt/ST5eFcXX UZf9Dmb4WU+2azoSAIWMEfGrKLMggcfJdlVh7bfsiAYx8kZsThLWjexFv6U4DKunYquf CENq10QaM8yBhuMuz+/88oFIdzqvD3QlwNaAS4Kl9xWh/+KlUUG9nugpdIf0rybt1K5U A7mw== X-Gm-Message-State: APjAAAUvUS39x5h3Cu5R4qFzzsLuV1CRIc4A3lLfPoIubi/2E0nU6Yhd H2Ge+QAWknyZeWJmZfYoSAdQoL1JvoJfQx7TBcGyloZ3O8P9+1JOTon+/SiglIJx9Q4zXMPrXFS eHesUjd2TXnwgVla8Wmo= X-Received: by 2002:a1f:1f0f:: with SMTP id f15mr363222vkf.18.1582024727719; Tue, 18 Feb 2020 03:18:47 -0800 (PST) X-Google-Smtp-Source: APXvYqzFucJsC2iTAEOiGowbha4ph7+sbN0Ej++DYloGC/bnK7v4+FJOKlnpFN1ASWadC1NZ152iZLLYSghE241tNVY= X-Received: by 2002:a1f:1f0f:: with SMTP id f15mr363211vkf.18.1582024727380; Tue, 18 Feb 2020 03:18:47 -0800 (PST) MIME-Version: 1.0 References: <20200217135929.30987-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 18 Feb 2020 12:18:36 +0100 Message-ID: To: Aaron Conole Cc: Thomas Monjalon , dev , Christian Ehrhardt , Dodji Seketeli , Michael Santana X-MC-Unique: JLil9QRcPV2zivwPAp6q1g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 18, 2020 at 10:40 AM David Marchand wrote: > > On Mon, Feb 17, 2020 at 7:48 PM Aaron Conole wrote: > > > > David Marchand writes: > > > > > libabigail 1.2 (at least) reports changes in 'const' property as an A= BI > > > breakage [1]. > > > This was fixed upstream in libabigail 1.4 [2], and a bug has been ope= ned > > > in launchpad [3]. > > > > > > But for now, build and use the last version 1.6 so that the ABI check= s > > > can be kept. > > > > > > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242 > > > 2: https://sourceware.org/git/gitweb.cgi?p=3Dlibabigail.git;a=3Dcommi= tdiff;h=3D215b7eb4fe8b986fe1cc87d9d8e7412998038392 > > > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607 > > > > > > Signed-off-by: David Marchand > > > --- > > > > Does it make sense to base libabigail required ontop of extra packages? > > Otherwise some libraries won't get built / checked, no? > > The only change I see is the pcap driver being enabled. > On the principle, I agree that trying to build all possible > libraries/drivers is better when checking the ABI. > So I'll keep extra_packages yes. > > I am currently testing that touching extra_packages (well, testing > Thomas patches) results in Travis treating the job as a new one (i.e. > with no cache). Travis bases each job cache on the job description: https://docs.travis-ci.com/user/caching/ I tested Thomas change on extra_packages content, and the job used the old cache. My idea was to try to put *extra_packages in an env variable, but it does not work (my yaml-fu is lacking). If there is no easy way, I will invalidate the cache manually. -- David Marchand