From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbox@nvidia.com, schalla@marvell.com, stable@dpdk.org
Subject: Re: [PATCH 1/2] net/virtio: fix vDPA device init advertising control queue
Date: Tue, 12 Mar 2024 15:10:01 +0100 [thread overview]
Message-ID: <CAJFAV8zuF2vx9MPJuhpNxfe0y-A3a3OjAyVKUGO8qdQxXTpeBg@mail.gmail.com> (raw)
In-Reply-To: <20240312104849.667036-2-maxime.coquelin@redhat.com>
On Tue, Mar 12, 2024 at 11:48 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> If the vDPA device advertises control queue support, but
> the user neither passes "cq=1" as devarg nor requests
> multiple queues, the initialization fails because the
> driver tries to setup the control queue without negotiating
> related feature.
>
> This patch enables the control queue at driver level as
> soon as the device claims to support it, and not only when
> multiple queue pairs are requested.
>
> Fixes: b277308e8868 ("net/virtio-user: advertise control VQ support with vDPA")
> Cc: stable@dpdk.org
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2024-03-12 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 10:48 [PATCH 0/2] net/virtio: vhost-vdpa fixes Maxime Coquelin
2024-03-12 10:48 ` [PATCH 1/2] net/virtio: fix vDPA device init advertising control queue Maxime Coquelin
2024-03-12 14:10 ` David Marchand [this message]
2024-03-12 10:48 ` [PATCH 2/2] net/virtio: fix notification area initialization Maxime Coquelin
2024-03-12 14:12 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zuF2vx9MPJuhpNxfe0y-A3a3OjAyVKUGO8qdQxXTpeBg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=schalla@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).