From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4066743C92; Tue, 12 Mar 2024 15:10:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0810A402E0; Tue, 12 Mar 2024 15:10:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1489C402D8 for ; Tue, 12 Mar 2024 15:10:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710252615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0pJrvE29166dX8nWhT19mLC1KPQcKZ+YPUwaxfYOq4M=; b=Cr/9eEgXV5S4ISmBSxa/Zo4qsawFIIa0qkviyCucrLsTv4zJq0oO7H+xPD5lpCd8ztrQRE Ziki39KbOlJRR5zB7bbO6SF9/4b462uvj0Szjc+E/NzH/52doYYhBONMKof6pPHo4/WHhF zoJ4ANtADf28cgkd/AfxFmj34Ddm/DM= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-nvMOlcoGNwGsMUcNSarjkA-1; Tue, 12 Mar 2024 10:10:14 -0400 X-MC-Unique: nvMOlcoGNwGsMUcNSarjkA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-51337da375dso4392569e87.3 for ; Tue, 12 Mar 2024 07:10:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710252613; x=1710857413; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0pJrvE29166dX8nWhT19mLC1KPQcKZ+YPUwaxfYOq4M=; b=rDGNQlNnsh5gTEueSbnOJicIhyw1VMyfXX2b7YF+J4KAkO51HeWpRWWQJuKpzbO5X7 sGd1f8nBs4YgJyvdPGe1mxqK3Rf5YLdNJ8AWGq/JFu/0Ykyz5oQowde8oQk51hbw9nmT Q2J8jFe1uKGZ2CMqjZSys6Ii067fxzteFH6DglSSUVXkv86Oi4fQZPcf/3HxzgW1rbtW XU6LyauvWEuSELWpwE18cf4ie24WheMGOUXNeIEoK94GX+2o9WE81njlCxQViL99ajLg iyTxId2B5rrUH0tzXUaEPGx3nR3Kdnwa1pP7Ov1zo3VF+Hcar6LYGY9XknEGhpLLsIlh TSvQ== X-Gm-Message-State: AOJu0YxkjcXUzQhTTI9WnQb9D/pKO+gl0caGtDZ45SzYaDmcpcy/yY3o CyQKWRGsbTpES0rkntRMFbuRxAO7yWsspM1IY2PK1eZ+tIQOiawuZtRsZJrIC2fIlcqIpW6GLSk V3VKBFeFjhghhKLZbNB6tGcj9ivzycMNEdVmftTot7Fu5qCWrUMiFF9vBsslnTdyyihcfv9ZBhJ FFgwAQgaQZR+24YSo= X-Received: by 2002:a05:6512:292:b0:513:c2c7:573e with SMTP id j18-20020a056512029200b00513c2c7573emr935949lfp.23.1710252612810; Tue, 12 Mar 2024 07:10:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGB8Bxx/UsEiBHuy1udmys30Dtn3xOOO3J1aQp2leZs8CrqBxSiogeh1dAyZt4iU8U3uCL1OxkSrljhF2m/r7c= X-Received: by 2002:a05:6512:292:b0:513:c2c7:573e with SMTP id j18-20020a056512029200b00513c2c7573emr935934lfp.23.1710252612470; Tue, 12 Mar 2024 07:10:12 -0700 (PDT) MIME-Version: 1.0 References: <20240312104849.667036-1-maxime.coquelin@redhat.com> <20240312104849.667036-2-maxime.coquelin@redhat.com> In-Reply-To: <20240312104849.667036-2-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 12 Mar 2024 15:10:01 +0100 Message-ID: Subject: Re: [PATCH 1/2] net/virtio: fix vDPA device init advertising control queue To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com, schalla@marvell.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 12, 2024 at 11:48=E2=80=AFAM Maxime Coquelin wrote: > > If the vDPA device advertises control queue support, but > the user neither passes "cq=3D1" as devarg nor requests > multiple queues, the initialization fails because the > driver tries to setup the control queue without negotiating > related feature. > > This patch enables the control queue at driver level as > soon as the device claims to support it, and not only when > multiple queue pairs are requested. > > Fixes: b277308e8868 ("net/virtio-user: advertise control VQ support with = vDPA") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --=20 David Marchand