* [PATCH] bus/fslmc: fix warning in device scan
@ 2025-11-25 14:46 Stephen Hemminger
2025-11-25 15:06 ` Hemant Agrawal
2025-11-28 8:39 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2025-11-25 14:46 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Hemant Agrawal, Sachin Saxena, Shreyansh Jain
With latest glibc (Fedora Rawhide):
../drivers/bus/fslmc/fslmc_bus.c: In function ‘rte_fslmc_parse’:
../drivers/bus/fslmc/fslmc_bus.c:298:15: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
298 | t_ptr = strchr(sep, '.');
| ^
Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/bus/fslmc/fslmc_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 4529ec5085..abdb0ad50d 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -242,7 +242,7 @@ static int
rte_fslmc_parse(const char *name, void *addr)
{
uint16_t dev_id;
- char *t_ptr;
+ const char *t_ptr;
const char *sep;
uint8_t sep_exists = 0;
int ret = -1;
--
2.51.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] bus/fslmc: fix warning in device scan
2025-11-25 14:46 [PATCH] bus/fslmc: fix warning in device scan Stephen Hemminger
@ 2025-11-25 15:06 ` Hemant Agrawal
2025-11-28 8:39 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: Hemant Agrawal @ 2025-11-25 15:06 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: Sachin Saxena
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bus/fslmc: fix warning in device scan
2025-11-25 14:46 [PATCH] bus/fslmc: fix warning in device scan Stephen Hemminger
2025-11-25 15:06 ` Hemant Agrawal
@ 2025-11-28 8:39 ` David Marchand
2025-11-28 9:15 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2025-11-28 8:39 UTC (permalink / raw)
To: Stephen Hemminger
Cc: dev, Hemant Agrawal, Sachin Saxena, Shreyansh Jain, Thomas Monjalon
On Tue, 25 Nov 2025 at 15:46, Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> With latest glibc (Fedora Rawhide):
> ../drivers/bus/fslmc/fslmc_bus.c: In function ‘rte_fslmc_parse’:
> ../drivers/bus/fslmc/fslmc_bus.c:298:15: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> 298 | t_ptr = strchr(sep, '.');
> | ^
> Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This build warning can be seen in OBS builds.
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bus/fslmc: fix warning in device scan
2025-11-28 8:39 ` David Marchand
@ 2025-11-28 9:15 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2025-11-28 9:15 UTC (permalink / raw)
To: Stephen Hemminger
Cc: dev, Hemant Agrawal, Sachin Saxena, Shreyansh Jain, David Marchand
28/11/2025 09:39, David Marchand:
> On Tue, 25 Nov 2025 at 15:46, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > With latest glibc (Fedora Rawhide):
> > ../drivers/bus/fslmc/fslmc_bus.c: In function ‘rte_fslmc_parse’:
> > ../drivers/bus/fslmc/fslmc_bus.c:298:15: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> > 298 | t_ptr = strchr(sep, '.');
> > | ^
> > Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> This build warning can be seen in OBS builds.
>
> Acked-by: David Marchand <david.marchand@redhat.com>
It is actually in device name parsing function.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-28 9:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-25 14:46 [PATCH] bus/fslmc: fix warning in device scan Stephen Hemminger
2025-11-25 15:06 ` Hemant Agrawal
2025-11-28 8:39 ` David Marchand
2025-11-28 9:15 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).