From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51DA942BA9; Fri, 26 May 2023 11:12:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28C0C40DDA; Fri, 26 May 2023 11:12:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0BDFA40A89 for ; Fri, 26 May 2023 11:11:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685092317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w5XtlL/flFSBDdb4zcUZbplySbUSZKbi71x64c+o/k4=; b=WcSJu3nQ8NJ6YVqTIONOChyWB4Fs+B1Vm+86Twk9dvw70KaJwi4+ik2r5iDjm07qhnmSfW YnZI9AZKcPiHqL2TdXTeqLd5+RVi7baZntu9Ni4/UuJPX7txvPpIWn6Kfl7W6z1Oj7/2Lo nhK3h5TZ1PKCuj/fgmlS9kmLeSLXYZ0= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-AUtauA48Mli6ZeP2Q98LFg-1; Fri, 26 May 2023 05:11:56 -0400 X-MC-Unique: AUtauA48Mli6ZeP2Q98LFg-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-64d20f79776so552923b3a.1 for ; Fri, 26 May 2023 02:11:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685092315; x=1687684315; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w5XtlL/flFSBDdb4zcUZbplySbUSZKbi71x64c+o/k4=; b=ZXMLa2TpuwL1UM+4kh9gLSPTkPHyyl9hmSAO55nf4MWhodbBdGEOzEHspyrjZOgI32 uhOdqnRgz8TJ+vGuaPoNXViU2PV9ENrZ4w4JhQA0SZGyu42UE48uVmL/cMn9WY8uJn8v d6ITzlYFFpXRwTbhY8dBadyzqXu8+RXuAkzjkPxQNyFXIRH7CEkuN5BnoTr/p+Mk5ACk E5HV+viVfBCCEXPjDIYFTCbdAVUSPa/nTUBF3ETcMj9uNVqwxfOteqVmTKacW9Qnq0HW fRu6gPGn7IcTegzDAZJ4et1q/e2YcnXtPMAOi6qldZ/NSfg/x4TVMaEgiQLxhDmw/NJO 2E4Q== X-Gm-Message-State: AC+VfDxwkB6lZeMruoOTi9NEcX4dc9TA3UmKwD9Pa+6ZMvDWKEKdEIfx JJ+wmLoLfvAXiEqFq0IDgklZsMMTC4ApYMs0L2sP4oX77NqDeflxxvEzBHzhP+0us8pcd4ubfu5 nI5jNGNvqzKoIBtgos7Y= X-Received: by 2002:a05:6a20:9146:b0:10a:9f45:e3f with SMTP id x6-20020a056a20914600b0010a9f450e3fmr2043017pzc.12.1685092315311; Fri, 26 May 2023 02:11:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7bY7ZV+OyK7dF9oXGpHyM/jYWC7WdwN1GAwP11037muUhKhkqDS93UOLVcBBlK2yxr+84v8SjaLc1giJXDgGI= X-Received: by 2002:a05:6a20:9146:b0:10a:9f45:e3f with SMTP id x6-20020a056a20914600b0010a9f450e3fmr2042993pzc.12.1685092315033; Fri, 26 May 2023 02:11:55 -0700 (PDT) MIME-Version: 1.0 References: <20230525162551.70359-1-maxime.coquelin@redhat.com> <20230525162551.70359-19-maxime.coquelin@redhat.com> In-Reply-To: <20230525162551.70359-19-maxime.coquelin@redhat.com> From: David Marchand Date: Fri, 26 May 2023 11:11:43 +0200 Message-ID: Subject: Re: [PATCH v3 18/28] vhost: add VDUSE device creation and destruction To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com, cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com, eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 25, 2023 at 6:27=E2=80=AFPM Maxime Coquelin wrote: > diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c > new file mode 100644 > index 0000000000..d67818bfb5 > --- /dev/null > +++ b/lib/vhost/vduse.c [snip] > +#define VDUSE_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) |= \ > + (1ULL << VIRTIO_F_ANY_LAYOUT) | \ > + (1ULL << VIRTIO_F_VERSION_1) | \ > + (1ULL << VIRTIO_NET_F_GSO) | \ > + (1ULL << VIRTIO_NET_F_HOST_TSO4) | \ > + (1ULL << VIRTIO_NET_F_HOST_TSO6) | \ > + (1ULL << VIRTIO_NET_F_HOST_UFO) | \ > + (1ULL << VIRTIO_NET_F_HOST_ECN) | \ > + (1ULL << VIRTIO_NET_F_CSUM) | \ > + (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \ > + (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ > + (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \ > + (1ULL << VIRTIO_NET_F_GUEST_UFO) | \ > + (1ULL << VIRTIO_NET_F_GUEST_ECN) | \ > + (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \ > + (1ULL << VIRTIO_F_IN_ORDER) | \ > + (1ULL << VIRTIO_F_IOMMU_PLATFORM)) That's a lot of indent/spaces. #define VDUSE_NET_SUPPORTED_FEATURES (\ (1ULL << VIRTIO_NET_F_MRG_RXBUF) | \ (1ULL << VIRTIO_F_ANY_LAYOUT) | \ Plus, can't we use RTE_BIT64? (this could be a cleanup to do on the whole vhost library) --=20 David Marchand