From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02A7E42604; Thu, 21 Sep 2023 09:02:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B1474026D; Thu, 21 Sep 2023 09:02:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9CA074014F for ; Thu, 21 Sep 2023 09:02:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695279723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=85Pw0noQEbC0rCL6N1+HEDyacEeTF+gPonQFf/X1Adc=; b=FNuUTHUcmK3A2Cg7weV1Vvm2xuAGMZZWdrW9par/YNDJXj0UFEcemxukJj/0ApxKY4UF4L uaeg2c59EiBS+42oYLxzhxAAl1xfNtupSAIYrpFyHE0QY/NEyZ1RkbeGsEHD6hi2VRaY3y KXtRlZd3pz991kSUONvuTLUy8QNizNA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-Ucq4nAoEPSiiSiz-gBzonw-1; Thu, 21 Sep 2023 03:02:01 -0400 X-MC-Unique: Ucq4nAoEPSiiSiz-gBzonw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ba1949656bso6975461fa.0 for ; Thu, 21 Sep 2023 00:02:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695279720; x=1695884520; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=85Pw0noQEbC0rCL6N1+HEDyacEeTF+gPonQFf/X1Adc=; b=PGXS016KI/rHAEnQ435Allls9WGMJejCfIZ4JzRqRMWNPP8JQBJBX6T3snKbY2YLY2 P5a2vxENHkWE3E/08d8zBKsJQB2gBSP9t741NmCYz65dEulx1pl82AzOFFlnGe9c7xNd ln3+Ajcrf+8797b4d7O7w3VslZW5jpl6u6Id4elcrL6AlGvFXdn4Didsg64I5U8H+7Tc bDxZybUBs3lLE8C0l/UWBo3UXNVFqyb3/MQ8cCRfLYJmh61tLpU5DVmb7DupanLhIl9t IXC9v4sB/PlFogZkFmLPFfsj109h00cJTVKFNZnHmWsW9TjED2iSZ8xGwB4SoT3IYJS7 7WOQ== X-Gm-Message-State: AOJu0YxbcVHwcvkoVlKB8n/1QDf7Rebpo3YmRfpxcUH0JawPbt8PYiZR 26y3MPP6mniD5bTiUO0mzyNISvDMTZgbm+zp9bvqGhLcCEWPLmu1N3LPybp2iFEJbmYZ/H2t0CW Vi3V96XbzgPnZ0etIsqc= X-Received: by 2002:a2e:8855:0:b0:2bf:7894:a490 with SMTP id z21-20020a2e8855000000b002bf7894a490mr4104409ljj.38.1695279720145; Thu, 21 Sep 2023 00:02:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhwBKvzrNBGsct8jM8rr0ccfJJuRO8VTVpLoZnzHFkUbHOsT0ePCMjcmtU8DLfnya1btDGmGp2KR7wVrr4/vo= X-Received: by 2002:a2e:8855:0:b0:2bf:7894:a490 with SMTP id z21-20020a2e8855000000b002bf7894a490mr4104384ljj.38.1695279719773; Thu, 21 Sep 2023 00:01:59 -0700 (PDT) MIME-Version: 1.0 References: <20230901142332.588856-1-bruce.richardson@intel.com> In-Reply-To: <20230901142332.588856-1-bruce.richardson@intel.com> From: David Marchand Date: Thu, 21 Sep 2023 09:01:48 +0200 Message-ID: Subject: Re: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable To: Bruce Richardson Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Patrick Robb X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 1, 2023 at 4:23=E2=80=AFPM Bruce Richardson wrote: > > When the user passes a list of desired libraries to build via the > "enable_libs" option, the expectation is that those libraries should be > part of the build. However, if those libs have either external or > internal dependencies, they still may be silently disabled, for example: > running "meson setup -Denable_libs=3Dsecurity build" will successfully > run, but the security lib will not be configured as "cryptodev" is > missing. > > We can fix this by setting a flag to indicate when the libraries are > specified via an enable_libs flag. If so, then we error out when a > library is unbuildable, giving a suitable error message. For the above > example case, the "meson setup" run fails with: > > Message: Disabling security [lib/security]: missing internal dependency "= cryptodev" > > lib/meson.build:218:16: ERROR: Problem encountered: Cannot build explicit= ly requested lib "security". > Please add missing dependency "cryptodev" to "enable_libs" option > > Signed-off-by: Bruce Richardson CI now passes fine after a retest. Series applied, thanks Bruce. --=20 David Marchand