From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id E4B871B579 for ; Thu, 25 Apr 2019 16:38:28 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id t23so12618267vso.10 for ; Thu, 25 Apr 2019 07:38:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xiXuWWmY+Vmj3iC+r6nI/mehs3AjUsUhSZ66+WESdWE=; b=Ge8fuyABVTU5OPg4hTIfreY2D5vFqO+rRO1dDm8m1Y0hUhiLbdsexFN7vpPZOxQqjL AxrMtaTIGC9PA00TP6W44VAsMYqgC/iOSEUnvsLVNnIekTl762wzzP0UzR9ub1Q6UAfm a8zxPxHIhwCJH2yw18kHj7pTlJlEq/T4cwSyZwtn/lCN73/pVT+Uizdf2BW9GBswSOC1 r4DzMRQGeMXmvHDf0m6lTkzwEUIj6B/ntsDeeiMIIVBROgZUefaRH31aV+APmzEtYAeb t5xRQuxXjLEKJQSKZaDbwmt3Gn0UsqRjVqSrnGrEpKLx+jRZQdBelCO2By/NzxvIFq7U QSVA== X-Gm-Message-State: APjAAAUI8/oBYlLUBLcV4VrKDRiLV/e08zDSBSmQA4x0FaF4Sjf3hvlY +e8iFU9qnhESK+MH9KpOcmXcTdeTP9nyOvny9EkIfA== X-Google-Smtp-Source: APXvYqyh9pAoiQ8+IW+sbR17+5+3xviVoXNtM/9fGKSWrv9eAJksk+MCIsW2GIEt8BKwmDnktcABg84VThleE7mlgNM= X-Received: by 2002:a67:edcb:: with SMTP id e11mr21148410vsp.105.1556203108273; Thu, 25 Apr 2019 07:38:28 -0700 (PDT) MIME-Version: 1.0 References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190417041359.45335-1-honnappa.nagarahalli@arm.com> <2742111.xWhxeopsW5@xps> In-Reply-To: From: David Marchand Date: Thu, 25 Apr 2019 16:38:17 +0200 Message-ID: To: Honnappa Nagarahalli Cc: "thomas@monjalon.net" , "dev@dpdk.org" , "konstantin.ananyev@intel.com" , "stephen@networkplumber.org" , "paulmck@linux.ibm.com" , "marko.kovacevic@intel.com" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , Malvika Gupta , nd Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2019 14:38:29 -0000 On Thu, Apr 25, 2019 at 4:19 PM Honnappa Nagarahalli < Honnappa.Nagarahalli@arm.com> wrote: > > - shared link is broken because of rcu_log_type not exported > I am not sure what this is. Is this shared library compilation? Can you > please let me know how to reproduce this? > > > - some public symbols (variable, macros, functions) are not prefixed > with rte > For my understanding, are you referring to the following symbols? > rcu_log_type > RCU_DP_LOG - This is internal to the library, will change it to > __RTE_RCU_DP_LOG > RCU_IS_LOCK_CNT_ZERO - Same as above > __rcu_qsbr_check_selective > __rcu_qsbr_check_all > Afaiu, those are exposed via exported symbols, so they are part of the api. You need to prefix them. Had a quick look at the code, I suppose enabling rcu debug and shared library will trigger the link issue Thomas reported. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8001FA05D3 for ; Thu, 25 Apr 2019 16:38:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B9361B598; Thu, 25 Apr 2019 16:38:31 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id E4B871B579 for ; Thu, 25 Apr 2019 16:38:28 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id t23so12618267vso.10 for ; Thu, 25 Apr 2019 07:38:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xiXuWWmY+Vmj3iC+r6nI/mehs3AjUsUhSZ66+WESdWE=; b=Ge8fuyABVTU5OPg4hTIfreY2D5vFqO+rRO1dDm8m1Y0hUhiLbdsexFN7vpPZOxQqjL AxrMtaTIGC9PA00TP6W44VAsMYqgC/iOSEUnvsLVNnIekTl762wzzP0UzR9ub1Q6UAfm a8zxPxHIhwCJH2yw18kHj7pTlJlEq/T4cwSyZwtn/lCN73/pVT+Uizdf2BW9GBswSOC1 r4DzMRQGeMXmvHDf0m6lTkzwEUIj6B/ntsDeeiMIIVBROgZUefaRH31aV+APmzEtYAeb t5xRQuxXjLEKJQSKZaDbwmt3Gn0UsqRjVqSrnGrEpKLx+jRZQdBelCO2By/NzxvIFq7U QSVA== X-Gm-Message-State: APjAAAUI8/oBYlLUBLcV4VrKDRiLV/e08zDSBSmQA4x0FaF4Sjf3hvlY +e8iFU9qnhESK+MH9KpOcmXcTdeTP9nyOvny9EkIfA== X-Google-Smtp-Source: APXvYqyh9pAoiQ8+IW+sbR17+5+3xviVoXNtM/9fGKSWrv9eAJksk+MCIsW2GIEt8BKwmDnktcABg84VThleE7mlgNM= X-Received: by 2002:a67:edcb:: with SMTP id e11mr21148410vsp.105.1556203108273; Thu, 25 Apr 2019 07:38:28 -0700 (PDT) MIME-Version: 1.0 References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190417041359.45335-1-honnappa.nagarahalli@arm.com> <2742111.xWhxeopsW5@xps> In-Reply-To: From: David Marchand Date: Thu, 25 Apr 2019 16:38:17 +0200 Message-ID: To: Honnappa Nagarahalli Cc: "thomas@monjalon.net" , "dev@dpdk.org" , "konstantin.ananyev@intel.com" , "stephen@networkplumber.org" , "paulmck@linux.ibm.com" , "marko.kovacevic@intel.com" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , Malvika Gupta , nd Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190425143817.R2GNyQNCfb_EBPtyi5Xq-lJxvjwazdji_DEyP30INWA@z> On Thu, Apr 25, 2019 at 4:19 PM Honnappa Nagarahalli < Honnappa.Nagarahalli@arm.com> wrote: > > - shared link is broken because of rcu_log_type not exported > I am not sure what this is. Is this shared library compilation? Can you > please let me know how to reproduce this? > > > - some public symbols (variable, macros, functions) are not prefixed > with rte > For my understanding, are you referring to the following symbols? > rcu_log_type > RCU_DP_LOG - This is internal to the library, will change it to > __RTE_RCU_DP_LOG > RCU_IS_LOCK_CNT_ZERO - Same as above > __rcu_qsbr_check_selective > __rcu_qsbr_check_all > Afaiu, those are exposed via exported symbols, so they are part of the api. You need to prefix them. Had a quick look at the code, I suppose enabling rcu debug and shared library will trigger the link issue Thomas reported. -- David Marchand