From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E11445BC0; Thu, 24 Oct 2024 12:04:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9036943405; Thu, 24 Oct 2024 12:04:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 73CE94003C for ; Thu, 24 Oct 2024 12:04:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729764255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOyFiU9pi0995V1k28XGEO8DxPo/XWUJGGFl4xItuYo=; b=eWIoP2+VhwQaaSBgrrH6Laa4KFq5M2O6wxoLb5m1OQ3jQ44gkfdqbBGXko0/aDJ75HvW6o Co+gIdVBTuI6kzQxE2tzARlF3KTH4WSxy1AEjcahHmNLuX7kZUsc9zZNzFrX59WZaxTIWr 0bXU5soAAt9U3cXKgjy6B62uJfU7xZM= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-QAr2NSnFPzSWWgGATnNr7Q-1; Thu, 24 Oct 2024 06:04:14 -0400 X-MC-Unique: QAr2NSnFPzSWWgGATnNr7Q-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-53a0b48e8d4so603856e87.3 for ; Thu, 24 Oct 2024 03:04:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729764252; x=1730369052; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eOyFiU9pi0995V1k28XGEO8DxPo/XWUJGGFl4xItuYo=; b=YRj12OEAnZVvlqRkKRpbX3gGv7O9STjNEbPDhoKon2Nv9XFIB3Vs/gO/Hq6dDkVdan 7fu/5aSEUa6RTQfBZrObaIBMX25ALMS6OpKBkNe3ekYDcEOp2qL/z7rVFaUA6X1Pv0F2 0o8qYWbDru1STV3Pqm09D1JMkNGf7XIXB9ZP8MQAEbL8XII4s2rqSdKe4yBLnOY38Jav 8nmMGpqfA32HetlGhPxbWtqWqzN1gwua6rqp3k90othCtSwrLPyfhIqEKq5K54eUccxB wSBj5bwhbZcrOLbIYB/fGKX2aQWjz74uxQVBx2i6JLpBOcLMoYFXBQNPDGauTduDAwwu yAUw== X-Gm-Message-State: AOJu0Yzq5uP3dg2ZsSU9ab4wAryPjXQZZgsRXOWLl7i/TY/0e+ewmPOL jMOio0Jp4F2aBy3ZiucSOwYTtjwXpP5TftNcJa3zmcIXSw13P1LMWQ6xQILOR2G8qikj83DuoIi otdiBSMTdKXsK39Lf5ANFkDLTtBpks7kiCOzHHqxZB//5tE+f0pIaISn0PC3pv2bZ0GQyu95XjM UvmGtSyb88lwQmKxw= X-Received: by 2002:a05:6512:3053:b0:539:f7a2:65ac with SMTP id 2adb3069b0e04-53b23e25304mr787907e87.35.1729764252483; Thu, 24 Oct 2024 03:04:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiKPdjApzldrOTHE8D/fctJbjwjbkAIWURUaNAPs3EpklRHeH7Fomg2Q9T+xMWQimuVaAP7oY/q2LS6QQiVqs= X-Received: by 2002:a05:6512:3053:b0:539:f7a2:65ac with SMTP id 2adb3069b0e04-53b23e25304mr787891e87.35.1729764252012; Thu, 24 Oct 2024 03:04:12 -0700 (PDT) MIME-Version: 1.0 References: <20241024094406.3826637-1-maxime.coquelin@redhat.com> <20241024094406.3826637-4-maxime.coquelin@redhat.com> In-Reply-To: <20241024094406.3826637-4-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 24 Oct 2024 12:04:01 +0200 Message-ID: Subject: Re: [PATCH v3 3/6] vhost: fix VDUSE reconnect device start failure To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 24, 2024 at 11:44=E2=80=AFAM Maxime Coquelin wrote: > > This patch fixes a FD leak in the VDUSE device reconnect > code fails to start the device. > > Also take the opportunity to refactor the related code into > a dedicated function. > > Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE") > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --=20 David Marchand