From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A95443081; Wed, 16 Aug 2023 16:56:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42F4E40693; Wed, 16 Aug 2023 16:56:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 732964003C for ; Wed, 16 Aug 2023 16:56:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692197798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wxTtX/2FZkBc2bQi08lBp+dNaTq3VrmVuCM/MogMBRs=; b=A9KQtJVEVCR2GMxj1eGBFmwg4x9RuhaAVhhPFPqt9bK2YkVHzwZ139xJU7uwUimo9WsF6G PQ8v/xgGof5NgLsouMAG0AOF6SshMtPQKo+2OZUCNmy1MTgGVdlNWBUi68u8hOI2P4TDJq p2i6WebCeNCnCvcEyaeKnXQqfVs1ifg= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-4-ZvBcwLP4ukENyDZoeQeQ-1; Wed, 16 Aug 2023 10:56:37 -0400 X-MC-Unique: 4-ZvBcwLP4ukENyDZoeQeQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4ff75f3239aso3280903e87.3 for ; Wed, 16 Aug 2023 07:56:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692197795; x=1692802595; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wxTtX/2FZkBc2bQi08lBp+dNaTq3VrmVuCM/MogMBRs=; b=AcKaBcXLCHPmrgIw8Sg7nsChRTrvhY1ptUPrRr9QldGN4/2YUO5h9dqMKEzdtKolNT 1rU+/2B5/KRqCK6mIe2ZIaKTcnGytmAtr+qy2+tRcHoOQ3g5YpobJHhhRDu48S/AO2Y8 7OXMi2zANmYnRfMODaW2s4py0vR29HoVWn88E7vudX+Ubqzgh3F5rcvDH3Nam04XMOQS d9YQ+6G2CPXWgcY1dDKaHiNqUnsINiX3UWKRB8Eyq6mgrwmJRRrlAKuXYXwOwStflJ/i quEmn3AljY504qeVvqbqmgfxCuggQIIT1uqGU+A77uWPVaJZ9fez9hoVHW747h4kicgt KYVw== X-Gm-Message-State: AOJu0Yzm9HQMW4UglGlhFNDia8RK7h07ANT9VHdkKlKlqbfCVBduuUyH h3lWIK4VgvpHDjDcpzMpKZ1KUm/prIh7vGzGgtb4G5BMIyPNSq3Iha0Z+c/4VMHQLQ7lBOw7cvk RAgF0FcAgiKJNEY4Kf6I= X-Received: by 2002:a19:5010:0:b0:4fe:590:53ca with SMTP id e16-20020a195010000000b004fe059053camr1558213lfb.4.1692197795256; Wed, 16 Aug 2023 07:56:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCLpjiaX3qzE/mBS+mefHX9AIRlsP7bnPmOcTKMMagt8aDpQqD62k76/uiFqlkSMRdREIMsBumrtB2i1FbDIU= X-Received: by 2002:a19:5010:0:b0:4fe:590:53ca with SMTP id e16-20020a195010000000b004fe059053camr1558202lfb.4.1692197794906; Wed, 16 Aug 2023 07:56:34 -0700 (PDT) MIME-Version: 1.0 References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-3-bruce.richardson@intel.com> In-Reply-To: <20230815151053.996469-3-bruce.richardson@intel.com> From: David Marchand Date: Wed, 16 Aug 2023 16:56:23 +0200 Message-ID: Subject: Re: [PATCH v5 02/10] app/test: tag tests with the test type To: Bruce Richardson Cc: dev@dpdk.org, ci@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 15, 2023 at 5:23=E2=80=AFPM Bruce Richardson wrote: > diff --git a/app/test/test_acl.c b/app/test/test_acl.c > index 623f34682e..bf1466fe11 100644 > --- a/app/test/test_acl.c > +++ b/app/test/test_acl.c > @@ -1749,4 +1749,4 @@ test_acl(void) > > #endif /* !RTE_EXEC_ENV_WINDOWS */ > > -REGISTER_TEST_COMMAND(acl_autotest, test_acl); > +REGISTER_FAST_TEST(acl_autotest, True, True, test_acl); A bit surprising to read "True" and not "true" in some C code. I see meson supports both forms. Do you have a reason to go with "True"? Maybe you prefer to keep it like this so it is not confused with the C boolean keyword? --=20 David Marchand