From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0C8DA04FA; Wed, 5 Feb 2020 17:43:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0B9D1C2E7; Wed, 5 Feb 2020 17:43:29 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 204421C2B4 for ; Wed, 5 Feb 2020 17:43:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580921007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XZdg2VRqLWhld+kEcXmSvDMIQYdUcTJR5RHc3kdP06w=; b=VdlygZgoGbh+bOGpGmLSV1F+m8b6FvIrseUC3G7V6e/uEf/K88XV+Uwh2jjQCVqOiMyDsF GPwbK22zQsiUZ4VejTlZqOzaOt/3WQOvlpxoBlMAko2MKbqbLeNIuZysnv6IUjFN1MLj/W hVN1vWnVakUmFlmdl7AuZOtgWKiaVuU= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-4KeYEBiPOCe5LqUlt7OyVQ-1; Wed, 05 Feb 2020 11:43:11 -0500 Received: by mail-vk1-f200.google.com with SMTP id n9so808377vkc.14 for ; Wed, 05 Feb 2020 08:43:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hMdRXTMeJXy9a2GN/f6biEkKcmqWbFURLGlw4BkxJrE=; b=WcwEPt1z3z8el48mdlskZwfOFdxdxkl6DilmLkh/TJxtc5lhY5/6QA3vUM6cl5ONgw H5f9jbZZAGy3miDhIAyRFoTa0Ambl45uAWuwr8Cp/Un0jig5eUKVTXldByJM8/sb+rL6 psDPuLgZAQe0cYeYVefE0m8Rfx/FhmwSK2WKYzZppDkkRTrLUmLurNJBj+PaLE6FZe3z fLiherVUmys4/Yz1VjlsoT0sk7+4nKjp31gspzZejrTnG7qYQMH/bHwfcRl3Ec61Gfkr wTlDFv2+Aorgn0TGmhJEQMjwetIQR5z90du8nNc8k35z/kjzuJSpte26FMBgGKH/tDLY c0Yg== X-Gm-Message-State: APjAAAVqEvgyLotdVafk0FWQWB3lwylT4qVjCjxoIyNaMlIn6kWBfDap NTLCjVr14AnL7fglvgNLhNyaIEHBvphtOgBUh2nPyarPUwpJwpM7Elkw5Sjj/G4VrusGX4H1TEN QV113TPyI9UYCYTaNZ6s= X-Received: by 2002:a67:e342:: with SMTP id s2mr21986992vsm.198.1580920991447; Wed, 05 Feb 2020 08:43:11 -0800 (PST) X-Google-Smtp-Source: APXvYqxZ2Z+Jig+mG/WlAdNYlimPuk/FozCLk38AiY9AbW6nWzdpijW6V1bouOIWxrjMBe7AM6Xy6TE2t/+lPTVwz2M= X-Received: by 2002:a67:e342:: with SMTP id s2mr21986971vsm.198.1580920991165; Wed, 05 Feb 2020 08:43:11 -0800 (PST) MIME-Version: 1.0 References: <1567748973-24192-1-git-send-email-agupta3@marvell.com> <20200203194912.4669-1-honnappa.nagarahalli@arm.com> <20200203194912.4669-3-honnappa.nagarahalli@arm.com> In-Reply-To: From: David Marchand Date: Wed, 5 Feb 2020 17:42:59 +0100 Message-ID: To: ci@dpdk.org, Thomas Monjalon Cc: Amit Gupta , "Wang, Yipeng1" , "Gobriel, Sameh" , dev , nd , "Mcnamara, John" , "Yigit, Ferruh" , Honnappa Nagarahalli X-MC-Unique: 4KeYEBiPOCe5LqUlt7OyVQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 2/5] test/hash: remove duplicated test code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 5, 2020 at 9:48 AM David Marchand w= rote: > > On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli > wrote: > > > > The test case target 'hash_readwrite_autotest' is covered by > > 'hash_readwrite_func_autotest' and 'hash_readwrite_perf_autotest'. > > Hence, it is removed along with its test code. > > > > Signed-off-by: Honnappa Nagarahalli > > --- > > app/test/autotest_data.py | 10 +++- > > app/test/test_hash_readwrite.c | 101 --------------------------------- > > 2 files changed, 8 insertions(+), 103 deletions(-) > > > > diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py > > index 6deb97bcc..71db4b3f6 100644 > > --- a/app/test/autotest_data.py > > +++ b/app/test/autotest_data.py > > @@ -664,8 +664,14 @@ > > "Report": None, > > }, > > { > > - "Name": "Hash read-write concurrency autotest", > > - "Command": "hash_readwrite_autotest", > > + "Name": "Hash read-write concurrency functional autotest", > > + "Command": "hash_readwrite_func_autotest", > > + "Func": default_autotest, > > + "Report": None, > > + }, > > + { > > + "Name": "Hash read-write concurrency perf autotest", > > + "Command": "hash_readwrite_perf_autotest", > > "Func": default_autotest, > > "Report": None, > > }, > > diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwr= ite.c > > index aa55db7fe..635ed5a9f 100644 > > --- a/app/test/test_hash_readwrite.c > > +++ b/app/test/test_hash_readwrite.c > > @@ -749,106 +749,5 @@ test_hash_rw_func_main(void) > > return 0; > > } > > > > -static int > > -test_hash_readwrite_main(void) > > -{ > > - /* > > - * Variables used to choose different tests. > > - * use_htm indicates if hardware transactional memory should be= used. > > - * reader_faster indicates if the reader threads should finish = earlier > > - * than writer threads. This is to timing either reader threads= or > > - * writer threads for performance numbers. > > - */ > > - int use_htm, use_ext, reader_faster; > > - unsigned int i =3D 0, core_id =3D 0; > > - > > - if (rte_lcore_count() < 3) { > > - printf("Not enough cores for hash_readwrite_autotest, e= xpecting at least 3\n"); > > - return TEST_SKIPPED; > > - } > > - > > - RTE_LCORE_FOREACH_SLAVE(core_id) { > > - slave_core_ids[i] =3D core_id; > > - i++; > > - } > > - > > - setlocale(LC_NUMERIC, ""); > > - > > - if (rte_tm_supported()) { > > - printf("Hardware transactional memory (lock elision) " > > - "is supported\n"); > > - > > - printf("Test read-write with Hardware transactional mem= ory\n"); > > - > > - use_htm =3D 1; > > - use_ext =3D 0; > > - > > - if (test_hash_readwrite_functional(use_ext, use_htm) < = 0) > > - return -1; > > - > > - use_ext =3D 1; > > - if (test_hash_readwrite_functional(use_ext, use_htm) < = 0) > > - return -1; > > - > > - reader_faster =3D 1; > > - if (test_hash_readwrite_perf(&htm_results, use_htm, > > - reader_faster) = < 0) > > - return -1; > > - > > - reader_faster =3D 0; > > - if (test_hash_readwrite_perf(&htm_results, use_htm, > > - reader_faster) = < 0) > > - return -1; > > - } else { > > - printf("Hardware transactional memory (lock elision) " > > - "is NOT supported\n"); > > - } > > - > > - printf("Test read-write without Hardware transactional memory\n= "); > > - use_htm =3D 0; > > - use_ext =3D 0; > > - if (test_hash_readwrite_functional(use_ext, use_htm) < 0) > > - return -1; > > - > > - use_ext =3D 1; > > - if (test_hash_readwrite_functional(use_ext, use_htm) < 0) > > - return -1; > > - > > - reader_faster =3D 1; > > - if (test_hash_readwrite_perf(&non_htm_results, use_htm, > > - reader_faster) = < 0) > > - return -1; > > - reader_faster =3D 0; > > - if (test_hash_readwrite_perf(&non_htm_results, use_htm, > > - reader_faster) = < 0) > > - return -1; > > - > > - printf("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); > > - printf("Results summary:\n"); > > - printf("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); > > - > > - printf("single read: %u\n", htm_results.single_read); > > - printf("single write: %u\n", htm_results.single_write); > > - for (i =3D 0; i < NUM_TEST; i++) { > > - printf("+++ core_cnt: %u +++\n", core_cnt[i]); > > - printf("HTM:\n"); > > - printf(" read only: %u\n", htm_results.read_only[i]); > > - printf(" write only: %u\n", htm_results.write_only[i])= ; > > - printf(" read-write read: %u\n", htm_results.read_writ= e_r[i]); > > - printf(" read-write write: %u\n", htm_results.read_wri= te_w[i]); > > - > > - printf("non HTM:\n"); > > - printf(" read only: %u\n", non_htm_results.read_only[i= ]); > > - printf(" write only: %u\n", non_htm_results.write_only= [i]); > > - printf(" read-write read: %u\n", > > - non_htm_results.read_write_r[i]); > > - printf(" read-write write: %u\n", > > - non_htm_results.read_write_w[i]); > > - } > > - > > - return 0; > > -} > > - > > -REGISTER_TEST_COMMAND(hash_readwrite_autotest, test_hash_readwrite_mai= n); > > REGISTER_TEST_COMMAND(hash_readwrite_func_autotest, test_hash_rw_func_= main); > > REGISTER_TEST_COMMAND(hash_readwrite_perf_autotest, test_hash_rw_perf_= main); > > -- > > 2.17.1 > > > > I can see that DTS references this test: > https://git.dpdk.org/tools/dts/tree/tests/TestSuite_unit_tests_eal.py#n16= 4 > > Travis (and UNH) also runs those unit tests (via the list included in mes= on). > > Is there a reason to keep those in DTS? I will take this as a no and go ahead with this patch. --=20 David Marchand